You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/06/29 02:21:05 UTC

[GitHub] [pulsar] Nicklee007 opened a new pull request, #16273: [fix][broker] fix the local police IsolationGroups permanent cover the defaultIsolationGroups

Nicklee007 opened a new pull request, #16273:
URL: https://github.com/apache/pulsar/pull/16273

   Fixes #16272
   
   ### Motivation
   Fix the local police IsolationGroups permanent cover the `defaultIsolationGroups`, which will cause even we rollback the local police to empty,  the `defaultIsolationGroups` always use the latest local police IsolationGroups setting and  is not use the setting in broker.conf as default.
   
   The `defaultIsolationGroups` be covered point.
   https://github.com/apache/pulsar/blob/0eed84203b23e325ac15d7dc50e1ed6dbdf4fa2a/pulsar-broker-common/src/main/java/org/apache/pulsar/bookie/rackawareness/IsolatedBookieEnsemblePlacementPolicy.java#L141
   
   ### Modifications
   1.  fix the `defaultIsolationGroups` be covered point 
   2. merge the `newEnsemble` and `replaceBookie` method duplication code to `getBlacklistedBookies()` ,to avoid change only cover one method in the future. 
   3. add some unit test.
   `
   ### Verifying this change
   
   - [X] `doc-not-needed` 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Nicklee007 commented on pull request #16273: [fix][broker] fix the local police IsolationGroups permanent cover the defaultIsolationGroups

Posted by GitBox <gi...@apache.org>.
Nicklee007 commented on PR #16273:
URL: https://github.com/apache/pulsar/pull/16273#issuecomment-1169611191

   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] gaozhangmin merged pull request #16273: [fix][broker] fix the local police IsolationGroups permanent cover the defaultIsolationGroups

Posted by GitBox <gi...@apache.org>.
gaozhangmin merged PR #16273:
URL: https://github.com/apache/pulsar/pull/16273


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] gaozhangmin commented on pull request #16273: [fix][broker] fix the local police IsolationGroups permanent cover the defaultIsolationGroups

Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on PR #16273:
URL: https://github.com/apache/pulsar/pull/16273#issuecomment-1169689869

   Good catch


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Nicklee007 commented on pull request #16273: [fix][broker] fix the local police IsolationGroups permanent cover the defaultIsolationGroups

Posted by GitBox <gi...@apache.org>.
Nicklee007 commented on PR #16273:
URL: https://github.com/apache/pulsar/pull/16273#issuecomment-1169607826

   run failure checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Nicklee007 commented on pull request #16273: [fix][broker] fix the local police IsolationGroups permanent cover the defaultIsolationGroups

Posted by GitBox <gi...@apache.org>.
Nicklee007 commented on PR #16273:
URL: https://github.com/apache/pulsar/pull/16273#issuecomment-1169680151

   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org