You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "lordgamez (via GitHub)" <gi...@apache.org> on 2023/04/06 18:17:05 UTC
[GitHub] [nifi-minifi-cpp] lordgamez opened a new pull request, #1551: MINIFICPP-2091 Add ARM64 support for docker system tests
lordgamez opened a new pull request, #1551:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1551
Update docker images with multi-arch versions supporting ARM64.
Unfortunately Splunk Enterprise is not releasing ARM64 binaries, so no Splunk ARM64 image is available at the moment, Splunk tests are skipped on ARM64.
https://issues.apache.org/jira/browse/MINIFICPP-2091
--------------------
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically main)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] martinzink closed pull request #1551: MINIFICPP-2091 Add ARM64 support for docker system tests
Posted by "martinzink (via GitHub)" <gi...@apache.org>.
martinzink closed pull request #1551: MINIFICPP-2091 Add ARM64 support for docker system tests
URL: https://github.com/apache/nifi-minifi-cpp/pull/1551
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1551: MINIFICPP-2091 Add ARM64 support for docker system tests
Posted by "lordgamez (via GitHub)" <gi...@apache.org>.
lordgamez commented on code in PR #1551:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1551#discussion_r1165618648
##########
docker/test/integration/resources/kafka_broker/conf/server.properties:
##########
@@ -28,15 +28,15 @@ broker.id=0
# listeners = listener_name://host_name:port
# EXAMPLE:
# listeners = PLAINTEXT://your.host.name:9092
-#listeners=PLAINTEXT://:9092
+listeners=PLAINTEXT://kafka-broker:9092,SSL://kafka-broker:9093,SASL_PLAINTEXT://kafka-broker:9094,SASL_SSL://kafka-broker:9095,SSL_HOST://0.0.0.0:29093,PLAINTEXT_HOST://0.0.0.0:29092,SASL_PLAINTEXT_HOST://0.0.0.0:29094,SASL_SSL_HOST://0.0.0.0:29095
# Hostname and port the broker will advertise to producers and consumers. If not set,
# it uses the value for "listeners" if configured. Otherwise, it will use the value
# returned from java.net.InetAddress.getCanonicalHostName().
-#advertised.listeners=PLAINTEXT://your.host.name:9092
+advertised.listeners=PLAINTEXT://kafka-broker:9092,PLAINTEXT_HOST://localhost:29092,SSL://kafka-broker:9093,SSL_HOST://localhost:29093,SASL_PLAINTEXT://kafka-broker:9094,SASL_PLAINTEXT_HOST://localhost:29094,SASL_SSL://kafka-broker:9095,SASL_SSL_HOST://localhost:29095
Review Comment:
The order doesn't matter, it's better to have a consistent order for all properties, updated in 80b1ea36d601632083e4a8b16b5731e8495a668b
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a diff in pull request #1551: MINIFICPP-2091 Add ARM64 support for docker system tests
Posted by "adamdebreceni (via GitHub)" <gi...@apache.org>.
adamdebreceni commented on code in PR #1551:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1551#discussion_r1173684459
##########
docker/test/integration/cluster/containers/OPCUAServerContainer.py:
##########
@@ -31,7 +31,7 @@ def deploy(self):
logging.info('Creating and running OPC UA server docker container...')
self.client.containers.run(
- "lordgamez/open62541:1.3.3",
+ "lordgamez/open62541:1.3.5",
Review Comment:
is it possible to host this under the apache user?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1551: MINIFICPP-2091 Add ARM64 support for docker system tests
Posted by "lordgamez (via GitHub)" <gi...@apache.org>.
lordgamez commented on code in PR #1551:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1551#discussion_r1173693240
##########
docker/test/integration/cluster/containers/OPCUAServerContainer.py:
##########
@@ -31,7 +31,7 @@ def deploy(self):
logging.info('Creating and running OPC UA server docker container...')
self.client.containers.run(
- "lordgamez/open62541:1.3.3",
+ "lordgamez/open62541:1.3.5",
Review Comment:
I'm not sure as it is not an Apache product. I created an [issue](https://github.com/open62541/open62541/issues/5082) a while back to publish the open62541 for the new releases, but so far it has not been done yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1551: MINIFICPP-2091 Add ARM64 support for docker system tests
Posted by "fgerlits (via GitHub)" <gi...@apache.org>.
fgerlits commented on code in PR #1551:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1551#discussion_r1165563766
##########
docker/test/integration/resources/kafka_broker/conf/server.properties:
##########
@@ -28,15 +28,15 @@ broker.id=0
# listeners = listener_name://host_name:port
# EXAMPLE:
# listeners = PLAINTEXT://your.host.name:9092
-#listeners=PLAINTEXT://:9092
+listeners=PLAINTEXT://kafka-broker:9092,SSL://kafka-broker:9093,SASL_PLAINTEXT://kafka-broker:9094,SASL_SSL://kafka-broker:9095,SSL_HOST://0.0.0.0:29093,PLAINTEXT_HOST://0.0.0.0:29092,SASL_PLAINTEXT_HOST://0.0.0.0:29094,SASL_SSL_HOST://0.0.0.0:29095
# Hostname and port the broker will advertise to producers and consumers. If not set,
# it uses the value for "listeners" if configured. Otherwise, it will use the value
# returned from java.net.InetAddress.getCanonicalHostName().
-#advertised.listeners=PLAINTEXT://your.host.name:9092
+advertised.listeners=PLAINTEXT://kafka-broker:9092,PLAINTEXT_HOST://localhost:29092,SSL://kafka-broker:9093,SSL_HOST://localhost:29093,SASL_PLAINTEXT://kafka-broker:9094,SASL_PLAINTEXT_HOST://localhost:29094,SASL_SSL://kafka-broker:9095,SASL_SSL_HOST://localhost:29095
Review Comment:
Does the order of these matter? It would be easier to read if the two lists were in the same order.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org