[GitHub] [fineract] ptuomola commented on a change in pull request #1887: FINERACT-1399 Tag as non-mandatory field in Chart Of Accounts bulk up…

[GitBox <gi...@apache.org>]

ptuomola commented on a change in pull request #1887:
URL: https://github.com/apache/fineract/pull/1887#discussion_r725399303



##########
File path: fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/populator/chartofaccounts/ChartOfAccountsWorkbook.java
##########
@@ -231,7 +231,7 @@ private void setLayout(Sheet chartOfAccountsSheet) {
         writeString(ChartOfAcountsConstants.PARENT_COL, rowHeader, "Parent");
         writeString(ChartOfAcountsConstants.PARENT_ID_COL, rowHeader, "Parent Id");
         writeString(ChartOfAcountsConstants.ACCOUNT_NAME_COL, rowHeader, "Account Name");
-        writeString(ChartOfAcountsConstants.TAG_COL, rowHeader, "Tag *");

Review comment:
       "\*" means a mandatory field, so if we are making this non-mandatory then we should remove the "\*"... 
   
   Hope this sounds ok? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org