[jira] [Commented] (OOZIE-1202) ActionKillXCommand precondition is wrong

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OOZIE-1202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13568211#comment-13568211 ] 

Hadoop QA commented on OOZIE-1202:
----------------------------------

Testing JIRA OOZIE-1202

Cleaning local svn workspace

----------------------------

{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.    {color:green}+1{color} the patch does not introduce any @author tags
.    {color:green}+1{color} the patch does not introduce any tabs
.    {color:green}+1{color} the patch does not introduce any trailing spaces
.    {color:green}+1{color} the patch does not introduce any line longer than 132
.    {color:green}+1{color} the patch does adds/modifies 1 testcase(s)
{color:green}+1 RAT{color}
.    {color:green}+1{color} the patch does not seem to introduce new RAT warnings
{color:green}+1 JAVADOC{color}
.    {color:green}+1{color} the patch does not seem to introduce new Javadoc warnings
{color:green}+1 COMPILE{color}
.    {color:green}+1{color} HEAD compiles
.    {color:green}+1{color} patch compiles
.    {color:green}+1{color} the patch does not seem to introduce new javac warnings
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.    {color:green}+1{color} the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations
.    {color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.    Tests run: 949
.    Tests failed: 2
.    Tests errors: 0

.    The patch failed the following testcases:

.      testWfActionKillSuccess(org.apache.oozie.command.wf.TestWorkflowActionKillXCommand)
.      testWfActionKillFailed(org.apache.oozie.command.wf.TestWorkflowActionKillXCommand)

{color:green}+1 DISTRO{color}
.    {color:green}+1{color} distro tarball builds with the patch 

----------------------------
{color:red}*-1 Overall result, please check the reported -1(s)*{color}


The full output of the test-patch run is available at

.   https://builds.apache.org/job/oozie-trunk-precommit-build/310/
                
> ActionKillXCommand precondition is wrong
> ----------------------------------------
>
>                 Key: OOZIE-1202
>                 URL: https://issues.apache.org/jira/browse/OOZIE-1202
>             Project: Oozie
>          Issue Type: Bug
>          Components: action
>    Affects Versions: trunk
>            Reporter: Robert Kanter
>            Assignee: Robert Kanter
>             Fix For: trunk
>
>         Attachments: OOZIE-1202.patch
>
>
> The {{ActionKillXCommand}}, which kills actions, has the following precondition:
> {code}
> protected void verifyPrecondition() throws CommandException, PreconditionException {
>     if (wfAction.getStatus() != WorkflowActionBean.Status.KILLED) {
>         throw new PreconditionException(ErrorCode.E0726, wfAction.getId());
>     }
> }
> {code}
> This means that if the only way to pass the precondition is for the action to already have been KILLED, which is backwards.  We want the precondition to pass only when the action has not already been KILLED.  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira