You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/04/20 13:35:02 UTC
[GitHub] [incubator-superset] Pinimo opened a new issue #9597: Cache warm-ups never succeed
Pinimo opened a new issue #9597:
URL: https://github.com/apache/incubator-superset/issues/9597
Globally: the **cache warm-up tasks launched by Celery workers all silently fail**. Indeed, they perform `GET`s on the main server's URL without providing the required authentication. However, dashboards may not be loaded without being logged in.
**Related bugs:**
- unit tests on this feature miss the error
- the documentation should mention that the Celery worker needs the `--beat` flag to listen on CeleryBeat schedules (cf `docker-compose.yml` configuration)
At stake: long dashboard load times for our users, or outdated dashboards.
### Expected results
When the Celery worker logs this (notice `'errors': []`):
superset-worker_1 | [2020-04-20 13:05:00,299: INFO/ForkPoolWorker-3] Task cache-warmup[73c09754-4dcb-4674-9ac2-087b04b6e209]
succeeded in 0.1351924880000297s:
{'success': [
'http://superset:8088/superset/explore/?form_data=%7B%22slice_id%22%3A%2031%7D',
'http://superset:8088/superset/explore/?form_data=%7B%22slice_id%22%3A%2032%7D',
'http://superset:8088/superset/explore/?form_data=%7B%22slice_id%22%3A%2033%7D'],
'errors': []}
... we would expect to have something (more or less) like this in the Superset server logs:
```
superset_1 | 172.20.0.6 - - [2020-04-20 13:05:00,049] "POST /superset/explore_json/?form_data=%7B%22slice_id%22%3A HTTP/1.1"
200 738 "http://superset:8088/superset/dashboard/1/" "python-urllib2"
```
Of course, we also hope to have a bunch of items in the Redis logs, and that loading dashboards is lightning-quick.
### Actual results
But we get these logs instead, which show there is a 302 redirect to the login page, followed by a 200 on the login page. This redirect is interpreted as a success by the tests.
```
superset_1 | 172.20.0.6 - - [20/Apr/2020 08:12:00] "GET /superset/explore/?form_data=%7B%22slice_id%22%3A%2030%7D HTTP/1.1"
302 -
superset_1 | INFO:werkzeug:172.20.0.6 - - [20/Apr/2020 08:12:00] "GET /superset/explore/?form_data=%7B%22slice_id%22%3A%2030%7D HTTP/1.1"
302 -
superset_1 | 172.20.0.6 - - [20/Apr/2020 08:12:00] "GET /login/?next=http%3A%2F%2Fsuperset%3A8088%2Fsuperset%2Fexplore%2F%3Fform_data%3D%257B%2522slice_id%2522%253A%252030%257D HTTP/1.1"
200 -
```
(I added a few line returns)
In the Redis, here is the only stored key:
```
$ docker-compose exec redis redis-cli
127.0.0.1:6379> KEYS *
1) "_kombu.binding.celery"
```
Last, the dashboards take time loading the data on the first connection.
#### Screenshots
None
#### How to reproduce the bug
I had to patch the master branch to get this to work. In particular, I have to admit it was not very clear to me whether the config was read from file `docker/pythonpath_dev/superset_config.py` or file `superset/config.py`. So I kind of adapted `superset/config.py` and copied it over to the `pythonpath` one (which looks like it is read by the celery worker, but not the server).
Anyway, this reproduces the bug:
<ol>
<li><code>$ docker system prune --all</code> to remove all dangling images, exited containers and volumes.</li>
<li><code>$ git checkout master && git pull origin master</code></li>
<li><code>$ wget -O configs.patch https://gist.githubusercontent.com/Pinimo/c339ea828974d2141423b6ae64192aa4/raw/f02d49c0bca8acce879936d2650719eb4b0dd6d8/0001-bug-Patch-master-to-reproduce-sweetly-the-cache-warm.patch && git apply configs.patch</code><br>This will apply patches to master to make the scenario work out neatly, in particular add the <code>--beat</code> flag and specify a cache warmup task on all dashboards every minute.</li>
<li><code>$ docker-compose up -d</code></li>
<li>Wait for the containers to be built and up.</li>
<li><code>$ docker-compose logs superset-worker | grep cache-warmup</code></li>
<li><code>$ docker-compose logs superset | grep slice</code></li>
<li><code>$ docker-compose exec redis redis-cli</code> then type <code>KEYS *</code></li>
</ol>
### Environment
(please complete the following information):
- superset version: 0.36.0
- python version: dockerized
- node.js version: dockerized
- npm version: dockerized
### Checklist
- [x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
- [x] I have reproduced the issue with at least the latest released version of superset.
- [x] I have checked the issue tracker for the same issue and I haven't found one similar.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mukulsaini commented on issue #9597: Cache warm-ups never succeed
Posted by GitBox <gi...@apache.org>.
mukulsaini commented on issue #9597:
URL: https://github.com/apache/incubator-superset/issues/9597#issuecomment-670348865
@mistercrunch What I see from the previous commits, previously the endpoint used to cache warmup in `cache.py` get_url waas `/explore_json`. Any reason it was changed to `/explore` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] stale[bot] commented on issue #9597: Cache warm-ups never succeed
Posted by GitBox <gi...@apache.org>.
stale[bot] commented on issue #9597:
URL: https://github.com/apache/incubator-superset/issues/9597#issuecomment-706542907
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue `.pinned` to prevent stale bot from closing the issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] Pinimo commented on issue #9597: Cache warm-ups never succeed
Posted by GitBox <gi...@apache.org>.
Pinimo commented on issue #9597:
URL: https://github.com/apache/incubator-superset/issues/9597#issuecomment-628659239
To my knowledge the feature is (and will stay...) broken :cry:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] Pinimo commented on issue #9597: Cache warm-ups never succeed
Posted by GitBox <gi...@apache.org>.
Pinimo commented on issue #9597:
URL: https://github.com/apache/incubator-superset/issues/9597#issuecomment-669896508
@mukulsaini I have not found the time to address the issue, to my best knowledge it has not been solved yet. If you too find this issue is a real problem, I invite you to talk it over on [Superset's Slack :left_speech_bubble: ](https://join.slack.com/t/apache-superset/shared_invite/enQtNDMxMDY5NjM4MDU0LWJmOTcxYjlhZTRhYmEyYTMzOWYxOWEwMjcwZDZiNWRiNDY2NDUwNzcwMDFhNzE1ZmMxZTZlZWY0ZTQ2MzMyNTU)
Here are a few educated guesses as how to solve the issue:
* either we can work around the auth by... signing in through a headless browser. This seems difficult to me:
* the browser software needs to be installed and launched on the Celery worker (looks like an overkill to me)
* the passphrase and user name need to be handled as secrets
* Perhaps a better solution would involve setting up an API server with its own authentication procedure (or just a new auth method on the same server), to allow the Celery worker to perform cache requests:
* Logging in would require a login token. The token would need to be handed over to the Celery worker on start-up, possibly through an environment variable or shell argument.
* When the cache warm-up starts, the worker would use the token to authenticate through this special auth channel
* He would not be granted any rights on the server except performing cache requests, i.e. `POST` requests that only return empty documents (not usable to extract data from the instance).
* However, we should make sure this would not breach the server's security or reliability. For instance, the token should not be used to flood the server, DB engine and Redis instance (DDOS).
* Not sure at all about this last idea: we could code a new CLI route to return the chart data. The Celery worker would then execute the CLI (if I'm remembering right, all the configs and docker images are the same). However, that would possibly infringe memory limits for the Celery worker.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mukulsaini edited a comment on issue #9597: Cache warm-ups never succeed
Posted by GitBox <gi...@apache.org>.
mukulsaini edited a comment on issue #9597:
URL: https://github.com/apache/incubator-superset/issues/9597#issuecomment-670348865
@mistercrunch What I see from the previous commits, previously the route used to cache warmup in `cache.py` get_url was `/explore_json`. Any reason it was changed to `/explore` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mukulsaini edited a comment on issue #9597: Cache warm-ups never succeed
Posted by GitBox <gi...@apache.org>.
mukulsaini edited a comment on issue #9597:
URL: https://github.com/apache/incubator-superset/issues/9597#issuecomment-670348865
@mistercrunch What I see from the previous commits, previously the endpoint used to cache warmup in `cache.py` get_url was `/explore_json`. Any reason it was changed to `/explore` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] Pinimo commented on issue #9597: Cache warm-ups never succeed
Posted by GitBox <gi...@apache.org>.
Pinimo commented on issue #9597:
URL: https://github.com/apache/incubator-superset/issues/9597#issuecomment-616574841
Furthermore, I noticed there is such a login procedure (with a headless browser) in the email report generator. Perhaps that one could be factored out and reused to warm up the cache in our case?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on issue #9597: Cache warm-ups never succeed
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on issue #9597:
URL: https://github.com/apache/incubator-superset/issues/9597#issuecomment-670339579
Mmmh, maybe I'm missing something, but it seems like we shouldn't have to go through the web server to do this.
Refactoring / mimicking what `explore_json` does might be an option.
https://github.com/apache/incubator-superset/blob/master/superset/views/core.py#L525-L536
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] Pinimo commented on issue #9597: Cache warm-ups never succeed
Posted by GitBox <gi...@apache.org>.
Pinimo commented on issue #9597:
URL: https://github.com/apache/incubator-superset/issues/9597#issuecomment-669908361
Yet another draft solution:
4. Simpler than (2): create a user/password for the Celery worker on `db-init`s, with a very specific caching role. I find it important that this role should never be able to actually extract any data (so as not to care too much for the password being stolen), just to ping the server and get it to cache the data. It would even be possible to modify the `@login_required` decorator to add the constraint:
* "if the user belongs only to group `__cache_worker`, then
* he should never POST or PUT
* he should never see any data he requested
* but his data should be sent out to Redis just like for anybody
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] Pinimo commented on issue #9597: Cache warm-ups never succeed
Posted by GitBox <gi...@apache.org>.
Pinimo commented on issue #9597:
URL: https://github.com/apache/incubator-superset/issues/9597#issuecomment-628656143
A colleague made a POC on this, but came to the conclusion it is already quite difficult to have the email reports working... He wanted to use part of that code (headless browser + login) to work around the login problem. I think he found out the dependencies for the feature were not included in the Dockerfile.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] Pinimo edited a comment on issue #9597: Cache warm-ups never succeed
Posted by GitBox <gi...@apache.org>.
Pinimo edited a comment on issue #9597:
URL: https://github.com/apache/incubator-superset/issues/9597#issuecomment-617029235
@jayhjha Perhaps it would be worth changing your config variable `SUPERSET_SERVER_ADDRESS` to `"superset"`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] Pinimo edited a comment on issue #9597: Cache warm-ups never succeed
Posted by GitBox <gi...@apache.org>.
Pinimo edited a comment on issue #9597:
URL: https://github.com/apache/incubator-superset/issues/9597#issuecomment-616574841
BTW, I noticed there is such a login procedure (with a headless browser) in the email report generator. Perhaps that procedure could be factored out and reused to warm up the cache in our case?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] Pinimo edited a comment on issue #9597: Cache warm-ups never succeed
Posted by GitBox <gi...@apache.org>.
Pinimo edited a comment on issue #9597:
URL: https://github.com/apache/incubator-superset/issues/9597#issuecomment-616574841
BTW, I noticed there is such a login procedure (with a headless browser) in the email report generator. Perhaps that one could be factored out and reused to warm up the cache in our case?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] Pinimo commented on issue #9597: Cache warm-ups never succeed
Posted by GitBox <gi...@apache.org>.
Pinimo commented on issue #9597:
URL: https://github.com/apache/incubator-superset/issues/9597#issuecomment-617029235
@jayhjha Perhaps it would be worth changing your environment variable `SUPERSET_SERVER_ADDRESS` to `"superset"`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] stale[bot] commented on issue #9597: Cache warm-ups never succeed
Posted by GitBox <gi...@apache.org>.
stale[bot] commented on issue #9597:
URL: https://github.com/apache/incubator-superset/issues/9597#issuecomment-657603195
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue `.pinned` to prevent stale bot from closing the issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] stefanmo commented on issue #9597: Cache warm-ups never succeed
Posted by GitBox <gi...@apache.org>.
stefanmo commented on issue #9597:
URL: https://github.com/apache/incubator-superset/issues/9597#issuecomment-628562775
Any news on this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] Pinimo edited a comment on issue #9597: Cache warm-ups never succeed
Posted by GitBox <gi...@apache.org>.
Pinimo edited a comment on issue #9597:
URL: https://github.com/apache/incubator-superset/issues/9597#issuecomment-669908361
Yet another draft solution:
4. Simpler than (2): create a user/password for the Celery worker on `db-init`s, with a very specific caching role. I find it important that this role should never be able to actually extract any data (so as not to care too much for the password being stolen), just to ping the server and get it to cache the data. It would even be possible to modify the `@login_required` decorator to add the constraint:
* "if the user belongs only to group `__cache_worker`, then
* he should never POST or PUT
* he should never see any data he requested
* but his data should be sent out to Redis just like for anybody"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mukulsaini commented on issue #9597: Cache warm-ups never succeed
Posted by GitBox <gi...@apache.org>.
mukulsaini commented on issue #9597:
URL: https://github.com/apache/incubator-superset/issues/9597#issuecomment-669774492
@Pinimo any workaround you find to this issue? I am getting the same exact issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] Pinimo edited a comment on issue #9597: Cache warm-ups never succeed
Posted by GitBox <gi...@apache.org>.
Pinimo edited a comment on issue #9597:
URL: https://github.com/apache/incubator-superset/issues/9597#issuecomment-669896508
@mukulsaini I have not found the time to address the issue, to my best knowledge it has not been solved yet. If you too find this issue is a real problem, I invite you to talk it over on [Superset's Slack :left_speech_bubble: ](https://join.slack.com/t/apache-superset/shared_invite/enQtNDMxMDY5NjM4MDU0LWJmOTcxYjlhZTRhYmEyYTMzOWYxOWEwMjcwZDZiNWRiNDY2NDUwNzcwMDFhNzE1ZmMxZTZlZWY0ZTQ2MzMyNTU)
Here are a few educated guesses as how to solve the issue:
1. We could work around the auth by... **signing in through a headless browser** in the Celery process. After thinking it over, it seems difficult to me:
* the browser software needs to be installed and launched on the Celery worker (looks like an overkill to me)
* the passphrase and user name need to be handled as secrets
2. Perhaps a better solution would involve **setting up an API server** with its own authentication procedure -- **or a new auth method on the same server**, to allow the Celery worker to perform cache requests:
* Logging in would require a login token. The token would need to be handed over to the Celery worker on start-up, possibly through an environment variable or shell argument.
* When the cache warm-up starts, the worker would use the token to authenticate through this special auth channel
* He would not be granted any rights on the server except performing cache requests, i.e. `POST` requests that only return empty documents (not usable to extract data from the instance).
* However, we should make sure this would not breach the server's security or reliability. For instance, the token should not be used to flood the server, DB engine and Redis instance (DDOS).
3. Not sure at all about this last idea: we could code a new CLI route to return the chart data. The Celery worker would then execute the CLI (if I'm remembering right, all the configs and docker images are the same). However, that would possibly infringe memory limits for the Celery worker.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] jayhjha commented on issue #9597: Cache warm-ups never succeed
Posted by GitBox <gi...@apache.org>.
jayhjha commented on issue #9597:
URL: https://github.com/apache/incubator-superset/issues/9597#issuecomment-616889868
@Pinimo what does your cache config look like?
I setup redis caching with with a timeout of 5 minutes and cache warmup with the `topndashboard` strategy every 2 minutes (just to test).
I can see this in Celery worker logs:
```
[2020-04-21 00:36:00,009: INFO/ForkPoolWorker-1] cache-warmup[e41de539-0bf7-4e70-b02b-4d2a132d8d0e]: Loading strategy
[2020-04-21 00:36:00,010: INFO/ForkPoolWorker-1] cache-warmup[e41de539-0bf7-4e70-b02b-4d2a132d8d0e]: Loading TopNDashboardsStrategy
[2020-04-21 00:36:00,014: INFO/ForkPoolWorker-1] cache-warmup[e41de539-0bf7-4e70-b02b-4d2a132d8d0e]: Success!
[2020-04-21 00:36:00,043: INFO/ForkPoolWorker-1] cache-warmup[e41de539-0bf7-4e70-b02b-4d2a132d8d0e]: Fetching http://0.0.0.0:8088/superset/explore/?form_data=%7B%22slice_id%22%3A%201%7D
[2020-04-21 01:06:00,131: INFO/ForkPoolWorker-2] cache-warmup[d2d68627-adce-4fa5-852e-522e95350a6c]: {'success': ['http://0.0.0.0:8088/superset/explore/?form_data=%7B%22slice_id%22%3A%201%7D'], 'errors': []}
```
but in Superset logs, I only see:
```
superset_1 | 2020-04-21 00:36:00,049 [DEBUG] [stats_logger] (incr) explore
```
Needless to say, my charts are not being updated
This is my config:
```
CACHE_DEFAULT_TIMEOUT = 300
CACHE_CONFIG = {
'CACHE_TYPE': 'redis',
'CACHE_DEFAULT_TIMEOUT': 180,
'CACHE_KEY_PREFIX': 'superset_results',
'CACHE_REDIS_URL': 'redis://localhost:6379/0',
}
class CeleryConfig(object):
BROKER_URL = 'redis://localhost:6379/0'
CELERY_IMPORTS = (
'superset.sql_lab',
'superset.tasks',
)
CELERY_RESULT_BACKEND = 'redis://localhost:6379/0'
CELERYD_LOG_LEVEL = 'DEBUG'
CELERYD_PREFETCH_MULTIPLIER = 10
CELERY_ACKS_LATE = True
CELERYBEAT_SCHEDULE = {
'cache-warmup-hourly': {
'task': 'cache-warmup',
'schedule': crontab(minute='*/2', hour='*'),
'kwargs': {
'strategy_name': 'top_n_dashboards',
'top_n': 5,
'since': '7 days ago',
},
},
}
CELERY_CONFIG = CeleryConfig
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] Pinimo commented on issue #9597: Cache warm-ups never succeed
Posted by GitBox <gi...@apache.org>.
Pinimo commented on issue #9597:
URL: https://github.com/apache/incubator-superset/issues/9597#issuecomment-658286979
Any news from the community on this issue?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] Pinimo commented on issue #9597: Cache warm-ups never succeed
Posted by GitBox <gi...@apache.org>.
Pinimo commented on issue #9597:
URL: https://github.com/apache/incubator-superset/issues/9597#issuecomment-617021873
Hi @jayhjha, thank you for looking into this. Interesting bug. :thinking:
My cache config is one of these two (which are identical): [one](https://gist.github.com/Pinimo/c339ea828974d2141423b6ae64192aa4/#file-0001-bug-patch-master-to-reproduce-sweetly-the-cache-warm-patch-L390) and [two](https://gist.github.com/Pinimo/c339ea828974d2141423b6ae64192aa4/#file-0001-bug-patch-master-to-reproduce-sweetly-the-cache-warm-patch-L994).
I've put everything in a git patch so you can normally start from master, apply the patch and reproduce.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org