You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Paul Brett <pa...@twopensource.com> on 2015/03/31 08:12:50 UTC
Review Request 32656: Refactor statistics helper out of
PortMappingIsolatorTest for easier reuse.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32656/
-----------------------------------------------------------
Review request for mesos, Chi Zhang, Ian Downes, and Cong Wang.
Bugs: mesos-2332
https://issues.apache.org/jira/browse/mesos-2332
Repository: mesos
Description
-------
Refactor statistics helper out of PortMappingIsolatorTest for easier reuse.
Diffs
-----
src/tests/port_mapping_tests.cpp f4124c3
Diff: https://reviews.apache.org/r/32656/diff/
Testing
-------
make check
Thanks,
Paul Brett
Re: Review Request 32656: Refactor statistics helper out of
PortMappingIsolatorTest for easier reuse.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32656/#review78357
-----------------------------------------------------------
Patch looks great!
Reviews applied: [32656]
All tests passed.
- Mesos ReviewBot
On March 31, 2015, 6:12 a.m., Paul Brett wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32656/
> -----------------------------------------------------------
>
> (Updated March 31, 2015, 6:12 a.m.)
>
>
> Review request for mesos, Chi Zhang, Ian Downes, and Cong Wang.
>
>
> Bugs: mesos-2332
> https://issues.apache.org/jira/browse/mesos-2332
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Refactor statistics helper out of PortMappingIsolatorTest for easier reuse.
>
>
> Diffs
> -----
>
> src/tests/port_mapping_tests.cpp f4124c3
>
> Diff: https://reviews.apache.org/r/32656/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Paul Brett
>
>
Re: Review Request 32656: Refactor statistics helper out of
PortMappingIsolatorTest for easier reuse.
Posted by Paul Brett <pa...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32656/
-----------------------------------------------------------
(Updated April 1, 2015, 10:33 p.m.)
Review request for mesos, Chi Zhang, Ian Downes, and Cong Wang.
Bugs: mesos-2332
https://issues.apache.org/jira/browse/mesos-2332
Repository: mesos
Description
-------
Refactor statistics helper out of PortMappingIsolatorTest for easier reuse.
Diffs (updated)
-----
src/slave/containerizer/isolators/network/port_mapping.hpp 33837b4662959a003c8f38d1e786c6615287a4ff
src/slave/containerizer/isolators/network/port_mapping.cpp e691d463515084518c94cdec3fbdf37be4a72977
src/tests/port_mapping_tests.cpp f4124c3e880e043729579a829e1057727741d131
Diff: https://reviews.apache.org/r/32656/diff/
Testing
-------
make check
Thanks,
Paul Brett
Re: Review Request 32656: Refactor statistics helper out of
PortMappingIsolatorTest for easier reuse.
Posted by Paul Brett <pa...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32656/
-----------------------------------------------------------
(Updated April 1, 2015, 3:44 p.m.)
Review request for mesos, Chi Zhang, Ian Downes, and Cong Wang.
Bugs: mesos-2332
https://issues.apache.org/jira/browse/mesos-2332
Repository: mesos
Description
-------
Refactor statistics helper out of PortMappingIsolatorTest for easier reuse.
Diffs
-----
src/tests/port_mapping_tests.cpp f4124c3e880e043729579a829e1057727741d131
Diff: https://reviews.apache.org/r/32656/diff/
Testing
-------
make check
Thanks,
Paul Brett
Re: Review Request 32656: Refactor statistics helper out of
PortMappingIsolatorTest for easier reuse.
Posted by Paul Brett <pa...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32656/
-----------------------------------------------------------
(Updated April 1, 2015, 12:41 a.m.)
Review request for mesos, Chi Zhang, Ian Downes, and Cong Wang.
Bugs: mesos-2332
https://issues.apache.org/jira/browse/mesos-2332
Repository: mesos
Description
-------
Refactor statistics helper out of PortMappingIsolatorTest for easier reuse.
Diffs (updated)
-----
src/tests/port_mapping_tests.cpp f4124c3e880e043729579a829e1057727741d131
Diff: https://reviews.apache.org/r/32656/diff/
Testing
-------
make check
Thanks,
Paul Brett
Re: Review Request 32656: Refactor statistics helper out of
PortMappingIsolatorTest for easier reuse.
Posted by Paul Brett <pa...@twopensource.com>.
> On March 31, 2015, 11:38 p.m., Chi Zhang wrote:
> > src/tests/port_mapping_tests.cpp, lines 188-192
> > <https://reviews.apache.org/r/32656/diff/1/?file=910499#file910499line188>
> >
> > having no output here isn't expected; why delay reporting it?
Having no output here is currently an expected behaviour. If mesos-network-helper is called with an invalid pid (for example, before a namespace has been created) then it generates no output and returns with an error status. I believe it would be better to always generate valid JSON output, with a clear error indication if an error occurs.
- Paul
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32656/#review78432
-----------------------------------------------------------
On April 1, 2015, 3:44 p.m., Paul Brett wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32656/
> -----------------------------------------------------------
>
> (Updated April 1, 2015, 3:44 p.m.)
>
>
> Review request for mesos, Chi Zhang, Ian Downes, and Cong Wang.
>
>
> Bugs: mesos-2332
> https://issues.apache.org/jira/browse/mesos-2332
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Refactor statistics helper out of PortMappingIsolatorTest for easier reuse.
>
>
> Diffs
> -----
>
> src/tests/port_mapping_tests.cpp f4124c3e880e043729579a829e1057727741d131
>
> Diff: https://reviews.apache.org/r/32656/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Paul Brett
>
>
Re: Review Request 32656: Refactor statistics helper out of
PortMappingIsolatorTest for easier reuse.
Posted by Chi Zhang <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32656/#review78432
-----------------------------------------------------------
src/tests/port_mapping_tests.cpp
<https://reviews.apache.org/r/32656/#comment127117>
how about also extract this out to be a 'helperPath', like what you did for launchHelper in the other patch?
src/tests/port_mapping_tests.cpp
<https://reviews.apache.org/r/32656/#comment127116>
having no output here isn't expected; why delay reporting it?
- Chi Zhang
On March 31, 2015, 6:12 a.m., Paul Brett wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32656/
> -----------------------------------------------------------
>
> (Updated March 31, 2015, 6:12 a.m.)
>
>
> Review request for mesos, Chi Zhang, Ian Downes, and Cong Wang.
>
>
> Bugs: mesos-2332
> https://issues.apache.org/jira/browse/mesos-2332
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Refactor statistics helper out of PortMappingIsolatorTest for easier reuse.
>
>
> Diffs
> -----
>
> src/tests/port_mapping_tests.cpp f4124c3
>
> Diff: https://reviews.apache.org/r/32656/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Paul Brett
>
>