[GitHub] [maven-surefire] papegaaij commented on pull request #389: [SUREFIRE-1935] Upgrade to JUnit Platform 1.8, start Launcher via LauncherSession

[GitBox <gi...@apache.org>]

papegaaij commented on pull request #389:
URL: https://github.com/apache/maven-surefire/pull/389#issuecomment-919258184


   > You should not take everything into one session. There are reruns which have to be isolated trom the main run. And I am convinced that the reruns also have to be isolated in each.
   
   I did think about this, but as the contract of LauncherSession is very unclear about this, I decided to put it all in one session. The documentation of LauncherSession states `The LauncherSession API is the main entry point for client code that wishes to repeatedly discover and execute tests using one or more test engines.` IMHO, running the same test multiple times also falls under 'repeatedly discover and execute tests'. I guess this really depends on the way it is actually used which one is correct.
   
   It will require some work to open a new session for each failure-iteration, but I can probably do that later this week.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org