[jira] [Comment Edited] (DIRKRB-203) ConfigTest failed on windows

["Lin Chen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DIRKRB-203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14386492#comment-14386492 ] 

Lin Chen edited comment on DIRKRB-203 at 3/30/15 10:02 AM:
-----------------------------------------------------------

Hi Yaning,
The work looks great. Some minor questions:
1. Maybe it is better to get test directory by:
{code}
File testDir = new File(System.getProperty("test.dir", "target"));
{code}
Just like what I do in JsonBackendTest. For in this way, the test files will be generated in /target directory, can be deleted by mvn clean.
2. In the codes you contributed, the test file will be deleted before testing whether it exists. Maybe it will be better to verify whether it exists first, before delete.


was (Author: hazelc):
Hi Yaning,
The work looks great. Some minor questions:
1. Maybe it is better to get test directory by:
{code}
File testDir = new File(System.getProperty("test.dir", "target"));
{code}
Just like what I do in JsonBackendTest. For in this way, the test files will be generated in /target directory, can be deleted by mvn clean.
2. In the codes you contributed, the test file will be deleted before testing whether it exists. Maybe it will be better to verify whether it exists first, before delete? 

> ConfigTest failed on windows 
> -----------------------------
>
>                 Key: DIRKRB-203
>                 URL: https://issues.apache.org/jira/browse/DIRKRB-203
>             Project: Directory Kerberos
>          Issue Type: Bug
>            Reporter: Xu Yaning
>         Attachments: DIRKRB-203-v1.patch
>
>
> testIniConfig(org.apache.kerby.config.IniConfigTest)  Time elapsed: 0.011 sec
> << ERROR!
> java.io.FileNotFoundException: C:\tmp\test-ini-config (The system cannot find t
> e path specified)
>         at java.io.FileOutputStream.open0(Native Method)
>         at java.io.FileOutputStream.open(FileOutputStream.java:270)
>         at java.io.FileOutputStream.<init>(FileOutputStream.java:213)
>         at java.io.FileOutputStream.<init>(FileOutputStream.java:162)
>         at java.io.FileWriter.<init>(FileWriter.java:90)
>         at org.apache.kerby.config.IniConfigTest.buildFile(IniConfigTest.java:4
> )
>         at org.apache.kerby.config.IniConfigTest.testIniConfig(IniConfigTest.ja
> a:61)
> Picked up _JAVA_OPTIONS: -Djava.net.preferIPv4Stack=true
> Results :
> Tests in error:
>   IniConfigTest.testIniConfig:61->buildFile:41 » FileNotFound C:\tmp\test-ini-c
> ...
> Tests run: 6, Failures: 0, Errors: 1, Skipped: 0
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Apache Kerby Project ............................... SUCCESS [ 18.150 s]
> [INFO] Kerby ASN1 Project ................................. SUCCESS [ 22.816 s]
> [INFO] Lib Projects ....................................... SUCCESS [  0.022 s]
> [INFO] Kerby Util ......................................... SUCCESS [  0.712 s]
> [INFO] Third Party Projects ............................... SUCCESS [  0.007 s]
> [INFO] not-yet-commons-ssl ................................ SUCCESS [  4.574 s]
> [INFO] Kerby Config ....................................... FAILURE [  2.720 s]
> [INFO] Kerby Event ........................................ SKIPPED



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)