You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Joshua Cohen <jc...@twopensource.com> on 2014/10/17 00:56:49 UTC

Review Request 26834: Add client cluster configuration docs.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26834/
-----------------------------------------------------------

Review request for Aurora, Maxim Khutornenko and Bill Farner.


Bugs: AURORA-846
    https://issues.apache.org/jira/browse/AURORA-846


Repository: aurora


Description
-------

Add client cluster configuration docs.


Diffs
-----

  docs/client-cluster-configuration.md PRE-CREATION 
  docs/client-commands.md f61fc661d77345950d71bd3606dbe3d1488e9e5a 

Diff: https://reviews.apache.org/r/26834/diff/


Testing
-------

Rendered here: https://github.com/jcohen/incubator-aurora/blob/jcohen/docs/clusters.json/docs/client-cluster-configuration.md


Thanks,

Joshua Cohen

Re: Review Request 26834: Add client cluster configuration docs.

Posted by Joshua Cohen <jc...@twopensource.com>.

> On Oct. 16, 2014, 11:35 p.m., Bill Farner wrote:
> > Please also link to this page from https://github.com/apache/incubator-aurora/blob/master/docs/developing-aurora-client.md
> 
> Bill Farner wrote:
>     Err...sorry, i thought that was called "deploying-aurora-client.md".  The link will _maybe_ go in the outcome of AURORA-834, so not your task.
> 
> Joshua Cohen wrote:
>     Well, I just added it, want me to kill it? ;)

(didn't see your follow up for some reason).


- Joshua


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26834/#review57049
-----------------------------------------------------------


On Oct. 16, 2014, 11:58 p.m., Joshua Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26834/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2014, 11:58 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-846
>     https://issues.apache.org/jira/browse/AURORA-846
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add client cluster configuration docs.
> 
> 
> Diffs
> -----
> 
>   docs/client-cluster-configuration.md PRE-CREATION 
>   docs/client-commands.md f61fc661d77345950d71bd3606dbe3d1488e9e5a 
>   docs/developing-aurora-client.md e1b2ccd7504f983169118a288721894184d67c97 
> 
> Diff: https://reviews.apache.org/r/26834/diff/
> 
> 
> Testing
> -------
> 
> Rendered here: https://github.com/jcohen/incubator-aurora/blob/jcohen/docs/clusters.json/docs/client-cluster-configuration.md
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>

Re: Review Request 26834: Add client cluster configuration docs.

Posted by Bill Farner <wf...@apache.org>.

> On Oct. 16, 2014, 11:35 p.m., Bill Farner wrote:
> > Please also link to this page from https://github.com/apache/incubator-aurora/blob/master/docs/developing-aurora-client.md

Err...sorry, i thought that was called "deploying-aurora-client.md".  The link will _maybe_ go in the outcome of AURORA-834, so not your task.


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26834/#review57049
-----------------------------------------------------------


On Oct. 16, 2014, 10:56 p.m., Joshua Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26834/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2014, 10:56 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-846
>     https://issues.apache.org/jira/browse/AURORA-846
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add client cluster configuration docs.
> 
> 
> Diffs
> -----
> 
>   docs/client-cluster-configuration.md PRE-CREATION 
>   docs/client-commands.md f61fc661d77345950d71bd3606dbe3d1488e9e5a 
> 
> Diff: https://reviews.apache.org/r/26834/diff/
> 
> 
> Testing
> -------
> 
> Rendered here: https://github.com/jcohen/incubator-aurora/blob/jcohen/docs/clusters.json/docs/client-cluster-configuration.md
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>

Re: Review Request 26834: Add client cluster configuration docs.

Posted by Joshua Cohen <jc...@twopensource.com>.

> On Oct. 16, 2014, 11:35 p.m., Bill Farner wrote:
> > Please also link to this page from https://github.com/apache/incubator-aurora/blob/master/docs/developing-aurora-client.md
> 
> Bill Farner wrote:
>     Err...sorry, i thought that was called "deploying-aurora-client.md".  The link will _maybe_ go in the outcome of AURORA-834, so not your task.

Well, I just added it, want me to kill it? ;)


- Joshua


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26834/#review57049
-----------------------------------------------------------


On Oct. 16, 2014, 11:58 p.m., Joshua Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26834/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2014, 11:58 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-846
>     https://issues.apache.org/jira/browse/AURORA-846
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add client cluster configuration docs.
> 
> 
> Diffs
> -----
> 
>   docs/client-cluster-configuration.md PRE-CREATION 
>   docs/client-commands.md f61fc661d77345950d71bd3606dbe3d1488e9e5a 
>   docs/developing-aurora-client.md e1b2ccd7504f983169118a288721894184d67c97 
> 
> Diff: https://reviews.apache.org/r/26834/diff/
> 
> 
> Testing
> -------
> 
> Rendered here: https://github.com/jcohen/incubator-aurora/blob/jcohen/docs/clusters.json/docs/client-cluster-configuration.md
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>

Re: Review Request 26834: Add client cluster configuration docs.

Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26834/#review57049
-----------------------------------------------------------


Please also link to this page from https://github.com/apache/incubator-aurora/blob/master/docs/developing-aurora-client.md

- Bill Farner


On Oct. 16, 2014, 10:56 p.m., Joshua Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26834/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2014, 10:56 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-846
>     https://issues.apache.org/jira/browse/AURORA-846
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add client cluster configuration docs.
> 
> 
> Diffs
> -----
> 
>   docs/client-cluster-configuration.md PRE-CREATION 
>   docs/client-commands.md f61fc661d77345950d71bd3606dbe3d1488e9e5a 
> 
> Diff: https://reviews.apache.org/r/26834/diff/
> 
> 
> Testing
> -------
> 
> Rendered here: https://github.com/jcohen/incubator-aurora/blob/jcohen/docs/clusters.json/docs/client-cluster-configuration.md
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>

Re: Review Request 26834: Add client cluster configuration docs.

Posted by Joshua Cohen <jc...@twopensource.com>.

> On Oct. 17, 2014, 12:06 a.m., Bill Farner wrote:
> > docs/client-cluster-configuration.md, line 14
> > <https://reviews.apache.org/r/26834/diff/2/?file=723846#file723846line14>
> >
> >     Mind filing a ticket to collapsing:
> >     
> >     zk
> >     zk_port
> >     scheduler_zk_path
> >     scheduler_uri
> >     
> >     into
> >     
> >     scheduler_address
> >     
> >     If you agree, of course.

Great idea, filed: https://issues.apache.org/jira/browse/AURORA-864


- Joshua


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26834/#review57064
-----------------------------------------------------------


On Oct. 17, 2014, 12:37 a.m., Joshua Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26834/
> -----------------------------------------------------------
> 
> (Updated Oct. 17, 2014, 12:37 a.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-846
>     https://issues.apache.org/jira/browse/AURORA-846
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add client cluster configuration docs.
> 
> 
> Diffs
> -----
> 
>   docs/client-cluster-configuration.md PRE-CREATION 
>   docs/client-commands.md f61fc661d77345950d71bd3606dbe3d1488e9e5a 
>   docs/developing-aurora-client.md e1b2ccd7504f983169118a288721894184d67c97 
> 
> Diff: https://reviews.apache.org/r/26834/diff/
> 
> 
> Testing
> -------
> 
> Rendered here: https://github.com/jcohen/incubator-aurora/blob/jcohen/docs/clusters.json/docs/client-cluster-configuration.md
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>

Re: Review Request 26834: Add client cluster configuration docs.

Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26834/#review57064
-----------------------------------------------------------

Ship it!



docs/client-cluster-configuration.md
<https://reviews.apache.org/r/26834/#comment97542>

    After the first sentence:
    
    Ultimately this allows client users to reference clusters with short names like `us-east` and `eu`.



docs/client-cluster-configuration.md
<https://reviews.apache.org/r/26834/#comment97548>

    Mind filing a ticket to collapsing:
    
    zk
    zk_port
    scheduler_zk_path
    scheduler_uri
    
    into
    
    scheduler_address
    
    If you agree, of course.


- Bill Farner


On Oct. 16, 2014, 11:58 p.m., Joshua Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26834/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2014, 11:58 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-846
>     https://issues.apache.org/jira/browse/AURORA-846
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add client cluster configuration docs.
> 
> 
> Diffs
> -----
> 
>   docs/client-cluster-configuration.md PRE-CREATION 
>   docs/client-commands.md f61fc661d77345950d71bd3606dbe3d1488e9e5a 
>   docs/developing-aurora-client.md e1b2ccd7504f983169118a288721894184d67c97 
> 
> Diff: https://reviews.apache.org/r/26834/diff/
> 
> 
> Testing
> -------
> 
> Rendered here: https://github.com/jcohen/incubator-aurora/blob/jcohen/docs/clusters.json/docs/client-cluster-configuration.md
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>

Re: Review Request 26834: Add client cluster configuration docs.

Posted by Joshua Cohen <jc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26834/
-----------------------------------------------------------

(Updated Oct. 17, 2014, 8:23 p.m.)


Review request for Aurora, Maxim Khutornenko and Bill Farner.


Changes
-------

Fix proxy url description.


Bugs: AURORA-846
    https://issues.apache.org/jira/browse/AURORA-846


Repository: aurora


Description
-------

Add client cluster configuration docs.


Diffs (updated)
-----

  docs/client-cluster-configuration.md PRE-CREATION 
  docs/client-commands.md f61fc661d77345950d71bd3606dbe3d1488e9e5a 
  docs/developing-aurora-client.md e1b2ccd7504f983169118a288721894184d67c97 

Diff: https://reviews.apache.org/r/26834/diff/


Testing
-------

Rendered here: https://github.com/jcohen/incubator-aurora/blob/jcohen/docs/clusters.json/docs/client-cluster-configuration.md


Thanks,

Joshua Cohen

Re: Review Request 26834: Add client cluster configuration docs.

Posted by Joshua Cohen <jc...@twopensource.com>.

> On Oct. 17, 2014, 3:02 p.m., Jay Buffington wrote:
> > docs/client-cluster-configuration.md, line 63
> > <https://reviews.apache.org/r/26834/diff/3/?file=723872#file723872line63>
> >
> >     I this true?  It was my understanding that the only use for this field is to format URLs that are  output by the client. 
> >     
> >     Instead of using the hostname of the leader it will use this hostname to prefix urls.
> >     
> >     Usually this would be the url of your VIP in a loadbalancer or a roundrobin DNS name.

Yep, thanks for reminding me. Updated the description.


- Joshua


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26834/#review57142
-----------------------------------------------------------


On Oct. 17, 2014, 8:23 p.m., Joshua Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26834/
> -----------------------------------------------------------
> 
> (Updated Oct. 17, 2014, 8:23 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-846
>     https://issues.apache.org/jira/browse/AURORA-846
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add client cluster configuration docs.
> 
> 
> Diffs
> -----
> 
>   docs/client-cluster-configuration.md PRE-CREATION 
>   docs/client-commands.md f61fc661d77345950d71bd3606dbe3d1488e9e5a 
>   docs/developing-aurora-client.md e1b2ccd7504f983169118a288721894184d67c97 
> 
> Diff: https://reviews.apache.org/r/26834/diff/
> 
> 
> Testing
> -------
> 
> Rendered here: https://github.com/jcohen/incubator-aurora/blob/jcohen/docs/clusters.json/docs/client-cluster-configuration.md
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>

Re: Review Request 26834: Add client cluster configuration docs.

Posted by Jay Buffington <me...@jaybuff.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26834/#review57142
-----------------------------------------------------------



docs/client-cluster-configuration.md
<https://reviews.apache.org/r/26834/#comment97605>

    I this true?  It was my understanding that the only use for this field is to format URLs that are  output by the client. 
    
    Instead of using the hostname of the leader it will use this hostname to prefix urls.
    
    Usually this would be the url of your VIP in a loadbalancer or a roundrobin DNS name.


- Jay Buffington


On Oct. 17, 2014, 12:37 a.m., Joshua Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26834/
> -----------------------------------------------------------
> 
> (Updated Oct. 17, 2014, 12:37 a.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-846
>     https://issues.apache.org/jira/browse/AURORA-846
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add client cluster configuration docs.
> 
> 
> Diffs
> -----
> 
>   docs/client-cluster-configuration.md PRE-CREATION 
>   docs/client-commands.md f61fc661d77345950d71bd3606dbe3d1488e9e5a 
>   docs/developing-aurora-client.md e1b2ccd7504f983169118a288721894184d67c97 
> 
> Diff: https://reviews.apache.org/r/26834/diff/
> 
> 
> Testing
> -------
> 
> Rendered here: https://github.com/jcohen/incubator-aurora/blob/jcohen/docs/clusters.json/docs/client-cluster-configuration.md
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>

Re: Review Request 26834: Add client cluster configuration docs.

Posted by Joshua Cohen <jc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26834/
-----------------------------------------------------------

(Updated Oct. 17, 2014, 12:37 a.m.)


Review request for Aurora, Maxim Khutornenko and Bill Farner.


Changes
-------

Review feedback:

- Update cluster config description
- Fix typo


Bugs: AURORA-846
    https://issues.apache.org/jira/browse/AURORA-846


Repository: aurora


Description
-------

Add client cluster configuration docs.


Diffs (updated)
-----

  docs/client-cluster-configuration.md PRE-CREATION 
  docs/client-commands.md f61fc661d77345950d71bd3606dbe3d1488e9e5a 
  docs/developing-aurora-client.md e1b2ccd7504f983169118a288721894184d67c97 

Diff: https://reviews.apache.org/r/26834/diff/


Testing
-------

Rendered here: https://github.com/jcohen/incubator-aurora/blob/jcohen/docs/clusters.json/docs/client-cluster-configuration.md


Thanks,

Joshua Cohen

Re: Review Request 26834: Add client cluster configuration docs.

Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26834/#review57072
-----------------------------------------------------------

Ship it!



docs/client-cluster-configuration.md
<https://reviews.apache.org/r/26834/#comment97556>

    typo in UNAUTHENTICTED


- Maxim Khutornenko


On Oct. 16, 2014, 11:58 p.m., Joshua Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26834/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2014, 11:58 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-846
>     https://issues.apache.org/jira/browse/AURORA-846
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add client cluster configuration docs.
> 
> 
> Diffs
> -----
> 
>   docs/client-cluster-configuration.md PRE-CREATION 
>   docs/client-commands.md f61fc661d77345950d71bd3606dbe3d1488e9e5a 
>   docs/developing-aurora-client.md e1b2ccd7504f983169118a288721894184d67c97 
> 
> Diff: https://reviews.apache.org/r/26834/diff/
> 
> 
> Testing
> -------
> 
> Rendered here: https://github.com/jcohen/incubator-aurora/blob/jcohen/docs/clusters.json/docs/client-cluster-configuration.md
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>

Re: Review Request 26834: Add client cluster configuration docs.

Posted by Joshua Cohen <jc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26834/
-----------------------------------------------------------

(Updated Oct. 16, 2014, 11:58 p.m.)


Review request for Aurora, Maxim Khutornenko and Bill Farner.


Changes
-------

Add a link to the cluster config docs from the developing client doc.


Bugs: AURORA-846
    https://issues.apache.org/jira/browse/AURORA-846


Repository: aurora


Description
-------

Add client cluster configuration docs.


Diffs (updated)
-----

  docs/client-cluster-configuration.md PRE-CREATION 
  docs/client-commands.md f61fc661d77345950d71bd3606dbe3d1488e9e5a 
  docs/developing-aurora-client.md e1b2ccd7504f983169118a288721894184d67c97 

Diff: https://reviews.apache.org/r/26834/diff/


Testing
-------

Rendered here: https://github.com/jcohen/incubator-aurora/blob/jcohen/docs/clusters.json/docs/client-cluster-configuration.md


Thanks,

Joshua Cohen

Re: Review Request 26834: Add client cluster configuration docs.

Posted by Joshua Cohen <jc...@twopensource.com>.

> On Oct. 16, 2014, 11:03 p.m., Joshua Cohen wrote:
> > docs/client-cluster-configuration.md, line 34
> > <https://reviews.apache.org/r/26834/diff/1/?file=723472#file723472line34>
> >
> >     I think an argument could be made for removing this configuration entirely and just hardcoding this into the client. I don't think there's a use case where we'd want these commands to talk to any run other than the latest run (correct me if I'm wrong), however having this here does protect us against having to redeploy the client in the event that mesos changes its path structure.
> 
> Kevin Sweeney wrote:
>     I'd be +1 to dropping this parameter entirely, either in this patch or a followup
> 
> Jay Buffington wrote:
>     At a bare minimum make latest the default and make this optional.

Filed https://issues.apache.org/jira/browse/AURORA-862 to address this in a follow up.


- Joshua


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26834/#review57030
-----------------------------------------------------------


On Oct. 16, 2014, 10:56 p.m., Joshua Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26834/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2014, 10:56 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-846
>     https://issues.apache.org/jira/browse/AURORA-846
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add client cluster configuration docs.
> 
> 
> Diffs
> -----
> 
>   docs/client-cluster-configuration.md PRE-CREATION 
>   docs/client-commands.md f61fc661d77345950d71bd3606dbe3d1488e9e5a 
> 
> Diff: https://reviews.apache.org/r/26834/diff/
> 
> 
> Testing
> -------
> 
> Rendered here: https://github.com/jcohen/incubator-aurora/blob/jcohen/docs/clusters.json/docs/client-cluster-configuration.md
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>

Re: Review Request 26834: Add client cluster configuration docs.

Posted by Kevin Sweeney <ke...@apache.org>.

> On Oct. 16, 2014, 4:03 p.m., Joshua Cohen wrote:
> > docs/client-cluster-configuration.md, line 34
> > <https://reviews.apache.org/r/26834/diff/1/?file=723472#file723472line34>
> >
> >     I think an argument could be made for removing this configuration entirely and just hardcoding this into the client. I don't think there's a use case where we'd want these commands to talk to any run other than the latest run (correct me if I'm wrong), however having this here does protect us against having to redeploy the client in the event that mesos changes its path structure.

I'd be +1 to dropping this parameter entirely, either in this patch or a followup


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26834/#review57030
-----------------------------------------------------------


On Oct. 16, 2014, 3:56 p.m., Joshua Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26834/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2014, 3:56 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-846
>     https://issues.apache.org/jira/browse/AURORA-846
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add client cluster configuration docs.
> 
> 
> Diffs
> -----
> 
>   docs/client-cluster-configuration.md PRE-CREATION 
>   docs/client-commands.md f61fc661d77345950d71bd3606dbe3d1488e9e5a 
> 
> Diff: https://reviews.apache.org/r/26834/diff/
> 
> 
> Testing
> -------
> 
> Rendered here: https://github.com/jcohen/incubator-aurora/blob/jcohen/docs/clusters.json/docs/client-cluster-configuration.md
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>

Re: Review Request 26834: Add client cluster configuration docs.

Posted by Jay Buffington <me...@jaybuff.com>.

> On Oct. 16, 2014, 11:03 p.m., Joshua Cohen wrote:
> > docs/client-cluster-configuration.md, line 34
> > <https://reviews.apache.org/r/26834/diff/1/?file=723472#file723472line34>
> >
> >     I think an argument could be made for removing this configuration entirely and just hardcoding this into the client. I don't think there's a use case where we'd want these commands to talk to any run other than the latest run (correct me if I'm wrong), however having this here does protect us against having to redeploy the client in the event that mesos changes its path structure.
> 
> Kevin Sweeney wrote:
>     I'd be +1 to dropping this parameter entirely, either in this patch or a followup

At a bare minimum make latest the default and make this optional.


- Jay


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26834/#review57030
-----------------------------------------------------------


On Oct. 16, 2014, 10:56 p.m., Joshua Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26834/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2014, 10:56 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-846
>     https://issues.apache.org/jira/browse/AURORA-846
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add client cluster configuration docs.
> 
> 
> Diffs
> -----
> 
>   docs/client-cluster-configuration.md PRE-CREATION 
>   docs/client-commands.md f61fc661d77345950d71bd3606dbe3d1488e9e5a 
> 
> Diff: https://reviews.apache.org/r/26834/diff/
> 
> 
> Testing
> -------
> 
> Rendered here: https://github.com/jcohen/incubator-aurora/blob/jcohen/docs/clusters.json/docs/client-cluster-configuration.md
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>

Re: Review Request 26834: Add client cluster configuration docs.

Posted by Joshua Cohen <jc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26834/#review57030
-----------------------------------------------------------



docs/client-cluster-configuration.md
<https://reviews.apache.org/r/26834/#comment97489>

    I think an argument could be made for removing this configuration entirely and just hardcoding this into the client. I don't think there's a use case where we'd want these commands to talk to any run other than the latest run (correct me if I'm wrong), however having this here does protect us against having to redeploy the client in the event that mesos changes its path structure.


- Joshua Cohen


On Oct. 16, 2014, 10:56 p.m., Joshua Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26834/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2014, 10:56 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-846
>     https://issues.apache.org/jira/browse/AURORA-846
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add client cluster configuration docs.
> 
> 
> Diffs
> -----
> 
>   docs/client-cluster-configuration.md PRE-CREATION 
>   docs/client-commands.md f61fc661d77345950d71bd3606dbe3d1488e9e5a 
> 
> Diff: https://reviews.apache.org/r/26834/diff/
> 
> 
> Testing
> -------
> 
> Rendered here: https://github.com/jcohen/incubator-aurora/blob/jcohen/docs/clusters.json/docs/client-cluster-configuration.md
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>