You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2022/06/15 19:38:38 UTC

[GitHub] [commons-configuration] garydgregory commented on a diff in pull request #188: CONFIGURATION-813: mailapi follow up

garydgregory commented on code in PR #188:
URL: https://github.com/apache/commons-configuration/pull/188#discussion_r898344084


##########
src/test/java/org/apache/commons/configuration2/TestDataConfiguration.java:
##########
@@ -358,7 +347,7 @@ public void setUp() throws Exception {
         // email address
         conf.addProperty("email.string", "ebourg@apache.org");
         conf.addProperty("email.string.interpolated", "${email.string}");
-        conf.addProperty("email.object", createInternetAddress("ebourg@apache.org"));
+        conf.addProperty("email.object", new InternetAddress("ebourg@apache.org"));

Review Comment:
   I don't think we want any PII here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org