You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Padma Priya N <pa...@gmail.com> on 2017/03/07 13:32:08 UTC
Review Request 57374: AMBARI-20342.WFM:Performance improvement for
adding node on a decision node in large workflow.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57374/
-----------------------------------------------------------
Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha.
Bugs: AMBARI-20342
https://issues.apache.org/jira/browse/AMBARI-20342
Repository: ambari
Description
-------
The issue was happening when the source node is a placeholder node. Fixed by extracting the original source node transitions instead of finding the the source of placeholder and processing the dag from start.
Diffs
-----
contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 01f8fe6
contrib/views/wfmanager/src/main/resources/ui/app/domain/cytoscape-flow-renderer.js f8796ae
contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less a424049
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs b5c3807
Diff: https://reviews.apache.org/r/57374/diff/1/
Testing
-------
Manual Testing
Thanks,
Padma Priya N
Re: Review Request 57374: AMBARI-20342.WFM:Performance improvement for
adding node on a decision node in large workflow.
Posted by belliraj hb <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57374/#review168125
-----------------------------------------------------------
Ship it!
Ship It!
- belliraj hb
On March 7, 2017, 1:32 p.m., Padma Priya N wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57374/
> -----------------------------------------------------------
>
> (Updated March 7, 2017, 1:32 p.m.)
>
>
> Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha.
>
>
> Bugs: AMBARI-20342
> https://issues.apache.org/jira/browse/AMBARI-20342
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The issue was happening when the source node is a placeholder node. Fixed by extracting the original source node transitions instead of finding the the source of placeholder and processing the dag from start.
>
>
> Diffs
> -----
>
> contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 01f8fe6
> contrib/views/wfmanager/src/main/resources/ui/app/domain/cytoscape-flow-renderer.js f8796ae
> contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less a424049
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs b5c3807
>
>
> Diff: https://reviews.apache.org/r/57374/diff/1/
>
>
> Testing
> -------
>
> Manual Testing
>
>
> Thanks,
>
> Padma Priya N
>
>
Re: Review Request 57374: AMBARI-20342.WFM:Performance improvement for
adding node on a decision node in large workflow.
Posted by Gaurav Nagar <gn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57374/#review168276
-----------------------------------------------------------
Ship it!
Ship It!
- Gaurav Nagar
On March 7, 2017, 1:32 p.m., Padma Priya N wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57374/
> -----------------------------------------------------------
>
> (Updated March 7, 2017, 1:32 p.m.)
>
>
> Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha.
>
>
> Bugs: AMBARI-20342
> https://issues.apache.org/jira/browse/AMBARI-20342
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The issue was happening when the source node is a placeholder node. Fixed by extracting the original source node transitions instead of finding the the source of placeholder and processing the dag from start.
>
>
> Diffs
> -----
>
> contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 01f8fe6
> contrib/views/wfmanager/src/main/resources/ui/app/domain/cytoscape-flow-renderer.js f8796ae
> contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less a424049
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs b5c3807
>
>
> Diff: https://reviews.apache.org/r/57374/diff/1/
>
>
> Testing
> -------
>
> Manual Testing
>
>
> Thanks,
>
> Padma Priya N
>
>