You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/01/25 19:21:35 UTC
[GitHub] [airflow] pingzh opened a new pull request #21107: Return slack api call response in slack_hook
pingzh opened a new pull request #21107:
URL: https://github.com/apache/airflow/pull/21107
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
There are some useful information returned from the slack api call, like `thread_ts` https://api.slack.com/methods/chat.postMessage#arg_thread_ts
so returning the response obj to the caller.
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #21107: Return slack api call response in slack_hook
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #21107:
URL: https://github.com/apache/airflow/pull/21107#discussion_r792126876
##########
File path: airflow/providers/slack/hooks/slack.py
##########
@@ -89,5 +90,12 @@ def call(self, api_method: str, **kwargs) -> None:
form-encoding will take place. Optional.
:param params: The URL parameters to append to the URL. Optional.
:param json: JSON for the body to attach to the request. Optional.
+
+ Returns:
Review comment:
Can you keep the comment style in line with the project convention?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #21107: Return slack api call response in slack_hook
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #21107:
URL: https://github.com/apache/airflow/pull/21107#issuecomment-1021568085
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a change in pull request #21107: Return slack api call response in slack_hook
Posted by GitBox <gi...@apache.org>.
uranusjr commented on a change in pull request #21107:
URL: https://github.com/apache/airflow/pull/21107#discussion_r792277941
##########
File path: airflow/providers/slack/hooks/slack.py
##########
@@ -89,5 +90,9 @@ def call(self, api_method: str, **kwargs) -> None:
form-encoding will take place. Optional.
:param params: The URL parameters to append to the URL. Optional.
:param json: JSON for the body to attach to the request. Optional.
+ :return: The server's response to an HTTP request. Data from the response can be
+ accessed like a dict. If the response included 'next_cursor' it can be
+ iterated on to execute subsequent requests.
+ :rtype: SlackResponse
Review comment:
```suggestion
```
Don’t need this since the return type is already visible in the function signature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #21107: Return slack api call response in slack_hook
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #21107:
URL: https://github.com/apache/airflow/pull/21107
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org