You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@quickstep.apache.org by zuyu <gi...@git.apache.org> on 2018/05/05 19:24:37 UTC

[GitHub] incubator-quickstep pull request #352: QUICKSTEP-125: Fixed the non-determin...

GitHub user zuyu opened a pull request:

    https://github.com/apache/incubator-quickstep/pull/352

    QUICKSTEP-125: Fixed the non-determinism in JoinReordering.

    This PR fixed the bug in join reordering due to the pointer address-based comparison. It also added a new rule that prefers the build side which does not produce output, and did minor refactors for the file.
    
    Assigned to @jianqiao.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zuyu/incubator-quickstep join-reordering-fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-quickstep/pull/352.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #352
    
----
commit 439c64afa195be3c067b6889917a64ce48ec27c3
Author: Zuyu Zhang <zu...@...>
Date:   2018-05-05T19:21:53Z

    QUICKSTEP-125: Fixed the non-determinism in JoinReordering due to pointer cmp.

----


---

[GitHub] incubator-quickstep issue #352: QUICKSTEP-125: Fixed the non-determinism in ...

Posted by jianqiao <gi...@git.apache.org>.

Github user jianqiao commented on the issue:

    https://github.com/apache/incubator-quickstep/pull/352
  
    LGTM! Merging.


---

[GitHub] incubator-quickstep pull request #352: QUICKSTEP-125: Fixed the non-determin...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-quickstep/pull/352


---