You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2010/03/30 20:35:29 UTC

[Bug 6396] New: Use of uninitialized value in lc at lib/Mail/SpamAssassin/Plugin/MIMEEval.pm

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6396

           Summary: Use of uninitialized value in lc at
                    lib/Mail/SpamAssassin/Plugin/MIMEEval.pm
           Product: Spamassassin
           Version: SVN Trunk (Latest Devel Version)
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P5
         Component: Libraries
        AssignedTo: dev@spamassassin.apache.org
        ReportedBy: toddr@cpanel.net


Created an attachment (id=4727)
 --> (https://issues.apache.org/SpamAssassin/attachment.cgi?id=4727)
fix to above bug

Running the test suite, I see:

Use of uninitialized value in lc at ../lib/Mail/SpamAssassin/Plugin/MIMEEval.pm

The attached patch should be a simple fix.

I would suggest maybe looking at Test::NoWarnings to autodetect these in the
future.

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6396] [test] Use of uninitialized value in lc at lib/Mail/SpamAssassin/Plugin/MIMEEval.pm

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6396

Mark Martinec <Ma...@ijs.si> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #4 from Mark Martinec <Ma...@ijs.si> 2011-05-11 12:46:50 UTC ---
Closing, the trivial fix is in 3.3 and in trunk.
A test is not happening...

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6396] Use of uninitialized value in lc at lib/Mail/SpamAssassin/Plugin/MIMEEval.pm

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6396

--- Comment #1 from Mark Martinec <Ma...@ijs.si> 2010-03-31 00:05:34 UTC ---
> Created an attachment (id=4727)
 --> (https://issues.apache.org/SpamAssassin/attachment.cgi?id=4727) fix to
above bug
> Running the test suite, I see:
>   Use of uninitialized value in lc
>   at ../lib/Mail/SpamAssassin/Plugin/MIMEEval.pm
> The attached patch should be a simple fix.

Thanks, I see them too now that I switched to perl 5.12.0. Ugly.

trunk:
Sending lib/Mail/SpamAssassin/Plugin/MIMEEval.pm
Committed revision 929342.

3.3 (declaring it a trivial fix):
Sending lib/Mail/SpamAssassin/Plugin/MIMEEval.pm
Committed revision 929343.


> I would suggest maybe looking at Test::NoWarnings to autodetect these
> in the future.

Thoughts?

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6396] Use of uninitialized value in lc at lib/Mail/SpamAssassin/Plugin/MIMEEval.pm

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6396

Justin Mason <jm...@jmason.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jm@jmason.org

--- Comment #2 from Justin Mason <jm...@jmason.org> 2010-03-31 09:25:50 UTC ---
(In reply to comment #1)
> > I would suggest maybe looking at Test::NoWarnings to autodetect these
> > in the future.
> 
> Thoughts?

+1.  it'd be a good "xt" test.

talking of which I need to figure out how to run those on hudson.

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6396] Use of uninitialized value in lc at lib/Mail/SpamAssassin/Plugin/MIMEEval.pm

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6396

Mark Martinec <Ma...@ijs.si> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|Undefined                   |3.3.2

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6396] [test] Use of uninitialized value in lc at lib/Mail/SpamAssassin/Plugin/MIMEEval.pm

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6396

Mark Martinec <Ma...@ijs.si> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Use of uninitialized value  |[test] Use of uninitialized
                   |in lc at                    |value in lc at
                   |lib/Mail/SpamAssassin/Plugi |lib/Mail/SpamAssassin/Plugi
                   |n/MIMEEval.pm               |n/MIMEEval.pm

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6396] [test] Use of uninitialized value in lc at lib/Mail/SpamAssassin/Plugin/MIMEEval.pm

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6396

Todd Rinaldo <to...@cpanel.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |toddr@cpanel.net

--- Comment #3 from Todd Rinaldo <to...@cpanel.net> 2010-03-31 15:34:12 UTC ---
(In reply to comment #2)
> (In reply to comment #1)
> > > I would suggest maybe looking at Test::NoWarnings to autodetect these
> > > in the future.
> > 
> > Thoughts?
> 
> +1.  it'd be a good "xt" test.
> 
> talking of which I need to figure out how to run those on hudson.

I agree it kinda fits in the xt category, but to be useful, it has to monitor
your existing test suite. otherwise it would have never caught this one that
I'm reporting.

To be useful, I think you'd have to add it to every test file and bump the test
count by one.

Of course it would have to be added as a build_requires item too.

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.