You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by prabhjyotsingh <gi...@git.apache.org> on 2015/12/15 12:18:49 UTC
[GitHub] incubator-zeppelin pull request: fixing z-index for all modals, ba...
GitHub user prabhjyotsingh opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/535
fixing z-index for all modals, backdrop and popups
### What is this PR for?
This fixes z-index for all modals, backdrop.
### What type of PR is it?
Bug Fix
### Screenshots
Before:
<img width="1440" alt="screen shot 2015-12-15 at 4 46 55 pm" src="https://cloud.githubusercontent.com/assets/674497/11809252/90555846-a34b-11e5-9bcd-76e684379359.png">
<img width="1440" alt="screen shot 2015-12-15 at 4 47 30 pm" src="https://cloud.githubusercontent.com/assets/674497/11809253/90598678-a34b-11e5-9bc8-2da6d175134b.png">
After:
<img width="1440" alt="screen shot 2015-12-15 at 4 47 05 pm" src="https://cloud.githubusercontent.com/assets/674497/11809254/90599230-a34b-11e5-83f6-810f2e246f69.png">
<img width="1440" alt="screen shot 2015-12-15 at 4 47 17 pm" src="https://cloud.githubusercontent.com/assets/674497/11809255/905bc28a-a34b-11e5-9d5f-138efe3be08f.png">
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/prabhjyotsingh/incubator-zeppelin fixingZIndex
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/535.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #535
----
commit f0a97923a9d85c45ca97644cf0e3f6330940fe0d
Author: Prabhjyot Singh <pr...@gmail.com>
Date: 2015-12-15T11:14:26Z
fixing z-index for all modals, backdrop and popups
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: fixing z-index for all modals, ba...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/535#issuecomment-164920028
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: fixing z-index for all modals, ba...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/535
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: fixing z-index for all modals, ba...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/535#issuecomment-164996188
Thanks a lot for the quick review and merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: fixing z-index for all modals, ba...
Posted by r-kamath <gi...@git.apache.org>.
Github user r-kamath commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/535#issuecomment-164823355
:+1: LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: fixing z-index for all modals, ba...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/535#issuecomment-164963291
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---