You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shardingsphere.apache.org by Sanmu Wang <sa...@gmail.com> on 2019/12/25 02:58:09 UTC
opentracing dependency upgrade to 0.31.0
Hi,
I'm trying to adapt sharding sphere to my company inner APM service( lowest
opentracing version supported is 0.31.0 ), however opentracing dependency
is 0.30.0 and I didn't found any spi implementation for
sharding-opentracing module(checked this issue
https://github.com/apache/incubator-shardingsphere/issues/2478).
*Is there any plan to upgrade opentracing dependency to 0.31.0 officially?*
(Perhaps I can supply PR on this).
Thank you!
Re: opentracing dependency upgrade to 0.31.0
Posted by Zhang Yonglun <zh...@apache.org>.
I agree with you.
--
Zhang Yonglun
Apache ShardingSphere
Sheng Wu <wu...@gmail.com> 于2019年12月25日周三 下午3:32写道：
> Hi
>
> Feedback on behalf of SkyWalking PMC and ShardingSphere PPMC.
>
> OpenTracing is not widely used today. And 0.31 breaks many APIs in 0.30,
> and causes a lot of confusion.
> SkyWalking community has no one following this update and no user feedback
> about this.
>
> An update, OpenTracing and OpenCensus projects are merging into
> OpenTelemetry. A lot of APIs are there... Not sure what are the purposes
> even I am in the core team of OpenTracing.
>
> Anyway, SkyWalking and other APMs could provide auto instrumentation very
> easily for ShardingSphere. There is no point to add workload to upgrade to
> 0.31 and break the ecosystem.
>
> Sheng Wu 吴晟
> Twitter, wusheng1108
>
>
> Zhang Yonglun <zh...@apache.org> 于2019年12月25日周三 上午11:42写道：
>
> > Hi sanmu,
> >
> > 1. ShardingSphere now keeps consistent with SkyWalking use the ot 0.30.0.
> > 2. Yes, there's no spi now. But I thinks #2478 will not influence you
> when
> > using 0.31.0.
> > 3. Welcome you to submit a PR. It will be perfect if you finish the test
> > ahead.
> >
> > Sanmu Wang <sa...@gmail.com> 于2019年12月25日周三 上午10:58写道：
> >
> > > Hi,
> > >
> > > I'm trying to adapt sharding sphere to my company inner APM service(
> > lowest
> > > opentracing version supported is 0.31.0 ), however opentracing
> dependency
> > > is 0.30.0 and I didn't found any spi implementation for
> > > sharding-opentracing module(checked this issue
> > > https://github.com/apache/incubator-shardingsphere/issues/2478).
> > > *Is there any plan to upgrade opentracing dependency to 0.31.0
> > officially?*
> > > (Perhaps I can supply PR on this).
> > >
> > > Thank you!
> > >
> >
> >
> > --
> >
> >
> > Zhang Yonglun
> > Apache ShardingSphere
> >
>
Re: opentracing dependency upgrade to 0.31.0
Posted by Sheng Wu <wu...@gmail.com>.
Hi
Feedback on behalf of SkyWalking PMC and ShardingSphere PPMC.
OpenTracing is not widely used today. And 0.31 breaks many APIs in 0.30,
and causes a lot of confusion.
SkyWalking community has no one following this update and no user feedback
about this.
An update, OpenTracing and OpenCensus projects are merging into
OpenTelemetry. A lot of APIs are there... Not sure what are the purposes
even I am in the core team of OpenTracing.
Anyway, SkyWalking and other APMs could provide auto instrumentation very
easily for ShardingSphere. There is no point to add workload to upgrade to
0.31 and break the ecosystem.
Sheng Wu 吴晟
Twitter, wusheng1108
Zhang Yonglun <zh...@apache.org> 于2019年12月25日周三 上午11:42写道：
> Hi sanmu,
>
> 1. ShardingSphere now keeps consistent with SkyWalking use the ot 0.30.0.
> 2. Yes, there's no spi now. But I thinks #2478 will not influence you when
> using 0.31.0.
> 3. Welcome you to submit a PR. It will be perfect if you finish the test
> ahead.
>
> Sanmu Wang <sa...@gmail.com> 于2019年12月25日周三 上午10:58写道：
>
> > Hi,
> >
> > I'm trying to adapt sharding sphere to my company inner APM service(
> lowest
> > opentracing version supported is 0.31.0 ), however opentracing dependency
> > is 0.30.0 and I didn't found any spi implementation for
> > sharding-opentracing module(checked this issue
> > https://github.com/apache/incubator-shardingsphere/issues/2478).
> > *Is there any plan to upgrade opentracing dependency to 0.31.0
> officially?*
> > (Perhaps I can supply PR on this).
> >
> > Thank you!
> >
>
>
> --
>
>
> Zhang Yonglun
> Apache ShardingSphere
>
Re: opentracing dependency upgrade to 0.31.0
Posted by Zhang Yonglun <zh...@apache.org>.
Hi sanmu,
1. ShardingSphere now keeps consistent with SkyWalking use the ot 0.30.0.
2. Yes, there's no spi now. But I thinks #2478 will not influence you when
using 0.31.0.
3. Welcome you to submit a PR. It will be perfect if you finish the test
ahead.
Sanmu Wang <sa...@gmail.com> 于2019年12月25日周三 上午10:58写道：
> Hi,
>
> I'm trying to adapt sharding sphere to my company inner APM service( lowest
> opentracing version supported is 0.31.0 ), however opentracing dependency
> is 0.30.0 and I didn't found any spi implementation for
> sharding-opentracing module(checked this issue
> https://github.com/apache/incubator-shardingsphere/issues/2478).
> *Is there any plan to upgrade opentracing dependency to 0.31.0 officially?*
> (Perhaps I can supply PR on this).
>
> Thank you!
>
--
Zhang Yonglun
Apache ShardingSphere