You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by Leemoonsoo <gi...@git.apache.org> on 2016/06/11 00:21:11 UTC
[GitHub] zeppelin pull request #996: [ZEPPELIN-890]
GitHub user Leemoonsoo opened a pull request:
https://github.com/apache/zeppelin/pull/996
[ZEPPELIN-890]
### What is this PR for?
Cache downloaded file from 'maven-download-plugin' to improve CI build speed and reduce build failure due to network issue.
### What type of PR is it?
Improvement
### Todos
* [x] - Cache '.m2/repository/.cache/maven-download-plugin' directory
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-890
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Leemoonsoo/zeppelin download_fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/996.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #996
----
commit 35aff65651de9ee5c7da55bb4d1dc92367822c60
Author: Lee moon soo <mo...@apache.org>
Date: 2016-06-11T00:17:07Z
Cache ${HOME}/.m2/repository/.cache/maven-download-plugin to reduce download attempt
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #996: [ZEPPELIN-890] Cache downloaded file from 'maven-downlo...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/996
One more suggestion not sure if that is relevant to this PR should we have `<retries>5</retries>` near https://github.com/apache/zeppelin/blob/master/spark-dependencies/pom.xml#L827 and
https://github.com/apache/zeppelin/blob/master/spark-dependencies/pom.xml#L907 ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #996: [ZEPPELIN-890] Cache downloaded file from 'maven-downlo...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/996
@prabhjyotsingh Thanks for suggestion. Once travis caches '.m2/repository/.cache/maven-download-plugin' directory, 'maven-download-plugin' will not even try to download files from internet. So i think i'll be okay without increasing retry count.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #996: [ZEPPELIN-890] Cache downloaded file from 'maven-downlo...
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/996
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #996: [ZEPPELIN-890] Cache downloaded file from 'maven-downlo...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/996
Sure, I think we can merge this as a hotfix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #996: [ZEPPELIN-890] Cache downloaded file from 'maven-downlo...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/996
Merge if there're no further discussions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #996: [ZEPPELIN-890] Cache downloaded file from 'maven...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/996
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #996: [ZEPPELIN-890] Cache downloaded file from 'maven-downlo...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/996
Thank you for the explanation, I understand it now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---