Re: [PR] chore(deps): bump selenium 4.10.0+ [superset]

["gnought (via GitHub)" <gi...@apache.org>]

gnought commented on code in PR #25933:
URL: https://github.com/apache/superset/pull/25933#discussion_r1390446319


##########
superset/config.py:
##########
@@ -1360,7 +1360,7 @@ def EMAIL_HEADER_MUTATOR(  # pylint: disable=invalid-name,unused-argument
 WEBDRIVER_AUTH_FUNC = None
 
 # Any config options to be passed as-is to the webdriver
-WEBDRIVER_CONFIGURATION: dict[Any, Any] = {"service_log_path": "/dev/null"}
+WEBDRIVER_CONFIGURATION: dict[Any, Any] = {}

Review Comment:
   @john-bodley 
   
   In 4.9.0, `service_log_path` is one of parameters in `WebDriver` constructor.
   https://github.com/SeleniumHQ/selenium/blob/bc7e0c7341fdde78cdd80ce572002a7866fd1769/py/selenium/webdriver/firefox/webdriver.py#L90-L110
   
   However it is no longer in 4.10.0+.
   https://github.com/SeleniumHQ/selenium/blob/c14d9678990942b93cb421c5567d0da7fb29c7bd/py/selenium/webdriver/firefox/webdriver.py#L50-L53
   
   The following commit will support 4.10.0. It also opens for users to refine Webdrver `Options` and `Service`.
   For sure, this will be a breaking change if users defining `WEBDRIVER_CONFIGURATION` themselves using 4.9.0 WebDriver defintion.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org