You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "panbingkun (via GitHub)" <gi...@apache.org> on 2023/05/30 23:34:39 UTC
[GitHub] [spark] panbingkun opened a new pull request, #41394: [SPARK-43890][CONNECT][BUILD] Upgrade buf to v1.20.0
panbingkun opened a new pull request, #41394:
URL: https://github.com/apache/spark/pull/41394
### What changes were proposed in this pull request?
The pr aims to upgrade buf from 1.19.0 to 1.20.0
### Why are the changes needed?
1.Release Notes: https://github.com/bufbuild/buf/releases, improvment as follow:
- Add --emit-defaults flag to buf curl to emit default values in JSON-encoded responses.
- Indent JSON-encoded responses from buf curl by default.
- Log a warning in case an import statement does not point to a file in the module, a file in a direct dependency, or a well-known type file.
2.https://github.com/bufbuild/buf/compare/v1.19.0...v1.20.0
3.Manually test: dev/connect-gen-protos.sh, this upgrade will not change the generated files.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
- Manually test
- Pass GA
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng closed pull request #41394: [SPARK-43890][CONNECT][BUILD] Upgrade buf to v1.20.0
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng closed pull request #41394: [SPARK-43890][CONNECT][BUILD] Upgrade buf to v1.20.0
URL: https://github.com/apache/spark/pull/41394
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #41394: [SPARK-43890][CONNECT][BUILD] Upgrade buf to v1.20.0
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #41394:
URL: https://github.com/apache/spark/pull/41394#issuecomment-1569448922
thanks, merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org