You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Chengwei Yang <ch...@gmail.com> on 2014/03/14 08:34:07 UTC

Review Request 19217: Remove duplicate document link in home.md

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19217/
-----------------------------------------------------------

Review request for mesos.


Bugs: MESOS-1098
    https://issues.apache.org/jira/browse/MESOS-1098


Repository: mesos-git


Description
-------

Remove duplicate document link in home.md

"Mesos Command-Line Flags" is duplicated with "Mesos Configuration", so
remove it.


Diffs
-----

  docs/home.md 07c72c1f4b3bc7f27a091a09b296d2808ab5e2c1 

Diff: https://reviews.apache.org/r/19217/diff/


Testing
-------


Thanks,

Chengwei Yang

Re: Review Request 19217: Remove duplicate document links in home.md

Posted by Chengwei Yang <ch...@gmail.com>.

> On March 15, 2014, 12:35 a.m., Jiang Yan Xu wrote:
> > The links actually meant to point to different sections in the same document so I don't think they are duplicates.

But the fact is they do link to the same file, identically. I didn't find they point to different section.


- Chengwei


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19217/#review37214
-----------------------------------------------------------


On March 14, 2014, 4:38 p.m., Chengwei Yang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19217/
> -----------------------------------------------------------
> 
> (Updated March 14, 2014, 4:38 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-1098
>     https://issues.apache.org/jira/browse/MESOS-1098
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Remove duplicate document links in home.md
> 
> "Mesos Command-Line Flags" and "Mesos Configuration" both link to
> configuration.md
> 
> "Developer Tools" and "Tools" both link to tools.md
> 
> So let's remove the duplicated ones.
> 
> Review: https://reviews.apache.org/r/19217
> 
> 
> Diffs
> -----
> 
>   docs/home.md 07c72c1f4b3bc7f27a091a09b296d2808ab5e2c1 
> 
> Diff: https://reviews.apache.org/r/19217/diff/
> 
> 
> Testing
> -------
> 
> done
> 
> 
> Thanks,
> 
> Chengwei Yang
> 
>

Re: Review Request 19217: Remove duplicate document links in home.md

Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19217/#review37214
-----------------------------------------------------------


The links actually meant to point to different sections in the same document so I don't think they are duplicates.

- Jiang Yan Xu


On March 14, 2014, 1:38 a.m., Chengwei Yang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19217/
> -----------------------------------------------------------
> 
> (Updated March 14, 2014, 1:38 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-1098
>     https://issues.apache.org/jira/browse/MESOS-1098
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Remove duplicate document links in home.md
> 
> "Mesos Command-Line Flags" and "Mesos Configuration" both link to
> configuration.md
> 
> "Developer Tools" and "Tools" both link to tools.md
> 
> So let's remove the duplicated ones.
> 
> Review: https://reviews.apache.org/r/19217
> 
> 
> Diffs
> -----
> 
>   docs/home.md 07c72c1f4b3bc7f27a091a09b296d2808ab5e2c1 
> 
> Diff: https://reviews.apache.org/r/19217/diff/
> 
> 
> Testing
> -------
> 
> done
> 
> 
> Thanks,
> 
> Chengwei Yang
> 
>

Re: Review Request 19217: Remove duplicate document links in home.md

Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19217/#review37359
-----------------------------------------------------------


Patch looks great!

Reviews applied: [19217]

All tests passed.

- Mesos ReviewBot


On March 14, 2014, 8:38 a.m., Chengwei Yang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19217/
> -----------------------------------------------------------
> 
> (Updated March 14, 2014, 8:38 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-1098
>     https://issues.apache.org/jira/browse/MESOS-1098
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Remove duplicate document links in home.md
> 
> "Mesos Command-Line Flags" and "Mesos Configuration" both link to
> configuration.md
> 
> "Developer Tools" and "Tools" both link to tools.md
> 
> So let's remove the duplicated ones.
> 
> Review: https://reviews.apache.org/r/19217
> 
> 
> Diffs
> -----
> 
>   docs/home.md 07c72c1f4b3bc7f27a091a09b296d2808ab5e2c1 
> 
> Diff: https://reviews.apache.org/r/19217/diff/
> 
> 
> Testing
> -------
> 
> done
> 
> 
> Thanks,
> 
> Chengwei Yang
> 
>

Re: Review Request 19217: Remove duplicate document links in home.md

Posted by Chengwei Yang <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19217/
-----------------------------------------------------------

(Updated March 14, 2014, 4:38 p.m.)


Review request for mesos.


Changes
-------

comply with coding style. first_through --> firstThrough.


Bugs: MESOS-1098
    https://issues.apache.org/jira/browse/MESOS-1098


Repository: mesos-git


Description
-------

Remove duplicate document links in home.md

"Mesos Command-Line Flags" and "Mesos Configuration" both link to
configuration.md

"Developer Tools" and "Tools" both link to tools.md

So let's remove the duplicated ones.

Review: https://reviews.apache.org/r/19217


Diffs
-----

  docs/home.md 07c72c1f4b3bc7f27a091a09b296d2808ab5e2c1 

Diff: https://reviews.apache.org/r/19217/diff/


Testing (updated)
-------

done


Thanks,

Chengwei Yang

Re: Review Request 19217: Remove duplicate document links in home.md

Posted by Chengwei Yang <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19217/
-----------------------------------------------------------

(Updated March 14, 2014, 4:22 p.m.)


Review request for mesos.


Summary (updated)
-----------------

Remove duplicate document links in home.md


Bugs: MESOS-1098
    https://issues.apache.org/jira/browse/MESOS-1098


Repository: mesos-git


Description (updated)
-------

Remove duplicate document links in home.md

"Mesos Command-Line Flags" and "Mesos Configuration" both link to
configuration.md

"Developer Tools" and "Tools" both link to tools.md

So let's remove the duplicated ones.

Review: https://reviews.apache.org/r/19217


Diffs (updated)
-----

  docs/home.md 07c72c1f4b3bc7f27a091a09b296d2808ab5e2c1 

Diff: https://reviews.apache.org/r/19217/diff/


Testing
-------


Thanks,

Chengwei Yang