You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2017/04/25 15:13:10 UTC
Review Request 58708: Checked validity of master and agent version
numbers on startup.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58708/
-----------------------------------------------------------
Review request for mesos, Benjamin Mahler and Kapil Arya.
Bugs: MESOS-6976
https://issues.apache.org/jira/browse/MESOS-6976
Repository: mesos
Description
-------
During startup, we now check that the compiled version number of the
master and agent can be parsed by Stout's `Version::parse` (i.e., that
`MESOS_VERSION` uses the Semver 2.0.0 format).
Diffs
-----
src/master/main.cpp 462ed3229d15b157a92d96860503c06368ab21b7
src/slave/main.cpp 72b141cb66f9df5bcc7b3f8cfcc2b06fcbd17e52
Diff: https://reviews.apache.org/r/58708/diff/1/
Testing
-------
`make check`
Thanks,
Neil Conway
Re: Review Request 58708: Checked validity of master and agent version
numbers on startup.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58708/#review172998
-----------------------------------------------------------
Fix it, then Ship it!
Looks good, just seems to be in an inconsistent location across the master and agent files?
src/master/main.cpp
Lines 252-260 (patched)
<https://reviews.apache.org/r/58708/#comment246060>
It seems like this is in a different spot across the agent and master code, seems to me like we should do this before flag loading and build info logging in both cases.
Since this will be an error regardless of getting the flags right.
- Benjamin Mahler
On April 26, 2017, 5:35 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58708/
> -----------------------------------------------------------
>
> (Updated April 26, 2017, 5:35 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Kapil Arya.
>
>
> Bugs: MESOS-6976
> https://issues.apache.org/jira/browse/MESOS-6976
>
>
> Repository: mesos
>
>
> Description
> -------
>
> During startup, we now check that the compiled-in version number of the
> master and agent can be parsed by stout's `Version::parse` (i.e., that
> `MESOS_VERSION` is valid according to stout's extended variant of the
> Semver 2.0.0 format).
>
>
> Diffs
> -----
>
> src/master/main.cpp 462ed3229d15b157a92d96860503c06368ab21b7
> src/slave/main.cpp 72b141cb66f9df5bcc7b3f8cfcc2b06fcbd17e52
>
>
> Diff: https://reviews.apache.org/r/58708/diff/2/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 58708: Checked validity of master and agent version
numbers on startup.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58708/#review172996
-----------------------------------------------------------
src/master/main.cpp
Lines 257-258 (patched)
<https://reviews.apache.org/r/58708/#comment246218>
Also, we try to get the open and close quotes on the same line when possible, to make it clearer to the reader when we forget to close a quote. Ditto for the other log in the agent.
- Benjamin Mahler
On April 26, 2017, 5:35 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58708/
> -----------------------------------------------------------
>
> (Updated April 26, 2017, 5:35 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Kapil Arya.
>
>
> Bugs: MESOS-6976
> https://issues.apache.org/jira/browse/MESOS-6976
>
>
> Repository: mesos
>
>
> Description
> -------
>
> During startup, we now check that the compiled-in version number of the
> master and agent can be parsed by stout's `Version::parse` (i.e., that
> `MESOS_VERSION` is valid according to stout's extended variant of the
> Semver 2.0.0 format).
>
>
> Diffs
> -----
>
> src/master/main.cpp 462ed3229d15b157a92d96860503c06368ab21b7
> src/slave/main.cpp 72b141cb66f9df5bcc7b3f8cfcc2b06fcbd17e52
>
>
> Diff: https://reviews.apache.org/r/58708/diff/2/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 58708: Checked validity of master and agent version
numbers on startup.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58708/
-----------------------------------------------------------
(Updated May 2, 2017, 5:41 p.m.)
Review request for mesos, Benjamin Mahler and Kapil Arya.
Changes
-------
Address review comments.
Bugs: MESOS-6976
https://issues.apache.org/jira/browse/MESOS-6976
Repository: mesos
Description
-------
During startup, we now check that the compiled-in version number of the
master and agent can be parsed by stout's `Version::parse` (i.e., that
`MESOS_VERSION` is valid according to stout's extended variant of the
Semver 2.0.0 format).
Diffs (updated)
-----
src/master/main.cpp 462ed3229d15b157a92d96860503c06368ab21b7
src/slave/main.cpp 72b141cb66f9df5bcc7b3f8cfcc2b06fcbd17e52
Diff: https://reviews.apache.org/r/58708/diff/3/
Changes: https://reviews.apache.org/r/58708/diff/2-3/
Testing
-------
`make check`
Thanks,
Neil Conway
Re: Review Request 58708: Checked validity of master and agent version
numbers on startup.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58708/
-----------------------------------------------------------
(Updated April 26, 2017, 5:35 p.m.)
Review request for mesos, Benjamin Mahler and Kapil Arya.
Changes
-------
Tweak commit description.
Bugs: MESOS-6976
https://issues.apache.org/jira/browse/MESOS-6976
Repository: mesos
Description (updated)
-------
During startup, we now check that the compiled-in version number of the
master and agent can be parsed by stout's `Version::parse` (i.e., that
`MESOS_VERSION` is valid according to stout's extended variant of the
Semver 2.0.0 format).
Diffs (updated)
-----
src/master/main.cpp 462ed3229d15b157a92d96860503c06368ab21b7
src/slave/main.cpp 72b141cb66f9df5bcc7b3f8cfcc2b06fcbd17e52
Diff: https://reviews.apache.org/r/58708/diff/2/
Changes: https://reviews.apache.org/r/58708/diff/1-2/
Testing
-------
`make check`
Thanks,
Neil Conway