You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by Haydend <gi...@git.apache.org> on 2017/11/02 11:04:39 UTC
[GitHub] activemq-artemis pull request #1633: Modified artemis.cmd to be able to hand...
GitHub user Haydend opened a pull request:
https://github.com/apache/activemq-artemis/pull/1633
Modified artemis.cmd to be able to handle an ARTEMIS_HOME containing spaces
For example : 'C:\Program Files\Apache\Artemis\apache-artemis-2.3.0'.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Haydend/activemq-artemis SPACE_FIX
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1633.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1633
----
commit a1ad6016e721c7bffe726404ee9add0a0b0ca4d0
Author: Hayden Dunnicliffe <ha...@radiuspaymentsolutions.com>
Date: 2017-11-02T10:35:13Z
Modified artemis.cmd to be able to handle an ARTEMIS_HOME containing spaces. For example : 'C:\Program Files\Apache\Artemis\apache-artemis-2.3.0'.
----
---
[GitHub] activemq-artemis pull request #1633: Modified artemis.cmd to be able to hand...
Posted by Haydend <gi...@git.apache.org>.
Github user Haydend closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1633
---
[GitHub] activemq-artemis issue #1633: Modified artemis.cmd to be able to handle an A...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1633
Can you close this PR please?
---
[GitHub] activemq-artemis issue #1633: Modified artemis.cmd to be able to handle an A...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1633
I'm handling this...
---
[GitHub] activemq-artemis pull request #1633: Modified artemis.cmd to be able to hand...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1633#discussion_r148565519
--- Diff: artemis-distribution/src/main/resources/bin/artemis.cmd ---
@@ -25,7 +25,7 @@ set ARTEMIS_HOME="%CD%"
POPD
:CHECK_ARTEMIS_HOME
-if exist %ARTEMIS_HOME%\bin\artemis.cmd goto CHECK_JAVA
+if exist "%ARTEMIS_HOME%\bin\artemis.cmd" goto CHECK_JAVA
--- End diff --
when you create a server in windows... the profile will contain
set ARTEMIS_HOME="C:\Program Files\apache-artemis-2.5.0-SNAPSHOT"
I tried your patch and it didn't work.. for that reason I cannot merge it..
There are no issues as I see with the current thing.
---