You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/04/22 09:51:41 UTC
[GitHub] [flink] azagrebin opened a new pull request #11863: [FLINK-17048][mesos] Add memory related JVM args to Mesos JM startup scripts
azagrebin opened a new pull request #11863:
URL: https://github.com/apache/flink/pull/11863
## What is the purpose of the change
It looks like we never respected memory configuration in Mesos JM startup scripts:
- `mesos-appmaster.sh`
- `mesos-appmaster-job.sh`
This adopts FLIP-116 here as well, similar to what we are doing with standalone scripts in #11545.
## Brief change log
- deduplicate code in `mesos-appmaster(-job).sh` into `mesos-jobmanager.sh`
- add JVM memory args to mesos JM start command in `mesos-jobmanager.sh`
## Verifying this change
Unit, Jepsen and e2e tests.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (yes)
- If yes, how is the feature documented? (not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on issue #11863: [FLINK-17048][mesos] Add memory related JVM args to Mesos JM startup scripts
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11863:
URL: https://github.com/apache/flink/pull/11863#issuecomment-617687609
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ea645f316cca46d137d19bbd07c759b59fb2fdb6",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=65",
"triggerID" : "ea645f316cca46d137d19bbd07c759b59fb2fdb6",
"triggerType" : "PUSH"
}, {
"hash" : "ea645f316cca46d137d19bbd07c759b59fb2fdb6",
"status" : "CANCELED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161410666",
"triggerID" : "ea645f316cca46d137d19bbd07c759b59fb2fdb6",
"triggerType" : "PUSH"
}, {
"hash" : "d559c7119084b47c163dd4e1523b3f9487d88e82",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=79",
"triggerID" : "d559c7119084b47c163dd4e1523b3f9487d88e82",
"triggerType" : "PUSH"
}, {
"hash" : "d559c7119084b47c163dd4e1523b3f9487d88e82",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161452814",
"triggerID" : "d559c7119084b47c163dd4e1523b3f9487d88e82",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ea645f316cca46d137d19bbd07c759b59fb2fdb6 Travis: [CANCELED](https://travis-ci.com/github/flink-ci/flink/builds/161410666) Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=65)
* d559c7119084b47c163dd4e1523b3f9487d88e82 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/161452814) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=79)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11863: [FLINK-17048][mesos] Add memory related JVM args to Mesos JM startup scripts
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11863:
URL: https://github.com/apache/flink/pull/11863#issuecomment-617687609
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ea645f316cca46d137d19bbd07c759b59fb2fdb6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=65",
"triggerID" : "ea645f316cca46d137d19bbd07c759b59fb2fdb6",
"triggerType" : "PUSH"
}, {
"hash" : "ea645f316cca46d137d19bbd07c759b59fb2fdb6",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161410666",
"triggerID" : "ea645f316cca46d137d19bbd07c759b59fb2fdb6",
"triggerType" : "PUSH"
}, {
"hash" : "d559c7119084b47c163dd4e1523b3f9487d88e82",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=79",
"triggerID" : "d559c7119084b47c163dd4e1523b3f9487d88e82",
"triggerType" : "PUSH"
}, {
"hash" : "d559c7119084b47c163dd4e1523b3f9487d88e82",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161452814",
"triggerID" : "d559c7119084b47c163dd4e1523b3f9487d88e82",
"triggerType" : "PUSH"
}, {
"hash" : "d61df619ede73e8234f2be3cd4adac63c8ce1f19",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=139",
"triggerID" : "d61df619ede73e8234f2be3cd4adac63c8ce1f19",
"triggerType" : "PUSH"
}, {
"hash" : "d61df619ede73e8234f2be3cd4adac63c8ce1f19",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161659332",
"triggerID" : "d61df619ede73e8234f2be3cd4adac63c8ce1f19",
"triggerType" : "PUSH"
}, {
"hash" : "b0b080e3a5efb7651d6fa032521985585d9e333e",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161780807",
"triggerID" : "b0b080e3a5efb7651d6fa032521985585d9e333e",
"triggerType" : "PUSH"
}, {
"hash" : "b0b080e3a5efb7651d6fa032521985585d9e333e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=175",
"triggerID" : "b0b080e3a5efb7651d6fa032521985585d9e333e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d61df619ede73e8234f2be3cd4adac63c8ce1f19 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/161659332) Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=139)
* b0b080e3a5efb7651d6fa032521985585d9e333e Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/161780807) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=175)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on issue #11863: [FLINK-17048][mesos] Add memory related JVM args to Mesos JM startup scripts
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11863:
URL: https://github.com/apache/flink/pull/11863#issuecomment-617687609
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ea645f316cca46d137d19bbd07c759b59fb2fdb6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=65",
"triggerID" : "ea645f316cca46d137d19bbd07c759b59fb2fdb6",
"triggerType" : "PUSH"
}, {
"hash" : "ea645f316cca46d137d19bbd07c759b59fb2fdb6",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161410666",
"triggerID" : "ea645f316cca46d137d19bbd07c759b59fb2fdb6",
"triggerType" : "PUSH"
}, {
"hash" : "d559c7119084b47c163dd4e1523b3f9487d88e82",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=79",
"triggerID" : "d559c7119084b47c163dd4e1523b3f9487d88e82",
"triggerType" : "PUSH"
}, {
"hash" : "d559c7119084b47c163dd4e1523b3f9487d88e82",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161452814",
"triggerID" : "d559c7119084b47c163dd4e1523b3f9487d88e82",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d559c7119084b47c163dd4e1523b3f9487d88e82 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/161452814) Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=79)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11863: [FLINK-17048][mesos] Add memory related JVM args to Mesos JM startup scripts
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11863:
URL: https://github.com/apache/flink/pull/11863#issuecomment-617687609
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ea645f316cca46d137d19bbd07c759b59fb2fdb6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=65",
"triggerID" : "ea645f316cca46d137d19bbd07c759b59fb2fdb6",
"triggerType" : "PUSH"
}, {
"hash" : "ea645f316cca46d137d19bbd07c759b59fb2fdb6",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161410666",
"triggerID" : "ea645f316cca46d137d19bbd07c759b59fb2fdb6",
"triggerType" : "PUSH"
}, {
"hash" : "d559c7119084b47c163dd4e1523b3f9487d88e82",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=79",
"triggerID" : "d559c7119084b47c163dd4e1523b3f9487d88e82",
"triggerType" : "PUSH"
}, {
"hash" : "d559c7119084b47c163dd4e1523b3f9487d88e82",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161452814",
"triggerID" : "d559c7119084b47c163dd4e1523b3f9487d88e82",
"triggerType" : "PUSH"
}, {
"hash" : "d61df619ede73e8234f2be3cd4adac63c8ce1f19",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=139",
"triggerID" : "d61df619ede73e8234f2be3cd4adac63c8ce1f19",
"triggerType" : "PUSH"
}, {
"hash" : "d61df619ede73e8234f2be3cd4adac63c8ce1f19",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161659332",
"triggerID" : "d61df619ede73e8234f2be3cd4adac63c8ce1f19",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d61df619ede73e8234f2be3cd4adac63c8ce1f19 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/161659332) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=139)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #11863: [FLINK-17048][mesos] Add memory related JVM args to Mesos JM startup scripts
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #11863:
URL: https://github.com/apache/flink/pull/11863#discussion_r413672750
##########
File path: flink-dist/src/main/flink-bin/mesos-bin/mesos-appmaster.sh
##########
@@ -17,29 +17,10 @@
# limitations under the License.
################################################################################
-bin=`dirname "$0"`
-bin=`cd "$bin"; pwd`
+bin=$(dirname "$0")
+bin=$(cd "${bin}" || exit; pwd)
# get Flink config
-. "$bin"/config.sh
+. "${bin}"/config.sh
-if [ "$FLINK_IDENT_STRING" = "" ]; then
- FLINK_IDENT_STRING="$USER"
-fi
-
-CC_CLASSPATH=`manglePathList $(constructFlinkClassPath):$INTERNAL_HADOOP_CLASSPATHS`
-
-log="${FLINK_LOG_DIR}/flink-${FLINK_IDENT_STRING}-mesos-appmaster-${HOSTNAME}.log"
-log_setting="-Dlog.file="$log" -Dlog4j.configuration=file:"$FLINK_CONF_DIR"/log4j.properties -Dlog4j.configurationFile=file:"$FLINK_CONF_DIR"/log4j.properties -Dlogback.configurationFile=file:"$FLINK_CONF_DIR"/logback.xml"
-
-ENTRY_POINT=org.apache.flink.mesos.entrypoint.MesosSessionClusterEntrypoint
-
-exec $JAVA_RUN $JVM_ARGS -classpath "$CC_CLASSPATH" $log_setting ${ENTRY_POINT} "$@"
-
-rc=$?
-
-if [[ $rc -ne 0 ]]; then
- echo "Error while starting the mesos application master. Please check ${log} for more details."
-fi
-
-exit $rc
+exec "${FLINK_BIN_DIR}"/mesos-jobmanager.sh "org.apache.flink.mesos.entrypoint.MesosSessionClusterEntrypoint" "$@"
Review comment:
is the `exec` actually necessary? I see both approaches in `taskmanager.sh`; would be good to make a conscious decision to pick one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on issue #11863: [FLINK-17048][mesos] Add memory related JVM args to Mesos JM startup scripts
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11863:
URL: https://github.com/apache/flink/pull/11863#issuecomment-617677420
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 29e9ab827ed903f4bfe37087ac57681cc56dc729 (Wed Apr 22 09:54:59 UTC 2020)
**Warnings:**
* **1 pom.xml files were touched**: Check for build and licensing issues.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on issue #11863: [FLINK-17048][mesos] Add memory related JVM args to Mesos JM startup scripts
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11863:
URL: https://github.com/apache/flink/pull/11863#issuecomment-617687609
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ea645f316cca46d137d19bbd07c759b59fb2fdb6",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=65",
"triggerID" : "ea645f316cca46d137d19bbd07c759b59fb2fdb6",
"triggerType" : "PUSH"
}, {
"hash" : "ea645f316cca46d137d19bbd07c759b59fb2fdb6",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161410666",
"triggerID" : "ea645f316cca46d137d19bbd07c759b59fb2fdb6",
"triggerType" : "PUSH"
}, {
"hash" : "d559c7119084b47c163dd4e1523b3f9487d88e82",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d559c7119084b47c163dd4e1523b3f9487d88e82",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ea645f316cca46d137d19bbd07c759b59fb2fdb6 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/161410666) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=65)
* d559c7119084b47c163dd4e1523b3f9487d88e82 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #11863: [FLINK-17048][mesos] Add memory related JVM args to Mesos JM startup scripts
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #11863:
URL: https://github.com/apache/flink/pull/11863#discussion_r413667905
##########
File path: flink-dist/src/main/flink-bin/mesos-bin/mesos-appmaster.sh
##########
@@ -17,29 +17,10 @@
# limitations under the License.
################################################################################
-bin=`dirname "$0"`
-bin=`cd "$bin"; pwd`
+bin=$(dirname "$0")
+bin=$(cd "${bin}" || exit; pwd)
# get Flink config
-. "$bin"/config.sh
+. "${bin}"/config.sh
Review comment:
Can we not remove this?
##########
File path: flink-dist/src/main/flink-bin/mesos-bin/mesos-jobmanager.sh
##########
@@ -0,0 +1,46 @@
+#!/usr/bin/env bash
+################################################################################
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+################################################################################
+
+ENTRY_POINT=$1
+ARGS=("${@:2}")
+
+bin=$(dirname "$0")
+bin=$(cd "${bin}" || exit; pwd)
+
+# get Flink config
+. "${bin}"/config.sh
+
+if [ "$FLINK_IDENT_STRING" = "" ]; then
+ FLINK_IDENT_STRING="$USER"
+fi
+
+CC_CLASSPATH=$(manglePathList "$(constructFlinkClassPath):${INTERNAL_HADOOP_CLASSPATHS}")
+
+log="${FLINK_LOG_DIR}/flink-${FLINK_IDENT_STRING}-mesos-appmaster-${HOSTNAME}.log"
+log_setting="-Dlog.file=${log} -Dlog4j.configuration=file:${FLINK_CONF_DIR}/log4j.properties -Dlog4j.configurationFile=file:${FLINK_CONF_DIR}/log4j.properties -Dlogback.configurationFile=file:${FLINK_CONF_DIR}/logback.xml"
+
+${JAVA_RUN} ${JVM_ARGS} -classpath ${CC_CLASSPATH} ${log_setting} ${ENTRY_POINT} "${ARGS[@]}"
Review comment:
any particular reason why you removed `exec`? Was it just to be in sync with other Flink scripts (like flink-daemon)?
##########
File path: flink-dist/src/main/flink-bin/mesos-bin/mesos-appmaster-job.sh
##########
@@ -17,27 +17,10 @@
# limitations under the License.
################################################################################
-bin=`dirname "$0"`
-bin=`cd "$bin"; pwd`
+bin=$(dirname "$0")
+bin=$(cd "${bin}" || exit; pwd)
# get Flink config
-. "$bin"/config.sh
+. "${bin}"/config.sh
Review comment:
Can we not remove this?
##########
File path: flink-dist/src/main/flink-bin/mesos-bin/mesos-appmaster.sh
##########
@@ -17,29 +17,10 @@
# limitations under the License.
################################################################################
-bin=`dirname "$0"`
-bin=`cd "$bin"; pwd`
+bin=$(dirname "$0")
+bin=$(cd "${bin}" || exit; pwd)
# get Flink config
-. "$bin"/config.sh
+. "${bin}"/config.sh
-if [ "$FLINK_IDENT_STRING" = "" ]; then
- FLINK_IDENT_STRING="$USER"
-fi
-
-CC_CLASSPATH=`manglePathList $(constructFlinkClassPath):$INTERNAL_HADOOP_CLASSPATHS`
-
-log="${FLINK_LOG_DIR}/flink-${FLINK_IDENT_STRING}-mesos-appmaster-${HOSTNAME}.log"
-log_setting="-Dlog.file="$log" -Dlog4j.configuration=file:"$FLINK_CONF_DIR"/log4j.properties -Dlog4j.configurationFile=file:"$FLINK_CONF_DIR"/log4j.properties -Dlogback.configurationFile=file:"$FLINK_CONF_DIR"/logback.xml"
-
-ENTRY_POINT=org.apache.flink.mesos.entrypoint.MesosSessionClusterEntrypoint
-
-exec $JAVA_RUN $JVM_ARGS -classpath "$CC_CLASSPATH" $log_setting ${ENTRY_POINT} "$@"
-
-rc=$?
-
-if [[ $rc -ne 0 ]]; then
- echo "Error while starting the mesos application master. Please check ${log} for more details."
-fi
-
-exit $rc
+exec "${FLINK_BIN_DIR}"/mesos-jobmanager.sh "org.apache.flink.mesos.entrypoint.MesosSessionClusterEntrypoint" "$@"
Review comment:
is the ´exec` actually necessary? I see both approaches in `taskmanager.sh`; would be good to make a conscious decision to pick one.
##########
File path: flink-dist/src/main/flink-bin/mesos-bin/mesos-jobmanager.sh
##########
@@ -26,6 +26,19 @@ bin=$(cd "${bin}" || exit; pwd)
# get Flink config
. "${bin}"/config.sh
+java_utils_output=$(runBashJavaUtilsCmd GET_JM_RESOURCE_PARAMS "${FLINK_CONF_DIR}" "${FLINK_BIN_DIR}/bash-java-utils.jar:$(findFlinkDistJar)" "${ARGS[@]}")
+logging_output=$(extractLoggingOutputs "${java_utils_output}")
Review comment:
is there a way to deduplicate this with `taskmanager.sh`? It's _pretty much_ the same thing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11863: [FLINK-17048][mesos] Add memory related JVM args to Mesos JM startup scripts
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11863:
URL: https://github.com/apache/flink/pull/11863#issuecomment-617687609
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ea645f316cca46d137d19bbd07c759b59fb2fdb6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=65",
"triggerID" : "ea645f316cca46d137d19bbd07c759b59fb2fdb6",
"triggerType" : "PUSH"
}, {
"hash" : "ea645f316cca46d137d19bbd07c759b59fb2fdb6",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161410666",
"triggerID" : "ea645f316cca46d137d19bbd07c759b59fb2fdb6",
"triggerType" : "PUSH"
}, {
"hash" : "d559c7119084b47c163dd4e1523b3f9487d88e82",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=79",
"triggerID" : "d559c7119084b47c163dd4e1523b3f9487d88e82",
"triggerType" : "PUSH"
}, {
"hash" : "d559c7119084b47c163dd4e1523b3f9487d88e82",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161452814",
"triggerID" : "d559c7119084b47c163dd4e1523b3f9487d88e82",
"triggerType" : "PUSH"
}, {
"hash" : "d61df619ede73e8234f2be3cd4adac63c8ce1f19",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=139",
"triggerID" : "d61df619ede73e8234f2be3cd4adac63c8ce1f19",
"triggerType" : "PUSH"
}, {
"hash" : "d61df619ede73e8234f2be3cd4adac63c8ce1f19",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161659332",
"triggerID" : "d61df619ede73e8234f2be3cd4adac63c8ce1f19",
"triggerType" : "PUSH"
}, {
"hash" : "b0b080e3a5efb7651d6fa032521985585d9e333e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b0b080e3a5efb7651d6fa032521985585d9e333e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d61df619ede73e8234f2be3cd4adac63c8ce1f19 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/161659332) Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=139)
* b0b080e3a5efb7651d6fa032521985585d9e333e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11863: [FLINK-17048][mesos] Add memory related JVM args to Mesos JM startup scripts
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11863:
URL: https://github.com/apache/flink/pull/11863#issuecomment-617687609
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ea645f316cca46d137d19bbd07c759b59fb2fdb6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=65",
"triggerID" : "ea645f316cca46d137d19bbd07c759b59fb2fdb6",
"triggerType" : "PUSH"
}, {
"hash" : "ea645f316cca46d137d19bbd07c759b59fb2fdb6",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161410666",
"triggerID" : "ea645f316cca46d137d19bbd07c759b59fb2fdb6",
"triggerType" : "PUSH"
}, {
"hash" : "d559c7119084b47c163dd4e1523b3f9487d88e82",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=79",
"triggerID" : "d559c7119084b47c163dd4e1523b3f9487d88e82",
"triggerType" : "PUSH"
}, {
"hash" : "d559c7119084b47c163dd4e1523b3f9487d88e82",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161452814",
"triggerID" : "d559c7119084b47c163dd4e1523b3f9487d88e82",
"triggerType" : "PUSH"
}, {
"hash" : "d61df619ede73e8234f2be3cd4adac63c8ce1f19",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=139",
"triggerID" : "d61df619ede73e8234f2be3cd4adac63c8ce1f19",
"triggerType" : "PUSH"
}, {
"hash" : "d61df619ede73e8234f2be3cd4adac63c8ce1f19",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161659332",
"triggerID" : "d61df619ede73e8234f2be3cd4adac63c8ce1f19",
"triggerType" : "PUSH"
}, {
"hash" : "b0b080e3a5efb7651d6fa032521985585d9e333e",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161780807",
"triggerID" : "b0b080e3a5efb7651d6fa032521985585d9e333e",
"triggerType" : "PUSH"
}, {
"hash" : "b0b080e3a5efb7651d6fa032521985585d9e333e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=175",
"triggerID" : "b0b080e3a5efb7651d6fa032521985585d9e333e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b0b080e3a5efb7651d6fa032521985585d9e333e Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/161780807) Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=175)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] azagrebin commented on a change in pull request #11863: [FLINK-17048][mesos] Add memory related JVM args to Mesos JM startup scripts
Posted by GitBox <gi...@apache.org>.
azagrebin commented on a change in pull request #11863:
URL: https://github.com/apache/flink/pull/11863#discussion_r413875648
##########
File path: flink-dist/src/main/flink-bin/mesos-bin/mesos-jobmanager.sh
##########
@@ -0,0 +1,46 @@
+#!/usr/bin/env bash
+################################################################################
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+################################################################################
+
+ENTRY_POINT=$1
+ARGS=("${@:2}")
+
+bin=$(dirname "$0")
+bin=$(cd "${bin}" || exit; pwd)
+
+# get Flink config
+. "${bin}"/config.sh
+
+if [ "$FLINK_IDENT_STRING" = "" ]; then
+ FLINK_IDENT_STRING="$USER"
+fi
+
+CC_CLASSPATH=$(manglePathList "$(constructFlinkClassPath):${INTERNAL_HADOOP_CLASSPATHS}")
+
+log="${FLINK_LOG_DIR}/flink-${FLINK_IDENT_STRING}-mesos-appmaster-${HOSTNAME}.log"
+log_setting="-Dlog.file=${log} -Dlog4j.configuration=file:${FLINK_CONF_DIR}/log4j.properties -Dlog4j.configurationFile=file:${FLINK_CONF_DIR}/log4j.properties -Dlogback.configurationFile=file:${FLINK_CONF_DIR}/logback.xml"
+
+${JAVA_RUN} ${JVM_ARGS} -classpath ${CC_CLASSPATH} ${log_setting} ${ENTRY_POINT} "${ARGS[@]}"
Review comment:
I am not sure about other scripts but exec replaces the current process (throws it away) making new process the shell’s direct child (in our case usually long running). So it makes sense a bit in terms of resources and when it is a last thing to do, you do not need to wait for the forked result but it is not strictly needed. In case of initial mesos scripts, it was even a mistake to use exec because there is a code to handle the result.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on issue #11863: [FLINK-17048][mesos] Add memory related JVM args to Mesos JM startup scripts
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11863:
URL: https://github.com/apache/flink/pull/11863#issuecomment-617687609
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ea645f316cca46d137d19bbd07c759b59fb2fdb6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=65",
"triggerID" : "ea645f316cca46d137d19bbd07c759b59fb2fdb6",
"triggerType" : "PUSH"
}, {
"hash" : "ea645f316cca46d137d19bbd07c759b59fb2fdb6",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161410666",
"triggerID" : "ea645f316cca46d137d19bbd07c759b59fb2fdb6",
"triggerType" : "PUSH"
}, {
"hash" : "d559c7119084b47c163dd4e1523b3f9487d88e82",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=79",
"triggerID" : "d559c7119084b47c163dd4e1523b3f9487d88e82",
"triggerType" : "PUSH"
}, {
"hash" : "d559c7119084b47c163dd4e1523b3f9487d88e82",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161452814",
"triggerID" : "d559c7119084b47c163dd4e1523b3f9487d88e82",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d559c7119084b47c163dd4e1523b3f9487d88e82 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/161452814) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=79)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11863: [FLINK-17048][mesos] Add memory related JVM args to Mesos JM startup scripts
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11863:
URL: https://github.com/apache/flink/pull/11863#issuecomment-617687609
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ea645f316cca46d137d19bbd07c759b59fb2fdb6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=65",
"triggerID" : "ea645f316cca46d137d19bbd07c759b59fb2fdb6",
"triggerType" : "PUSH"
}, {
"hash" : "ea645f316cca46d137d19bbd07c759b59fb2fdb6",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161410666",
"triggerID" : "ea645f316cca46d137d19bbd07c759b59fb2fdb6",
"triggerType" : "PUSH"
}, {
"hash" : "d559c7119084b47c163dd4e1523b3f9487d88e82",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=79",
"triggerID" : "d559c7119084b47c163dd4e1523b3f9487d88e82",
"triggerType" : "PUSH"
}, {
"hash" : "d559c7119084b47c163dd4e1523b3f9487d88e82",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161452814",
"triggerID" : "d559c7119084b47c163dd4e1523b3f9487d88e82",
"triggerType" : "PUSH"
}, {
"hash" : "d61df619ede73e8234f2be3cd4adac63c8ce1f19",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=139",
"triggerID" : "d61df619ede73e8234f2be3cd4adac63c8ce1f19",
"triggerType" : "PUSH"
}, {
"hash" : "d61df619ede73e8234f2be3cd4adac63c8ce1f19",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161659332",
"triggerID" : "d61df619ede73e8234f2be3cd4adac63c8ce1f19",
"triggerType" : "PUSH"
}, {
"hash" : "b0b080e3a5efb7651d6fa032521985585d9e333e",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161780807",
"triggerID" : "b0b080e3a5efb7651d6fa032521985585d9e333e",
"triggerType" : "PUSH"
}, {
"hash" : "b0b080e3a5efb7651d6fa032521985585d9e333e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=175",
"triggerID" : "b0b080e3a5efb7651d6fa032521985585d9e333e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b0b080e3a5efb7651d6fa032521985585d9e333e Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/161780807) Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=175)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on issue #11863: [FLINK-17048][mesos] Add memory related JVM args to Mesos JM startup scripts
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11863:
URL: https://github.com/apache/flink/pull/11863#issuecomment-617687609
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ea645f316cca46d137d19bbd07c759b59fb2fdb6",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=65",
"triggerID" : "ea645f316cca46d137d19bbd07c759b59fb2fdb6",
"triggerType" : "PUSH"
}, {
"hash" : "ea645f316cca46d137d19bbd07c759b59fb2fdb6",
"status" : "CANCELED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161410666",
"triggerID" : "ea645f316cca46d137d19bbd07c759b59fb2fdb6",
"triggerType" : "PUSH"
}, {
"hash" : "d559c7119084b47c163dd4e1523b3f9487d88e82",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=79",
"triggerID" : "d559c7119084b47c163dd4e1523b3f9487d88e82",
"triggerType" : "PUSH"
}, {
"hash" : "d559c7119084b47c163dd4e1523b3f9487d88e82",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161452814",
"triggerID" : "d559c7119084b47c163dd4e1523b3f9487d88e82",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ea645f316cca46d137d19bbd07c759b59fb2fdb6 Travis: [CANCELED](https://travis-ci.com/github/flink-ci/flink/builds/161410666) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=65)
* d559c7119084b47c163dd4e1523b3f9487d88e82 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/161452814) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=79)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on issue #11863: [FLINK-17048][mesos] Add memory related JVM args to Mesos JM startup scripts
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11863:
URL: https://github.com/apache/flink/pull/11863#issuecomment-617687609
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ea645f316cca46d137d19bbd07c759b59fb2fdb6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ea645f316cca46d137d19bbd07c759b59fb2fdb6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ea645f316cca46d137d19bbd07c759b59fb2fdb6 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] azagrebin commented on issue #11863: [FLINK-17048][mesos] Add memory related JVM args to Mesos JM startup scripts
Posted by GitBox <gi...@apache.org>.
azagrebin commented on issue #11863:
URL: https://github.com/apache/flink/pull/11863#issuecomment-617675892
The PR is based on other FLIP-116 PRs, only last commit is to review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11863: [FLINK-17048][mesos] Add memory related JVM args to Mesos JM startup scripts
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11863:
URL: https://github.com/apache/flink/pull/11863#issuecomment-617687609
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ea645f316cca46d137d19bbd07c759b59fb2fdb6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=65",
"triggerID" : "ea645f316cca46d137d19bbd07c759b59fb2fdb6",
"triggerType" : "PUSH"
}, {
"hash" : "ea645f316cca46d137d19bbd07c759b59fb2fdb6",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161410666",
"triggerID" : "ea645f316cca46d137d19bbd07c759b59fb2fdb6",
"triggerType" : "PUSH"
}, {
"hash" : "d559c7119084b47c163dd4e1523b3f9487d88e82",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=79",
"triggerID" : "d559c7119084b47c163dd4e1523b3f9487d88e82",
"triggerType" : "PUSH"
}, {
"hash" : "d559c7119084b47c163dd4e1523b3f9487d88e82",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161452814",
"triggerID" : "d559c7119084b47c163dd4e1523b3f9487d88e82",
"triggerType" : "PUSH"
}, {
"hash" : "d61df619ede73e8234f2be3cd4adac63c8ce1f19",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=139",
"triggerID" : "d61df619ede73e8234f2be3cd4adac63c8ce1f19",
"triggerType" : "PUSH"
}, {
"hash" : "d61df619ede73e8234f2be3cd4adac63c8ce1f19",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161659332",
"triggerID" : "d61df619ede73e8234f2be3cd4adac63c8ce1f19",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d61df619ede73e8234f2be3cd4adac63c8ce1f19 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/161659332) Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=139)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on issue #11863: [FLINK-17048][mesos] Add memory related JVM args to Mesos JM startup scripts
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11863:
URL: https://github.com/apache/flink/pull/11863#issuecomment-617687609
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ea645f316cca46d137d19bbd07c759b59fb2fdb6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=65",
"triggerID" : "ea645f316cca46d137d19bbd07c759b59fb2fdb6",
"triggerType" : "PUSH"
}, {
"hash" : "ea645f316cca46d137d19bbd07c759b59fb2fdb6",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161410666",
"triggerID" : "ea645f316cca46d137d19bbd07c759b59fb2fdb6",
"triggerType" : "PUSH"
}, {
"hash" : "d559c7119084b47c163dd4e1523b3f9487d88e82",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=79",
"triggerID" : "d559c7119084b47c163dd4e1523b3f9487d88e82",
"triggerType" : "PUSH"
}, {
"hash" : "d559c7119084b47c163dd4e1523b3f9487d88e82",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161452814",
"triggerID" : "d559c7119084b47c163dd4e1523b3f9487d88e82",
"triggerType" : "PUSH"
}, {
"hash" : "d61df619ede73e8234f2be3cd4adac63c8ce1f19",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=139",
"triggerID" : "d61df619ede73e8234f2be3cd4adac63c8ce1f19",
"triggerType" : "PUSH"
}, {
"hash" : "d61df619ede73e8234f2be3cd4adac63c8ce1f19",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161659332",
"triggerID" : "d61df619ede73e8234f2be3cd4adac63c8ce1f19",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d559c7119084b47c163dd4e1523b3f9487d88e82 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/161452814) Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=79)
* d61df619ede73e8234f2be3cd4adac63c8ce1f19 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/161659332) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=139)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on issue #11863: [FLINK-17048][mesos] Add memory related JVM args to Mesos JM startup scripts
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11863:
URL: https://github.com/apache/flink/pull/11863#issuecomment-617687609
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ea645f316cca46d137d19bbd07c759b59fb2fdb6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=65",
"triggerID" : "ea645f316cca46d137d19bbd07c759b59fb2fdb6",
"triggerType" : "PUSH"
}, {
"hash" : "ea645f316cca46d137d19bbd07c759b59fb2fdb6",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161410666",
"triggerID" : "ea645f316cca46d137d19bbd07c759b59fb2fdb6",
"triggerType" : "PUSH"
}, {
"hash" : "d559c7119084b47c163dd4e1523b3f9487d88e82",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=79",
"triggerID" : "d559c7119084b47c163dd4e1523b3f9487d88e82",
"triggerType" : "PUSH"
}, {
"hash" : "d559c7119084b47c163dd4e1523b3f9487d88e82",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161452814",
"triggerID" : "d559c7119084b47c163dd4e1523b3f9487d88e82",
"triggerType" : "PUSH"
}, {
"hash" : "d61df619ede73e8234f2be3cd4adac63c8ce1f19",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d61df619ede73e8234f2be3cd4adac63c8ce1f19",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d559c7119084b47c163dd4e1523b3f9487d88e82 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/161452814) Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=79)
* d61df619ede73e8234f2be3cd4adac63c8ce1f19 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] azagrebin edited a comment on issue #11863: [FLINK-17048][mesos] Add memory related JVM args to Mesos JM startup scripts
Posted by GitBox <gi...@apache.org>.
azagrebin edited a comment on issue #11863:
URL: https://github.com/apache/flink/pull/11863#issuecomment-617675892
The PR is based on other FLIP-116 PRs, only last 2 commits are to review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on issue #11863: [FLINK-17048][mesos] Add memory related JVM args to Mesos JM startup scripts
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11863:
URL: https://github.com/apache/flink/pull/11863#issuecomment-617687609
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ea645f316cca46d137d19bbd07c759b59fb2fdb6",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=65",
"triggerID" : "ea645f316cca46d137d19bbd07c759b59fb2fdb6",
"triggerType" : "PUSH"
}, {
"hash" : "ea645f316cca46d137d19bbd07c759b59fb2fdb6",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161410666",
"triggerID" : "ea645f316cca46d137d19bbd07c759b59fb2fdb6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ea645f316cca46d137d19bbd07c759b59fb2fdb6 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/161410666) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=65)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org