You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/08/10 05:46:27 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request, #6827: syslog: Move syslog_rpmsg_server_init to syslog_initialize

xiaoxiang781216 opened a new pull request, #6827:
URL: https://github.com/apache/incubator-nuttx/pull/6827

   ## Summary
   
   ## Impact
   Code refactor
   
   ## Testing
   Pass build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6827: Refine rpmsg server initialization sequence

Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #6827:
URL: https://github.com/apache/incubator-nuttx/pull/6827#discussion_r942623170


##########
boards/sim/sim/sim/configs/rpserver/defconfig:
##########
@@ -19,7 +19,7 @@ CONFIG_DEV_SIMPLE_ADDRENV=y
 CONFIG_EXAMPLES_RPMSGSOCKET=y
 CONFIG_FS_HOSTFS=y
 CONFIG_FS_PROCFS=y
-CONFIG_FS_RPMSGFS=y
+CONFIG_FS_RPMSGFS_SERVER=y

Review Comment:
   Should we note such transition in release notes, so users will not get unexpected effect?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6827: Refine rpmsg server initialization sequence

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #6827:
URL: https://github.com/apache/incubator-nuttx/pull/6827#discussion_r942745365


##########
boards/sim/sim/sim/configs/rpserver/defconfig:
##########
@@ -19,7 +19,7 @@ CONFIG_DEV_SIMPLE_ADDRENV=y
 CONFIG_EXAMPLES_RPMSGSOCKET=y
 CONFIG_FS_HOSTFS=y
 CONFIG_FS_PROCFS=y
-CONFIG_FS_RPMSGFS=y
+CONFIG_FS_RPMSGFS_SERVER=y

Review Comment:
   Add "Breaking change" mark



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] pkarashchenko merged pull request #6827: Refine rpmsg server initialization sequence

Posted by GitBox <gi...@apache.org>.
pkarashchenko merged PR #6827:
URL: https://github.com/apache/incubator-nuttx/pull/6827


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org