You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2017/04/14 16:08:39 UTC
Review Request 58458: Enabled authorization in default executor check
tests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58458/
-----------------------------------------------------------
Review request for mesos, Adam B, Anand Mazumdar, Alexander Rojas, and Vinod Kone.
Bugs: MESOS-7339
https://issues.apache.org/jira/browse/MESOS-7339
Repository: mesos
Description
-------
This patch enables authorization in the check and health check
tests which use the default executor. Simple permissive ACLs are
set, forcing the local authorizer to be loaded which allows us
to test the implicit executor authorization code for agent
operator API calls.
Diffs
-----
src/tests/check_tests.cpp d7fcbf940102efe0841f07e8c4937a78361bc422
src/tests/health_check_tests.cpp c5857b2415faaec4d0557e50cbeb42379f4550ac
Diff: https://reviews.apache.org/r/58458/diff/1/
Testing
-------
`make check`
Thanks,
Greg Mann
Re: Review Request 58458: Enabled authorization in default executor
check tests.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58458/#review172296
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On April 14, 2017, 4:08 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58458/
> -----------------------------------------------------------
>
> (Updated April 14, 2017, 4:08 p.m.)
>
>
> Review request for mesos, Adam B, Anand Mazumdar, Alexander Rojas, and Vinod Kone.
>
>
> Bugs: MESOS-7339
> https://issues.apache.org/jira/browse/MESOS-7339
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch enables authorization in the check and health check
> tests which use the default executor. Simple permissive ACLs are
> set, forcing the local authorizer to be loaded which allows us
> to test the implicit executor authorization code for agent
> operator API calls.
>
>
> Diffs
> -----
>
> src/tests/check_tests.cpp d7fcbf940102efe0841f07e8c4937a78361bc422
> src/tests/health_check_tests.cpp c5857b2415faaec4d0557e50cbeb42379f4550ac
>
>
> Diff: https://reviews.apache.org/r/58458/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 58458: Enabled authorization in default executor
check tests.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58458/#review172010
-----------------------------------------------------------
Patch looks great!
Reviews applied: [58327, 58328, 58251, 58252, 58253, 58254, 58255, 58258, 58428, 58458]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On April 14, 2017, 4:08 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58458/
> -----------------------------------------------------------
>
> (Updated April 14, 2017, 4:08 p.m.)
>
>
> Review request for mesos, Adam B, Anand Mazumdar, Alexander Rojas, and Vinod Kone.
>
>
> Bugs: MESOS-7339
> https://issues.apache.org/jira/browse/MESOS-7339
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch enables authorization in the check and health check
> tests which use the default executor. Simple permissive ACLs are
> set, forcing the local authorizer to be loaded which allows us
> to test the implicit executor authorization code for agent
> operator API calls.
>
>
> Diffs
> -----
>
> src/tests/check_tests.cpp d7fcbf940102efe0841f07e8c4937a78361bc422
> src/tests/health_check_tests.cpp c5857b2415faaec4d0557e50cbeb42379f4550ac
>
>
> Diff: https://reviews.apache.org/r/58458/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Greg Mann
>
>