You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@maven.apache.org by Tony Jewell <to...@cregganna.com> on 2014/10/13 01:09:52 UTC
Request for functionality in maven-assembly-plugin - ignoreProjectBuildFilters
Hi,
We hit an issue when using maven-assembly-plugin:2.4.1.
We were using filters in assemblies to filter config property files
according to the assembly we were producing - thus targetting our various
environments.
In the Project Build we defined test filter sources for tests and running
in the IDE.
Unfortunately, the default action in maven-assembly-plugin is to include
all ${project.build.filters} - before the filters defined in the Assembly
configuration. This meant all our assemblies had the Test configs.
I have attached an example project that displays the issue and a patch to
the current trunk maven-assembly-plugin:2.4.2-SNAPSHOT.
A snippet from sample pom.xml showing the proposed new
ignoreProjectBuildFilters config boolean usage is:
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-assembly-plugin</artifactId>
<version>${maven-assembly-plugin.version}</version>
<executions>
<execution>
<id>prod-assemble</id>
<phase>package</phase>
<goals><goal>single</goal></goals>
<configuration>
<!-- Do not include the Filters as defined in the
Project Build -->
<includeProjectBuildFilters>false</includeProjectBuildFilters>
<filters>
<filter>src/main/filters/prod.properties</filter>
</filters>
<descriptors>
<descriptors>src/main/assemblies/prod-assemble.xml</descriptors>
</descriptors>
</configuration>
</execution>
</executions>
</plugin>
Thanks,
Tony Jewell
Cregganna Computer Consultants Ltd
Re: Request for functionality in maven-assembly-plugin - ignoreProjectBuildFilters
Posted by Barrie Treloar <ba...@gmail.com>.
On 13 October 2014 19:12, Tony Jewell <to...@cregganna.com> wrote:
> Thanks Barrie,
>
> Have now created login on Xicrles
>
> A 2.4.2 release would be really cool as we are currently blocked on this
> and I'd rather not use patched plugins in our build.
Somewhere on the internet is my notes for creating local patched releases
for this exact scenario, and allowing you to upgrade to the official one
when it comes out.
I'm at home at the moment and I can't find those notes!
They should be somewhere obvious - like on the Maven site, the wiki or in
the achives, but my google fu is failing me right now.
...
Damn, writing this email made me try harder.
Its here http://docs.codehaus.org/display/MAVENUSER/Patching+Maven+Plugins
but its really old and probably still ok, but just check before you use it.
Re: Request for functionality in maven-assembly-plugin - ignoreProjectBuildFilters
Posted by Tony Jewell <to...@cregganna.com>.
Thanks Barrie,
Have now created login on Xicrles
A 2.4.2 release would be really cool as we are currently blocked on this
and I'd rather not use patched plugins in our build.
ATB
Tony Jewell
On 13 Oct 2014 08:31, "Barrie Treloar" <ba...@gmail.com> wrote:
>
> On 13 October 2014 17:08, Tony Jewell <to...@cregganna.com> wrote:
>
> > Thanks Karl,
> >
> > Two things:
> >
> >
> > 1. I couldn't get access to the JIRA to submit a ticket myself - is
this
> > something I am allowed to request?
> >
>
> Yes, you have to do something non-intuitive to get access. It should be
> documented somewhere but I dont recall.
> On https://jira.codehaus.org/secure/Dashboard.jspa up at the top left
there
> is the menu drop down, and you need to click Xicrles (
> http://xircles.codehaus.org/)
> You need to signup there.
> This is because the Maven Jira isn't hosted at Apache.
>
>
> > 2. Of course I'm going to ask: when is maven-assembly-plugin:2.4.2
> > likely to be released?
>
>
> That's something a committer can do for you.
> You might get lucky and Karl will do that as well.
Re: Request for functionality in maven-assembly-plugin - ignoreProjectBuildFilters
Posted by Barrie Treloar <ba...@gmail.com>.
On 13 October 2014 17:08, Tony Jewell <to...@cregganna.com> wrote:
> Thanks Karl,
>
> Two things:
>
>
> 1. I couldn't get access to the JIRA to submit a ticket myself - is this
> something I am allowed to request?
>
Yes, you have to do something non-intuitive to get access. It should be
documented somewhere but I dont recall.
On https://jira.codehaus.org/secure/Dashboard.jspa up at the top left there
is the menu drop down, and you need to click Xicrles (
http://xircles.codehaus.org/)
You need to signup there.
This is because the Maven Jira isn't hosted at Apache.
> 2. Of course I'm going to ask: when is maven-assembly-plugin:2.4.2
> likely to be released?
That's something a committer can do for you.
You might get lucky and Karl will do that as well.
Re: Request for functionality in maven-assembly-plugin - ignoreProjectBuildFilters
Posted by Kristian Rosenvold <kr...@gmail.com>.
I was planning to release yesterday, but then repository.apache.org
got a full disk. ETA is thursday, so the release should be consumable
for end users sometime next week unless we run into troubles.
It's a big release so there's a fair chance of trouble :)
Kristian
2014-10-21 16:56 GMT+02:00 Tony Jewell <to...@cregganna.com>:
> Hello again,
>
> When do you think we'll see the trunk maven-assembly-plugin released.
>
> Just trying to gauge whether I can hold off hacking our source for a
> release.
>
> ATB,
> Tony Jewell
> On 13 Oct 2014 14:42, "Tony Jewell" <to...@cregganna.com> wrote:
>
>> Karl,
>>
>> That would be superb.
>>
>> Thanks for all your efforts on this.
>>
>> Regards,
>> Tony Jewell
>> On 13 Oct 2014 11:47, "Karl Heinz Marbaise" <kh...@gmx.de> wrote:
>>
>>> Hi Tony,
>>>
>>> On 10/13/14 8:38 AM, Tony Jewell wrote:
>>>
>>>> Thanks Karl,
>>>>
>>>> Two things:
>>>>
>>>> 1. I couldn't get access to the JIRA to submit a ticket myself - is
>>>> this something I am allowed to request?
>>>> 2. Of course I'm going to ask: when is maven-assembly-plugin:2.4.2
>>>> likely to be released?
>>>>
>>>
>>> It's likely that this week a release will be done which is called 2.5
>>> ...if nothing really hard will happen...
>>>
>>> we will see...
>>>
>>> Kind regards
>>> Karl Heinz Marbaise
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: users-unsubscribe@maven.apache.org
>>> For additional commands, e-mail: users-help@maven.apache.org
>>>
>>>
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@maven.apache.org
For additional commands, e-mail: users-help@maven.apache.org
Re: Request for functionality in maven-assembly-plugin - ignoreProjectBuildFilters
Posted by Tony Jewell <to...@cregganna.com>.
Hello again,
When do you think we'll see the trunk maven-assembly-plugin released.
Just trying to gauge whether I can hold off hacking our source for a
release.
ATB,
Tony Jewell
On 13 Oct 2014 14:42, "Tony Jewell" <to...@cregganna.com> wrote:
> Karl,
>
> That would be superb.
>
> Thanks for all your efforts on this.
>
> Regards,
> Tony Jewell
> On 13 Oct 2014 11:47, "Karl Heinz Marbaise" <kh...@gmx.de> wrote:
>
>> Hi Tony,
>>
>> On 10/13/14 8:38 AM, Tony Jewell wrote:
>>
>>> Thanks Karl,
>>>
>>> Two things:
>>>
>>> 1. I couldn't get access to the JIRA to submit a ticket myself - is
>>> this something I am allowed to request?
>>> 2. Of course I'm going to ask: when is maven-assembly-plugin:2.4.2
>>> likely to be released?
>>>
>>
>> It's likely that this week a release will be done which is called 2.5
>> ...if nothing really hard will happen...
>>
>> we will see...
>>
>> Kind regards
>> Karl Heinz Marbaise
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: users-unsubscribe@maven.apache.org
>> For additional commands, e-mail: users-help@maven.apache.org
>>
>>
Re: Request for functionality in maven-assembly-plugin - ignoreProjectBuildFilters
Posted by Tony Jewell <to...@cregganna.com>.
Karl,
That would be superb.
Thanks for all your efforts on this.
Regards,
Tony Jewell
On 13 Oct 2014 11:47, "Karl Heinz Marbaise" <kh...@gmx.de> wrote:
> Hi Tony,
>
> On 10/13/14 8:38 AM, Tony Jewell wrote:
>
>> Thanks Karl,
>>
>> Two things:
>>
>> 1. I couldn't get access to the JIRA to submit a ticket myself - is
>> this something I am allowed to request?
>> 2. Of course I'm going to ask: when is maven-assembly-plugin:2.4.2
>> likely to be released?
>>
>
> It's likely that this week a release will be done which is called 2.5
> ...if nothing really hard will happen...
>
> we will see...
>
> Kind regards
> Karl Heinz Marbaise
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@maven.apache.org
> For additional commands, e-mail: users-help@maven.apache.org
>
>
Re: Request for functionality in maven-assembly-plugin - ignoreProjectBuildFilters
Posted by Karl Heinz Marbaise <kh...@gmx.de>.
Hi Tony,
On 10/13/14 8:38 AM, Tony Jewell wrote:
> Thanks Karl,
>
> Two things:
>
> 1. I couldn't get access to the JIRA to submit a ticket myself - is
> this something I am allowed to request?
> 2. Of course I'm going to ask: when is maven-assembly-plugin:2.4.2
> likely to be released?
It's likely that this week a release will be done which is called 2.5
...if nothing really hard will happen...
we will see...
Kind regards
Karl Heinz Marbaise
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@maven.apache.org
For additional commands, e-mail: users-help@maven.apache.org
Re: Request for functionality in maven-assembly-plugin - ignoreProjectBuildFilters
Posted by Tony Jewell <to...@cregganna.com>.
Thanks Karl,
Two things:
1. I couldn't get access to the JIRA to submit a ticket myself - is this
something I am allowed to request?
2. Of course I'm going to ask: when is maven-assembly-plugin:2.4.2
likely to be released?
Thanks,
Tony Jewell
On 13 October 2014 07:14, Karl Heinz Marbaise <kh...@gmx.de> wrote:
> Hi Tony,
>
> I have taken a look into your patch...looks ok...
>
> This looks like a usefull enhancement so I will integrate your patch...
>
> I have created an appropriate JIRA entry:
>
> http://jira.codehaus.org/browse/MASSEMBLY-717
>
> Kind regards
> Karl Heinz Marbaise
>
>
>
> On 10/13/14 1:09 AM, Tony Jewell wrote:
>
>> Hi,
>>
>> We hit an issue when using maven-assembly-plugin:2.4.1.
>>
>> We were using filters in assemblies to filter config property files
>> according to the assembly we were producing - thus targetting our
>> various environments.
>>
>> In the Project Build we defined test filter sources for tests and
>> running in the IDE.
>>
>> Unfortunately, the default action in maven-assembly-plugin is to include
>> all ${project.build.filters} - before the filters defined in the
>> Assembly configuration. This meant all our assemblies had the Test
>> configs.
>>
>> I have attached an example project that displays the issue and a patch
>> to the current trunk maven-assembly-plugin:2.4.2-SNAPSHOT.
>>
>> A snippet from sample pom.xml showing the proposed new
>> ignoreProjectBuildFilters config boolean usage is:
>>
>> <plugin>
>> <groupId>org.apache.maven.plugins</groupId>
>> <artifactId>maven-assembly-plugin</artifactId>
>> <version>${maven-assembly-plugin.version}</version>
>> <executions>
>> <execution>
>> <id>prod-assemble</id>
>> <phase>package</phase>
>> <goals><goal>single</goal></goals>
>> <configuration>
>> <!-- Do not include the Filters as defined in
>> the Project Build -->
>>
>> <includeProjectBuildFilters>false</includeProjectBuildFilters>
>> <filters>
>>
>> <filter>src/main/filters/prod.properties</filter>
>> </filters>
>> <descriptors>
>>
>> <descriptors>src/main/assemblies/prod-assemble.xml</descriptors>
>> </descriptors>
>> </configuration>
>> </execution>
>> </executions>
>> </plugin>
>>
>> Thanks,
>>
>> Tony Jewell
>> Cregganna Computer Consultants Ltd
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@maven.apache.org
> For additional commands, e-mail: users-help@maven.apache.org
>
>
Re: Request for functionality in maven-assembly-plugin - ignoreProjectBuildFilters
Posted by Karl Heinz Marbaise <kh...@gmx.de>.
Hi Tony,
I have taken a look into your patch...looks ok...
This looks like a usefull enhancement so I will integrate your patch...
I have created an appropriate JIRA entry:
http://jira.codehaus.org/browse/MASSEMBLY-717
Kind regards
Karl Heinz Marbaise
On 10/13/14 1:09 AM, Tony Jewell wrote:
> Hi,
>
> We hit an issue when using maven-assembly-plugin:2.4.1.
>
> We were using filters in assemblies to filter config property files
> according to the assembly we were producing - thus targetting our
> various environments.
>
> In the Project Build we defined test filter sources for tests and
> running in the IDE.
>
> Unfortunately, the default action in maven-assembly-plugin is to include
> all ${project.build.filters} - before the filters defined in the
> Assembly configuration. This meant all our assemblies had the Test configs.
>
> I have attached an example project that displays the issue and a patch
> to the current trunk maven-assembly-plugin:2.4.2-SNAPSHOT.
>
> A snippet from sample pom.xml showing the proposed new
> ignoreProjectBuildFilters config boolean usage is:
>
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-assembly-plugin</artifactId>
> <version>${maven-assembly-plugin.version}</version>
> <executions>
> <execution>
> <id>prod-assemble</id>
> <phase>package</phase>
> <goals><goal>single</goal></goals>
> <configuration>
> <!-- Do not include the Filters as defined in
> the Project Build -->
>
> <includeProjectBuildFilters>false</includeProjectBuildFilters>
> <filters>
>
> <filter>src/main/filters/prod.properties</filter>
> </filters>
> <descriptors>
>
> <descriptors>src/main/assemblies/prod-assemble.xml</descriptors>
> </descriptors>
> </configuration>
> </execution>
> </executions>
> </plugin>
>
> Thanks,
>
> Tony Jewell
> Cregganna Computer Consultants Ltd
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@maven.apache.org
For additional commands, e-mail: users-help@maven.apache.org