You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by BimalTandel <gi...@git.apache.org> on 2016/02/13 00:14:35 UTC
[GitHub] spark pull request: [SPARK-7367] [Spark Submit] spark-submit CLI -...
GitHub user BimalTandel opened a pull request:
https://github.com/apache/spark/pull/11191
[SPARK-7367] [Spark Submit] spark-submit CLI --help -h overrides the application arguments
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/BimalTandel/spark spark7367
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/11191.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #11191
----
commit e127839f678f36aa58d0b47918264a7189b43faa
Author: Bimal Tandel <bi...@bimal-mbp.local>
Date: 2016-02-12T23:06:05Z
Spark 7367 complete and tested
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-7367] [Spark Submit] spark-submit CLI -...
Posted by BimalTandel <gi...@git.apache.org>.
Github user BimalTandel commented on the pull request:
https://github.com/apache/spark/pull/11191#issuecomment-183581071
I cant reproduce this on the latest release. I did the current path for the requirement to only display help if it is the only option provided.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-7367] [Spark Submit] spark-submit CLI -...
Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/11191#issuecomment-183549224
See my update to the bug. I don't think the bug exists anymore - and if it does, your fix is probably not correct.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-7367] [Spark Submit] spark-submit CLI -...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/11191#issuecomment-183624291
Please close this PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-7367] [Spark Submit] spark-submit CLI -...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11191#issuecomment-183523678
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-7367] [Spark Submit] spark-submit CLI -...
Posted by BimalTandel <gi...@git.apache.org>.
Github user BimalTandel closed the pull request at:
https://github.com/apache/spark/pull/11191
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org