You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/06/24 02:55:05 UTC

[GitHub] [pulsar] mattisonchao opened a new pull request #11059: [ Issue 11049 ] Fixed flaky test AdminApiTest

mattisonchao opened a new pull request #11059:
URL: https://github.com/apache/pulsar/pull/11059


   Fixes #11049 
   
   Master Issue: #11049 
   
   ### Motivation
   
   At certain moments, due to zookeeper delayed notification,
   the number of retry waiting times exceeded.
   
   ### Modifications
   
   - Change busy waiting to Awaitility. await method.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari merged pull request #11059: [ Issue 11049 ] Fixed flaky test AdminApiTest

Posted by GitBox <gi...@apache.org>.
lhotari merged pull request #11059:
URL: https://github.com/apache/pulsar/pull/11059


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] 315157973 commented on a change in pull request #11059: [ Issue 11049 ] Fixed flaky test AdminApiTest

Posted by GitBox <gi...@apache.org>.
315157973 commented on a change in pull request #11059:
URL: https://github.com/apache/pulsar/pull/11059#discussion_r657607116



##########
File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/AdminApiTest.java
##########
@@ -615,21 +615,16 @@ public void testInvalidDynamicConfigContentInZK() throws Exception {
      *
      * @throws Exception
      */
-    @Test
+    @Test(timeOut = 5000)

Review comment:
       We don’t need this, Awaitility will time out 10 seconds by default




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] mattisonchao commented on a change in pull request #11059: [ Issue 11049 ] Fixed flaky test AdminApiTest

Posted by GitBox <gi...@apache.org>.
mattisonchao commented on a change in pull request #11059:
URL: https://github.com/apache/pulsar/pull/11059#discussion_r657632207



##########
File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/AdminApiTest.java
##########
@@ -615,21 +615,16 @@ public void testInvalidDynamicConfigContentInZK() throws Exception {
      *
      * @throws Exception
      */
-    @Test
+    @Test(timeOut = 5000)

Review comment:
       OK~ I will fix it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org