You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by ag...@apache.org on 2018/12/12 00:21:46 UTC

[arrow] branch master updated: ARROW-3960: [Rust] remove extern crate for Rust 2018

This is an automated email from the ASF dual-hosted git repository.

agrove pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow.git


The following commit(s) were added to refs/heads/master by this push:
     new c7e9860  ARROW-3960: [Rust] remove extern crate for Rust 2018
c7e9860 is described below

commit c7e986047a7066a4001227a2901f91bc2f2a17d2
Author: Chao Sun <su...@apache.org>
AuthorDate: Tue Dec 11 17:21:35 2018 -0700

    ARROW-3960: [Rust] remove extern crate for Rust 2018
    
    This is a trivial change to remove "extern crate" definitions
    in lib.rs, to follow the new module system in Rust 2018 edition.
    
    Author: Chao Sun <su...@apache.org>
    Author: Chao Sun <su...@uber.com>
    
    Closes #3125 from sunchao/ARROW-3960 and squashes the following commits:
    
    56a4393 <Chao Sun> Remove star import
    0e5d06c <Chao Sun> Fixing json_internal error
    53c13a9 <Chao Sun> ARROW-3960:  remove extern crate for Rust 2018
---
 rust/src/datatypes.rs | 4 +++-
 rust/src/lib.rs       | 8 --------
 2 files changed, 3 insertions(+), 9 deletions(-)

diff --git a/rust/src/datatypes.rs b/rust/src/datatypes.rs
index f91c75d..36cb818 100644
--- a/rust/src/datatypes.rs
+++ b/rust/src/datatypes.rs
@@ -26,8 +26,10 @@ use std::mem::size_of;
 use std::slice::from_raw_parts;
 use std::str::FromStr;
 
+use serde_derive::{Deserialize, Serialize};
+use serde_json::{json, Value};
+
 use crate::error::{ArrowError, Result};
-use serde_json::Value;
 
 /// The possible relative types that are supported.
 ///
diff --git a/rust/src/lib.rs b/rust/src/lib.rs
index b661c21..f41d08f 100644
--- a/rust/src/lib.rs
+++ b/rust/src/lib.rs
@@ -17,14 +17,6 @@
 
 #![feature(specialization)]
 
-extern crate csv as csv_crate;
-
-#[macro_use]
-extern crate serde_derive;
-
-#[macro_use]
-extern crate serde_json;
-
 pub mod array;
 pub mod array_data;
 pub mod array_ops;