[GitHub] [airflow] potiuk commented on a change in pull request #6440: [AIRFLOW-5768] GCP cloud sql don't store ephemeral connection in db

[GitBox <gi...@apache.org>]

potiuk commented on a change in pull request #6440: [AIRFLOW-5768] GCP cloud sql don't store ephemeral connection in db
URL: https://github.com/apache/airflow/pull/6440#discussion_r344885576
 
 

 ##########
 File path: tests/gcp/hooks/test_cloud_sql.py
 ##########
 @@ -1213,235 +1173,144 @@ def test_get_sqlproxy_runner(self):
         )
         self.assertEqual(sqlproxy_runner.instance_specification, instance_spec)
 
-    @mock.patch("airflow.hooks.base_hook.BaseHook.get_connections")
-    def test_hook_with_not_too_long_unix_socket_path(self, get_connections):
+    @mock.patch("airflow.gcp.hooks.cloud_sql.CloudSqlDatabaseHook.get_connection")
 
 Review comment:
   Should we move it to "airflow.google.cloud.hooks" ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services