You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/06/17 21:57:17 UTC

[GitHub] [airflow] mik-laj opened a new pull request #9355: Move out sendgrid email from airflow.contrib

mik-laj opened a new pull request #9355:
URL: https://github.com/apache/airflow/pull/9355


   ---
   Make sure to mark the boxes below before creating PR: [x]
   
   - [X] Description above provides context of the change
   - [X] Unit tests coverage for changes (not needed for documentation changes)
   - [X] Target Github ISSUE in description if exists
   - [X] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [X] Relevant documentation is updated including usage instructions.
   - [X] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on a change in pull request #9355: Move out sendgrid email from airflow.contrib

Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #9355:
URL: https://github.com/apache/airflow/pull/9355#discussion_r442378536



##########
File path: docs/conf.py
##########
@@ -189,8 +189,6 @@
 exclude_patterns: List[str] = [
     # We only link to selected subpackages.
     '_api/airflow/index.rst',
-    # Required by airflow/contrib/plugins

Review comment:
       Also unrelated?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] feluelle commented on a change in pull request #9355: Move out sendgrid email from airflow.contrib

Posted by GitBox <gi...@apache.org>.
feluelle commented on a change in pull request #9355:
URL: https://github.com/apache/airflow/pull/9355#discussion_r442691388



##########
File path: UPDATING.md
##########
@@ -62,6 +62,28 @@ https://developers.google.com/style/inclusive-documentation
 
 -->
 
+### SendGrid emailer has been moved
+
+Formerly the core code was maintained by the original creators - Airbnb. The code that was in the contrib
+package was supported by the community. The project was passed to the Apache community and currently the
+entire code is maintained by the community, so now the division has no justification, and it is only due
+to historical reasons.
+
+To clean up, the `send_mail` function from the `airflow.contrib.utils.sendgrid` module has been moved.
+
+If your configuration file looks like this.
+```ini
+[email]
+email_backend = airflow.contrib.utils.sendgrid.send_email
+```
+It should look like this now:
+```ini
+[email]
+email_backend = airflow.providers.sendgrid.utils.emai.send_email
+```
+
+The old configuration is still works but can be abandoned.

Review comment:
       ```suggestion
   The old configuration still works but can be abandoned.
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] feluelle commented on a change in pull request #9355: Move out sendgrid email from airflow.contrib

Posted by GitBox <gi...@apache.org>.
feluelle commented on a change in pull request #9355:
URL: https://github.com/apache/airflow/pull/9355#discussion_r442691618



##########
File path: UPDATING.md
##########
@@ -62,6 +62,28 @@ https://developers.google.com/style/inclusive-documentation
 
 -->
 
+### SendGrid emailer has been moved
+
+Formerly the core code was maintained by the original creators - Airbnb. The code that was in the contrib
+package was supported by the community. The project was passed to the Apache community and currently the
+entire code is maintained by the community, so now the division has no justification, and it is only due
+to historical reasons.
+
+To clean up, the `send_mail` function from the `airflow.contrib.utils.sendgrid` module has been moved.
+
+If your configuration file looks like this.

Review comment:
       ```suggestion
   If your configuration file looks like this:
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on a change in pull request #9355: Move out sendgrid email from airflow.contrib

Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #9355:
URL: https://github.com/apache/airflow/pull/9355#discussion_r442378309



##########
File path: airflow/utils/helpers.py
##########
@@ -195,18 +195,18 @@ def partition(pred: Callable, iterable: Iterable):
 
 
 def chain(*args, **kwargs):
-    """This module is deprecated. Please use `airflow.models.baseoperator.chain`."""
+    """This function is deprecated. Please use `airflow.models.baseoperator.chain`."""

Review comment:
       Unrelated ? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] feluelle commented on a change in pull request #9355: Move out sendgrid email from airflow.contrib

Posted by GitBox <gi...@apache.org>.
feluelle commented on a change in pull request #9355:
URL: https://github.com/apache/airflow/pull/9355#discussion_r442690842



##########
File path: UPDATING.md
##########
@@ -62,6 +62,28 @@ https://developers.google.com/style/inclusive-documentation
 
 -->
 
+### SendGrid emailer has been moved
+
+Formerly the core code was maintained by the original creators - Airbnb. The code that was in the contrib
+package was supported by the community. The project was passed to the Apache community and currently the
+entire code is maintained by the community, so now the division has no justification, and it is only due
+to historical reasons.
+
+To clean up, the `send_mail` function from the `airflow.contrib.utils.sendgrid` module has been moved.
+
+If your configuration file looks like this.
+```ini
+[email]
+email_backend = airflow.contrib.utils.sendgrid.send_email
+```
+It should look like this now:
+```ini
+[email]
+email_backend = airflow.providers.sendgrid.utils.emai.send_email

Review comment:
       ```suggestion
   email_backend = airflow.providers.sendgrid.utils.emailer.send_email
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj merged pull request #9355: Move out sendgrid email from airflow.contrib

Posted by GitBox <gi...@apache.org>.
mik-laj merged pull request #9355:
URL: https://github.com/apache/airflow/pull/9355


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on a change in pull request #9355: Move out sendgrid email from airflow.contrib

Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #9355:
URL: https://github.com/apache/airflow/pull/9355#discussion_r442379330



##########
File path: docs/integration.rst
##########
@@ -28,6 +28,7 @@ Airflow has a mechanism that allows you to expand its functionality and integrat
 * :doc:`Logging </howto/write-logs>`
 * :doc:`Tracking systems </howto/tracking-user-activity>`
 * :doc:`Secrets backends </howto/use-alternative-secrets-backend>`
+* :doc:`Email backends </howto/email-config>`

Review comment:
       :+1: 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org