[jira] [Commented] (AMBARI-15250) Collision between HBase Master and RS metrics

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AMBARI-15250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15174394#comment-15174394 ] 

Hadoop QA commented on AMBARI-15250:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12790748/AMBARI-15250.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in ambari-metrics/ambari-metrics-hadoop-sink.

Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/5658//testReport/
Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/5658//console

This message is automatically generated.

> Collision between HBase Master and RS metrics
> ---------------------------------------------
>
>                 Key: AMBARI-15250
>                 URL: https://issues.apache.org/jira/browse/AMBARI-15250
>             Project: Ambari
>          Issue Type: Bug
>          Components: ambari-metrics
>    Affects Versions: 2.0.0
>            Reporter: Siddharth Wagle
>            Assignee: Siddharth Wagle
>             Fix For: 2.2.2
>
>         Attachments: AMBARI-15250.patch
>
>
> Found out that Ganglia added the processName in JVM metrics to make this distinction::
> org.apache.hadoop.metrics.ganglia.GangliaContext#emitRecord
> {code}
> // Setup so that the records have the proper leader names so they are
>     // unambiguous at the ganglia level, and this prevents a lot of rework
>     StringBuilder sb = new StringBuilder();
>     sb.append(contextName);
>     sb.append('.');
>     if (contextName.equals("jvm") && outRec.getTag("processName") != null) {
>       sb.append(outRec.getTag("processName"));
>       sb.append('.');
>     }
> {code}
> This is missing from our Sink which means some metrics do not have unique names and will collide. _Affects HBase only_



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)