You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by c4urself <gi...@git.apache.org> on 2015/10/08 19:46:21 UTC

[GitHub] thrift pull request: Thrift-1857: Python 3 support, redux

Github user c4urself commented on the pull request:

    https://github.com/apache/thrift/pull/213#issuecomment-146635657
  
    Note: I've tried this branch on Python3 and Python2 and while things seem to work correctly on Python 3; In Python2, the `six.BytesIO` object is not recognised correctly by the Python 2 `PycStringIO_InputCheck` in https://github.com/apache/thrift/blob/0.9.2/lib/py/src/protocol/fastbinary.c#L624 causing the `TBinaryProtocolAccelerated` protocol to fail.
    
    This may save someone else some digging around -- not sure where the fix should be, a hacky workaround is to import StringIO from cStringIO for Python2... -- or maybe someone else here has a better idea?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---