[GitHub] markusthoemmes commented on a change in pull request #2956: Introduce separate Akka dispatchers for CouchDB and Kafka Clients

[GitBox <gi...@apache.org>]

markusthoemmes commented on a change in pull request #2956: Introduce separate Akka dispatchers for CouchDB and Kafka Clients
URL: https://github.com/apache/incubator-openwhisk/pull/2956#discussion_r152192934
 
 

 ##########
 File path: common/scala/src/main/resources/reference.conf
 ##########
 @@ -3,4 +3,36 @@ whisk.spi{
   MessagingProvider = whisk.connector.kafka.KafkaMessagingProvider
   ContainerFactoryProvider = whisk.core.containerpool.docker.DockerContainerFactoryProvider
   LogStoreProvider = whisk.core.containerpool.logging.DockerLogStoreProvider
-}
\ No newline at end of file
+}
+
+dispatchers {
+# Custom dispatcher for CouchDB Client. Tune as needed.
+  couch-dispatcher {
+      type = Dispatcher
+      executor = "fork-join-executor"
+
+      fork-join-executor {
+          # Min number of threads to cap factor-based parallelism number to
+          parallelism-min = 2
+          # Parallelism (threads) ... ceil(available processors * factor)
+          parallelism-factor = 2.0
+          # Max number of threads to cap factor-based parallelism number to
+          parallelism-max = 10
+      }
+  }
+
+# Custom dispatcher for Kafka client. Tune as needed.
+  kafka-dispatcher {
+      type = Dispatcher
+      executor = "fork-join-executor"
+
+      fork-join-executor {
+          # Min number of threads to cap factor-based parallelism number to
+          parallelism-min = 2
+          # Parallelism (threads) ... ceil(available processors * factor)
+          parallelism-factor = 2.0
+          # Max number of threads to cap factor-based parallelism number to
+          parallelism-max = 10
+      }
+  }
 
 Review comment:
   Are we at risk to starve this one? Kafka producing **can** be blocking and polling for sure is blocking although there should never be more than a couple of polls active.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services