You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/02/26 17:39:17 UTC

[GitHub] [superset] ayanginet commented on a change in pull request #13361: chore: Migrating dashboard/components/menu from jsx to tsx

ayanginet commented on a change in pull request #13361:
URL: https://github.com/apache/superset/pull/13361#discussion_r583806465



##########
File path: superset-frontend/src/dashboard/components/menu/PopoverDropdown.tsx
##########
@@ -98,8 +104,7 @@ class PopoverDropdown extends React.PureComponent {
     const selected = options.find(opt => opt.value === value);
     return (
       <Dropdown
-        id={id}

Review comment:
       Yes, because Dropdown does not have such props.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org