You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Eric DE MAULDE (JIRA)" <ji...@apache.org> on 2009/09/14 01:09:57 UTC

[jira] Created: (OFBIZ-2935) minicart.ftl : error for thead end tag

minicart.ftl : error for thead end tag
--------------------------------------

                 Key: OFBIZ-2935
                 URL: https://issues.apache.org/jira/browse/OFBIZ-2935
             Project: OFBiz
          Issue Type: Bug
          Components: specialpurpose/ecommerce
    Affects Versions: SVN trunk
         Environment: trunk 814152
            Reporter: Eric DE MAULDE
            Priority: Trivial
             Fix For: SVN trunk


Error for thead end tag.
end tag is </thead> and no <thead>

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (OFBIZ-2935) minicart.ftl : error for thead end tag

Posted by "Deepak Dixit (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-2935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Deepak Dixit updated OFBIZ-2935:
--------------------------------

    Attachment: OFBIZ-2395.patch

Oops mistakenly forgot to merge Eric's changes. Now in this patch changes is merged.

> minicart.ftl : error for thead end tag
> --------------------------------------
>
>                 Key: OFBIZ-2935
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2935
>             Project: OFBiz
>          Issue Type: Bug
>          Components: specialpurpose/ecommerce
>    Affects Versions: SVN trunk
>         Environment: trunk 814152
>            Reporter: Eric DE MAULDE
>            Assignee: Vikas Mayur
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-2395.patch, OFBIZ-2395.patch, OFBIZ-2395.patch, OFBIZ-2935_minicart.ftl_error_for_thead_end_tag.patch
>
>
> Error for thead end tag.
> end tag is </thead> and no <thead>

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (OFBIZ-2935) minicart.ftl : error for thead end tag

Posted by "Vikas Mayur (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-2935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vikas Mayur closed OFBIZ-2935.
------------------------------

    Resolution: Fixed

Thanks Eric and Deepak,

Your Combined patch is in trunk rev. 814542

Vikas

> minicart.ftl : error for thead end tag
> --------------------------------------
>
>                 Key: OFBIZ-2935
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2935
>             Project: OFBiz
>          Issue Type: Bug
>          Components: specialpurpose/ecommerce
>    Affects Versions: SVN trunk
>         Environment: trunk 814152
>            Reporter: Eric DE MAULDE
>            Assignee: Vikas Mayur
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-2395.patch, OFBIZ-2395.patch, OFBIZ-2395.patch, OFBIZ-2935_minicart.ftl_error_for_thead_end_tag.patch
>
>
> Error for thead end tag.
> end tag is </thead> and no <thead>

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (OFBIZ-2935) minicart.ftl : error for thead end tag

Posted by "Vikas Mayur (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-2935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vikas Mayur reassigned OFBIZ-2935:
----------------------------------

    Assignee: Vikas Mayur

> minicart.ftl : error for thead end tag
> --------------------------------------
>
>                 Key: OFBIZ-2935
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2935
>             Project: OFBiz
>          Issue Type: Bug
>          Components: specialpurpose/ecommerce
>    Affects Versions: SVN trunk
>         Environment: trunk 814152
>            Reporter: Eric DE MAULDE
>            Assignee: Vikas Mayur
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-2935_minicart.ftl_error_for_thead_end_tag.patch
>
>
> Error for thead end tag.
> end tag is </thead> and no <thead>

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (OFBIZ-2935) minicart.ftl : error for thead end tag

Posted by "Deepak Dixit (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-2935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Deepak Dixit updated OFBIZ-2935:
--------------------------------

    Attachment: OFBIZ-2395.patch

Here is the improved patch for minicart.ftl:
1) Use <tfoot> tag to its correct position.
2) Improved formatting.
3) Change the class for <a> tag (buttons ==> button).

> minicart.ftl : error for thead end tag
> --------------------------------------
>
>                 Key: OFBIZ-2935
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2935
>             Project: OFBiz
>          Issue Type: Bug
>          Components: specialpurpose/ecommerce
>    Affects Versions: SVN trunk
>         Environment: trunk 814152
>            Reporter: Eric DE MAULDE
>            Assignee: Vikas Mayur
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-2395.patch, OFBIZ-2935_minicart.ftl_error_for_thead_end_tag.patch
>
>
> Error for thead end tag.
> end tag is </thead> and no <thead>

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (OFBIZ-2935) minicart.ftl : error for thead end tag

Posted by "Vikas Mayur (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-2935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12754867#action_12754867 ] 

Vikas Mayur commented on OFBIZ-2935:
------------------------------------

Hi Deepak, thanks for working on additional things. Do you mind attaching a patch that contains just the diff (no formatting changes)?



> minicart.ftl : error for thead end tag
> --------------------------------------
>
>                 Key: OFBIZ-2935
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2935
>             Project: OFBiz
>          Issue Type: Bug
>          Components: specialpurpose/ecommerce
>    Affects Versions: SVN trunk
>         Environment: trunk 814152
>            Reporter: Eric DE MAULDE
>            Assignee: Vikas Mayur
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-2395.patch, OFBIZ-2935_minicart.ftl_error_for_thead_end_tag.patch
>
>
> Error for thead end tag.
> end tag is </thead> and no <thead>

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (OFBIZ-2935) minicart.ftl : error for thead end tag

Posted by "Eric DE MAULDE (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-2935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric DE MAULDE updated OFBIZ-2935:
----------------------------------

    Attachment: OFBIZ-2935_minicart.ftl_error_for_thead_end_tag.patch

this patch corrects end tag
from <thead> to </thead>

> minicart.ftl : error for thead end tag
> --------------------------------------
>
>                 Key: OFBIZ-2935
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2935
>             Project: OFBiz
>          Issue Type: Bug
>          Components: specialpurpose/ecommerce
>    Affects Versions: SVN trunk
>         Environment: trunk 814152
>            Reporter: Eric DE MAULDE
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-2935_minicart.ftl_error_for_thead_end_tag.patch
>
>
> Error for thead end tag.
> end tag is </thead> and no <thead>

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (OFBIZ-2935) minicart.ftl : error for thead end tag

Posted by "Deepak Dixit (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-2935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Deepak Dixit updated OFBIZ-2935:
--------------------------------

    Attachment: OFBIZ-2395.patch

Sure Vikas,
Here is the patch that contains only diff (no formatting changes).

> minicart.ftl : error for thead end tag
> --------------------------------------
>
>                 Key: OFBIZ-2935
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2935
>             Project: OFBiz
>          Issue Type: Bug
>          Components: specialpurpose/ecommerce
>    Affects Versions: SVN trunk
>         Environment: trunk 814152
>            Reporter: Eric DE MAULDE
>            Assignee: Vikas Mayur
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-2395.patch, OFBIZ-2395.patch, OFBIZ-2935_minicart.ftl_error_for_thead_end_tag.patch
>
>
> Error for thead end tag.
> end tag is </thead> and no <thead>

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (OFBIZ-2935) minicart.ftl : error for thead end tag

Posted by "Deepak Dixit (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-2935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12754907#action_12754907 ] 

Deepak Dixit commented on OFBIZ-2935:
-------------------------------------

Thanks Vikas.

-----
Deepak Dixit

> minicart.ftl : error for thead end tag
> --------------------------------------
>
>                 Key: OFBIZ-2935
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2935
>             Project: OFBiz
>          Issue Type: Bug
>          Components: specialpurpose/ecommerce
>    Affects Versions: SVN trunk
>         Environment: trunk 814152
>            Reporter: Eric DE MAULDE
>            Assignee: Vikas Mayur
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-2395.patch, OFBIZ-2395.patch, OFBIZ-2395.patch, OFBIZ-2935_minicart.ftl_error_for_thead_end_tag.patch
>
>
> Error for thead end tag.
> end tag is </thead> and no <thead>

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.