You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by Christian Buchegger <ch...@planet-interkom.de> on 2002/08/26 21:30:21 UTC
[PATCH] NNTPHandler.java does not dispatch next command
NNTPHandler.java does not dispatch the next command to the method doNEXT.
Additionally the commands next and last behave like
send(header(CurrentArticleNumber++));
while they should behave like:
send(header(++CurrentArticleNumber));
The attached patch corrects both problems.
Christian
Re: [PATCH] NNTPHandler.java does not dispatch next command
Posted by Christian Buchegger <ch...@planet-interkom.de>.
Danny,
for a detailled explanation of the expected behavior have a look at the
9.1.1.3.2 NEXT Examples
in the draft-ietf-nntpext-base-13.txt.
In the first example the previous behavior would have returned the article
with the number 3000234
whereas with the fix, the first next command after selecting a group returns
the second article in
this group. This is my understanding from what I read in the examples.
Additonally I doubt that this would exhibit a regresseion, as the involved
code was never executed
before due to the missing dispatch of the next command.
Christian
----- Original Message -----
From: "Danny Angus" <da...@apache.org>
To: "James Developers List" <ja...@jakarta.apache.org>
Sent: Monday, August 26, 2002 9:48 PM
Subject: RE: [PATCH] NNTPHandler.java does not dispatch next command
> Christian,
> I've commited this, but I'd appreciate you telling me what difference the
> pre-increment/post-increment article number change makes.
> I know NNTP suffered from not displaying the first post to a group until a
> second post had been made, and hope this isn't going to revive that bug.
>
> d.
> -----Original Message-----
> From: Christian Buchegger
[mailto:christian.buchegger@planet-interkom.de]
> Sent: 26 August 2002 20:30
> To: james-dev@jakarta.apache.org
> Subject: [PATCH] NNTPHandler.java does not dispatch next command
>
>
> NNTPHandler.java does not dispatch the next command to the method
doNEXT.
> Additionally the commands next and last behave like
>
> send(header(CurrentArticleNumber++));
>
> while they should behave like:
>
> send(header(++CurrentArticleNumber));
>
> The attached patch corrects both problems.
>
> Christian
>
>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
RE: [PATCH] NNTPHandler.java does not dispatch next command
Posted by Danny Angus <da...@apache.org>.
Christian,
I've commited this, but I'd appreciate you telling me what difference the
pre-increment/post-increment article number change makes.
I know NNTP suffered from not displaying the first post to a group until a
second post had been made, and hope this isn't going to revive that bug.
d.
-----Original Message-----
From: Christian Buchegger [mailto:christian.buchegger@planet-interkom.de]
Sent: 26 August 2002 20:30
To: james-dev@jakarta.apache.org
Subject: [PATCH] NNTPHandler.java does not dispatch next command
NNTPHandler.java does not dispatch the next command to the method doNEXT.
Additionally the commands next and last behave like
send(header(CurrentArticleNumber++));
while they should behave like:
send(header(++CurrentArticleNumber));
The attached patch corrects both problems.
Christian