[jira] [Commented] (AIRFLOW-2238) Update dev/airflow-pr to work with gitub for merge targets

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-2238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16566470#comment-16566470 ] 

ASF GitHub Bot commented on AIRFLOW-2238:
-----------------------------------------

ashb opened a new pull request #3680: [AIRFLOW-2238] Use SSH protocol for pushing to Github
URL: https://github.com/apache/incubator-airflow/pull/3680
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-2238
   
   
   ### Description
   
   - [ ] Here are some details about my PR, including screenshots of any UI changes: Since we have MFA enforced we won't be able to use passwords to push and will have to use SSH keypairs. I missed this in the original PR.
   
   
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason: tested manually on another PR
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use it.
     - When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.
   
   ### Code Quality
   
   - [x] Passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Update dev/airflow-pr to work with gitub for merge targets
> ----------------------------------------------------------
>
>                 Key: AIRFLOW-2238
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-2238
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: PR tool
>            Reporter: Ash Berlin-Taylor
>            Priority: Major
>
> We are planning on migrating the to the Apache "GitBox" project which lets committers work directly on github. This will mean we might not _need_ to use the pr tool, but we should update it so that it merges and pushes back to github, not the ASF repo.
> I think we need to do this before we ask the ASF infra team to migrate our repo over.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)