You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Dominic Hamon <dh...@twopensource.com> on 2014/07/08 23:29:40 UTC

Review Request 23348: Upgrading Mesos version from 0.18.0 to 0.19.0

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23348/
-----------------------------------------------------------

Review request for mesos, Joe Smith, Kevin Sweeney, and Bill Farner.


Repository: aurora


Description
-------

Upgrading Mesos version from 0.18.0 to 0.19.0


Diffs
-----

  3rdparty/python/BUILD 122f71db0bc6f37c19ae0f3cb2fcade8321404e6 
  build.gradle 6c758f690b87eede3ae3a7c54fabac20db543840 
  examples/scheduler/scheduler-local.sh 9f77af7365c5f1953166cb50ce3903f0558cb79f 
  examples/vagrant/provision-dev-cluster.sh 97bb877a029fc4c1f32811d0c53be2761fbffae8 

Diff: https://reviews.apache.org/r/23348/diff/


Testing
-------

./gradlew build


Thanks,

Dominic Hamon

Re: Review Request 23348: Upgrading Mesos version from 0.18.0 to 0.19.0

Posted by Vinod Kone <vi...@gmail.com>.

> On July 8, 2014, 11:15 p.m., Vinod Kone wrote:
> > 3rdparty/python/BUILD, line 30
> > <https://reviews.apache.org/r/23348/diff/1/?file=625775#file625775line30>
> >
> >     we need to promote this egg internally first.
> >     
> >     i will promote it: http://jvm-ci.twitter.biz/job/mesos-scratch-build/72/console

aah sorry ignore. didn't realize this was apache review.


- Vinod


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23348/#review47473
-----------------------------------------------------------


On July 8, 2014, 9:29 p.m., Dominic Hamon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23348/
> -----------------------------------------------------------
> 
> (Updated July 8, 2014, 9:29 p.m.)
> 
> 
> Review request for mesos, Joe Smith, Kevin Sweeney, and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Upgrading Mesos version from 0.18.0 to 0.19.0
> 
> 
> Diffs
> -----
> 
>   3rdparty/python/BUILD 122f71db0bc6f37c19ae0f3cb2fcade8321404e6 
>   build.gradle 6c758f690b87eede3ae3a7c54fabac20db543840 
>   examples/scheduler/scheduler-local.sh 9f77af7365c5f1953166cb50ce3903f0558cb79f 
>   examples/vagrant/provision-dev-cluster.sh 97bb877a029fc4c1f32811d0c53be2761fbffae8 
> 
> Diff: https://reviews.apache.org/r/23348/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>

Re: Review Request 23348: Upgrading Mesos version from 0.18.0 to 0.19.0

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23348/#review47473
-----------------------------------------------------------



3rdparty/python/BUILD
<https://reviews.apache.org/r/23348/#comment83308>

    we need to promote this egg internally first.
    
    i will promote it: http://jvm-ci.twitter.biz/job/mesos-scratch-build/72/console


- Vinod Kone


On July 8, 2014, 9:29 p.m., Dominic Hamon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23348/
> -----------------------------------------------------------
> 
> (Updated July 8, 2014, 9:29 p.m.)
> 
> 
> Review request for mesos, Joe Smith, Kevin Sweeney, and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Upgrading Mesos version from 0.18.0 to 0.19.0
> 
> 
> Diffs
> -----
> 
>   3rdparty/python/BUILD 122f71db0bc6f37c19ae0f3cb2fcade8321404e6 
>   build.gradle 6c758f690b87eede3ae3a7c54fabac20db543840 
>   examples/scheduler/scheduler-local.sh 9f77af7365c5f1953166cb50ce3903f0558cb79f 
>   examples/vagrant/provision-dev-cluster.sh 97bb877a029fc4c1f32811d0c53be2761fbffae8 
> 
> Diff: https://reviews.apache.org/r/23348/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>

Re: Review Request 23348: Upgrading Mesos version from 0.18.0 to 0.19.0

Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23348/#review47477
-----------------------------------------------------------


Bad patch!

Reviews applied: [23348]

Failed command: git apply --index 23348.patch

Error:
 error: 3rdparty/python/BUILD: does not exist in index
error: build.gradle: does not exist in index
error: examples/scheduler/scheduler-local.sh: does not exist in index
error: examples/vagrant/provision-dev-cluster.sh: does not exist in index


- Mesos ReviewBot


On July 8, 2014, 9:29 p.m., Dominic Hamon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23348/
> -----------------------------------------------------------
> 
> (Updated July 8, 2014, 9:29 p.m.)
> 
> 
> Review request for mesos, Joe Smith, Kevin Sweeney, and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Upgrading Mesos version from 0.18.0 to 0.19.0
> 
> 
> Diffs
> -----
> 
>   3rdparty/python/BUILD 122f71db0bc6f37c19ae0f3cb2fcade8321404e6 
>   build.gradle 6c758f690b87eede3ae3a7c54fabac20db543840 
>   examples/scheduler/scheduler-local.sh 9f77af7365c5f1953166cb50ce3903f0558cb79f 
>   examples/vagrant/provision-dev-cluster.sh 97bb877a029fc4c1f32811d0c53be2761fbffae8 
> 
> Diff: https://reviews.apache.org/r/23348/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>

Re: Review Request 23348: Upgrading Mesos version from 0.18.0 to 0.19.0

Posted by Bill Farner <wf...@apache.org>.

> On July 29, 2014, 5:32 p.m., Kevin Sweeney wrote:
> > Ship It!

How did the tests go on this?  Ready to submit?


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23348/#review48997
-----------------------------------------------------------


On July 9, 2014, 7:50 p.m., Dominic Hamon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23348/
> -----------------------------------------------------------
> 
> (Updated July 9, 2014, 7:50 p.m.)
> 
> 
> Review request for Aurora, Joe Smith, Kevin Sweeney, and Bill Farner.
> 
> 
> Bugs: AURORA-579
>     https://issues.apache.org/jira/browse/AURORA-579
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Upgrading Mesos version from 0.18.0 to 0.19.0
> 
> 
> Diffs
> -----
> 
>   3rdparty/python/BUILD 122f71db0bc6f37c19ae0f3cb2fcade8321404e6 
>   build.gradle 6c758f690b87eede3ae3a7c54fabac20db543840 
>   examples/scheduler/scheduler-local.sh 9f77af7365c5f1953166cb50ce3903f0558cb79f 
>   examples/vagrant/provision-dev-cluster.sh 97bb877a029fc4c1f32811d0c53be2761fbffae8 
> 
> Diff: https://reviews.apache.org/r/23348/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>

Re: Review Request 23348: Upgrading Mesos version from 0.18.0 to 0.19.0

Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23348/#review48997
-----------------------------------------------------------

Ship it!


Ship It!

- Kevin Sweeney


On July 9, 2014, 12:50 p.m., Dominic Hamon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23348/
> -----------------------------------------------------------
> 
> (Updated July 9, 2014, 12:50 p.m.)
> 
> 
> Review request for Aurora, Joe Smith, Kevin Sweeney, and Bill Farner.
> 
> 
> Bugs: AURORA-579
>     https://issues.apache.org/jira/browse/AURORA-579
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Upgrading Mesos version from 0.18.0 to 0.19.0
> 
> 
> Diffs
> -----
> 
>   3rdparty/python/BUILD 122f71db0bc6f37c19ae0f3cb2fcade8321404e6 
>   build.gradle 6c758f690b87eede3ae3a7c54fabac20db543840 
>   examples/scheduler/scheduler-local.sh 9f77af7365c5f1953166cb50ce3903f0558cb79f 
>   examples/vagrant/provision-dev-cluster.sh 97bb877a029fc4c1f32811d0c53be2761fbffae8 
> 
> Diff: https://reviews.apache.org/r/23348/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>

Re: Review Request 23348: Upgrading Mesos version from 0.18.0 to 0.19.0

Posted by Kevin Sweeney <ke...@apache.org>.

> On Aug. 7, 2014, 4:05 p.m., Kevin Sweeney wrote:
> > Sorry for the turnaround, would you mind rebasing again. Looks like mesos-0.20.0 is out so maybe we should discard this review and go straight to that?

Bill: I'll be out on vacation starting tomorrow, would you mind committing this if dhamon sends an updated patch?


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23348/#review49964
-----------------------------------------------------------


On July 30, 2014, 1:25 p.m., Dominic Hamon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23348/
> -----------------------------------------------------------
> 
> (Updated July 30, 2014, 1:25 p.m.)
> 
> 
> Review request for Aurora, Joe Smith, Kevin Sweeney, and Bill Farner.
> 
> 
> Bugs: AURORA-579
>     https://issues.apache.org/jira/browse/AURORA-579
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Upgrading Mesos version from 0.18.0 to 0.19.0
> 
> 
> Diffs
> -----
> 
>   3rdparty/python/BUILD 122f71db0bc6f37c19ae0f3cb2fcade8321404e6 
>   build.gradle 6c758f690b87eede3ae3a7c54fabac20db543840 
>   examples/scheduler/scheduler-local.sh 9f77af7365c5f1953166cb50ce3903f0558cb79f 
>   examples/vagrant/provision-dev-cluster.sh 97bb877a029fc4c1f32811d0c53be2761fbffae8 
> 
> Diff: https://reviews.apache.org/r/23348/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>

Re: Review Request 23348: Upgrading Mesos version from 0.18.0 to 0.19.0

Posted by Dominic Hamon <dh...@twopensource.com>.

> On Aug. 7, 2014, 4:05 p.m., Kevin Sweeney wrote:
> > Sorry for the turnaround, would you mind rebasing again. Looks like mesos-0.20.0 is out so maybe we should discard this review and go straight to that?
> 
> Kevin Sweeney wrote:
>     Bill: I'll be out on vacation starting tomorrow, would you mind committing this if dhamon sends an updated patch?
> 
> Bill Farner wrote:
>     Sure thing.  You can collect your review delay demerits on Monday.

0.20 has not been cut or released yet.


- Dominic


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23348/#review49964
-----------------------------------------------------------


On July 30, 2014, 1:25 p.m., Dominic Hamon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23348/
> -----------------------------------------------------------
> 
> (Updated July 30, 2014, 1:25 p.m.)
> 
> 
> Review request for Aurora, Joe Smith, Kevin Sweeney, and Bill Farner.
> 
> 
> Bugs: AURORA-579
>     https://issues.apache.org/jira/browse/AURORA-579
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Upgrading Mesos version from 0.18.0 to 0.19.0
> 
> 
> Diffs
> -----
> 
>   3rdparty/python/BUILD 122f71db0bc6f37c19ae0f3cb2fcade8321404e6 
>   build.gradle 6c758f690b87eede3ae3a7c54fabac20db543840 
>   examples/scheduler/scheduler-local.sh 9f77af7365c5f1953166cb50ce3903f0558cb79f 
>   examples/vagrant/provision-dev-cluster.sh 97bb877a029fc4c1f32811d0c53be2761fbffae8 
> 
> Diff: https://reviews.apache.org/r/23348/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>

Re: Review Request 23348: Upgrading Mesos version from 0.18.0 to 0.19.0

Posted by Bill Farner <wf...@apache.org>.

> On Aug. 7, 2014, 11:05 p.m., Kevin Sweeney wrote:
> > Sorry for the turnaround, would you mind rebasing again. Looks like mesos-0.20.0 is out so maybe we should discard this review and go straight to that?
> 
> Kevin Sweeney wrote:
>     Bill: I'll be out on vacation starting tomorrow, would you mind committing this if dhamon sends an updated patch?

Sure thing.  You can collect your review delay demerits on Monday.


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23348/#review49964
-----------------------------------------------------------


On July 30, 2014, 8:25 p.m., Dominic Hamon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23348/
> -----------------------------------------------------------
> 
> (Updated July 30, 2014, 8:25 p.m.)
> 
> 
> Review request for Aurora, Joe Smith, Kevin Sweeney, and Bill Farner.
> 
> 
> Bugs: AURORA-579
>     https://issues.apache.org/jira/browse/AURORA-579
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Upgrading Mesos version from 0.18.0 to 0.19.0
> 
> 
> Diffs
> -----
> 
>   3rdparty/python/BUILD 122f71db0bc6f37c19ae0f3cb2fcade8321404e6 
>   build.gradle 6c758f690b87eede3ae3a7c54fabac20db543840 
>   examples/scheduler/scheduler-local.sh 9f77af7365c5f1953166cb50ce3903f0558cb79f 
>   examples/vagrant/provision-dev-cluster.sh 97bb877a029fc4c1f32811d0c53be2761fbffae8 
> 
> Diff: https://reviews.apache.org/r/23348/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>

Re: Review Request 23348: Upgrading Mesos version from 0.18.0 to 0.19.0

Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23348/#review49964
-----------------------------------------------------------


Sorry for the turnaround, would you mind rebasing again. Looks like mesos-0.20.0 is out so maybe we should discard this review and go straight to that?

- Kevin Sweeney


On July 30, 2014, 1:25 p.m., Dominic Hamon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23348/
> -----------------------------------------------------------
> 
> (Updated July 30, 2014, 1:25 p.m.)
> 
> 
> Review request for Aurora, Joe Smith, Kevin Sweeney, and Bill Farner.
> 
> 
> Bugs: AURORA-579
>     https://issues.apache.org/jira/browse/AURORA-579
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Upgrading Mesos version from 0.18.0 to 0.19.0
> 
> 
> Diffs
> -----
> 
>   3rdparty/python/BUILD 122f71db0bc6f37c19ae0f3cb2fcade8321404e6 
>   build.gradle 6c758f690b87eede3ae3a7c54fabac20db543840 
>   examples/scheduler/scheduler-local.sh 9f77af7365c5f1953166cb50ce3903f0558cb79f 
>   examples/vagrant/provision-dev-cluster.sh 97bb877a029fc4c1f32811d0c53be2761fbffae8 
> 
> Diff: https://reviews.apache.org/r/23348/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>

Re: Review Request 23348: Upgrading Mesos version from 0.18.0 to 0.19.0

Posted by Joe Smith <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23348/#review50079
-----------------------------------------------------------

Ship it!


+1 to going to 0.19.0 first.

- Joe Smith


On Aug. 8, 2014, 9:46 a.m., Dominic Hamon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23348/
> -----------------------------------------------------------
> 
> (Updated Aug. 8, 2014, 9:46 a.m.)
> 
> 
> Review request for Aurora, Joe Smith, Kevin Sweeney, and Bill Farner.
> 
> 
> Bugs: AURORA-579
>     https://issues.apache.org/jira/browse/AURORA-579
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Upgrading Mesos version from 0.18.0 to 0.19.0
> 
> 
> Diffs
> -----
> 
>   3rdparty/python/BUILD 641d610 
>   build.gradle 2756e84 
>   examples/scheduler/scheduler-local.sh 7df66f6 
>   examples/vagrant/provision-dev-cluster.sh 5b2d544 
> 
> Diff: https://reviews.apache.org/r/23348/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>

Re: Review Request 23348: Upgrading Mesos version from 0.18.0 to 0.19.0

Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23348/#review50088
-----------------------------------------------------------

Ship it!


Thanks!  This is now on master as 842f478.

- Bill Farner


On Aug. 8, 2014, 4:46 p.m., Dominic Hamon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23348/
> -----------------------------------------------------------
> 
> (Updated Aug. 8, 2014, 4:46 p.m.)
> 
> 
> Review request for Aurora, Joe Smith, Kevin Sweeney, and Bill Farner.
> 
> 
> Bugs: AURORA-579
>     https://issues.apache.org/jira/browse/AURORA-579
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Upgrading Mesos version from 0.18.0 to 0.19.0
> 
> 
> Diffs
> -----
> 
>   3rdparty/python/BUILD 641d610 
>   build.gradle 2756e84 
>   examples/scheduler/scheduler-local.sh 7df66f6 
>   examples/vagrant/provision-dev-cluster.sh 5b2d544 
> 
> Diff: https://reviews.apache.org/r/23348/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>

Re: Review Request 23348: Upgrading Mesos version from 0.18.0 to 0.19.0

Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23348/
-----------------------------------------------------------

(Updated Aug. 8, 2014, 9:46 a.m.)


Review request for Aurora, Joe Smith, Kevin Sweeney, and Bill Farner.


Changes
-------

uploaded rebased diff manually. rbt stopped working after i pulled.


Bugs: AURORA-579
    https://issues.apache.org/jira/browse/AURORA-579


Repository: aurora


Description
-------

Upgrading Mesos version from 0.18.0 to 0.19.0


Diffs (updated)
-----

  3rdparty/python/BUILD 641d610 
  build.gradle 2756e84 
  examples/scheduler/scheduler-local.sh 7df66f6 
  examples/vagrant/provision-dev-cluster.sh 5b2d544 

Diff: https://reviews.apache.org/r/23348/diff/


Testing
-------

./gradlew build


Thanks,

Dominic Hamon

Re: Review Request 23348: Upgrading Mesos version from 0.18.0 to 0.19.0

Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23348/
-----------------------------------------------------------

(Updated Aug. 8, 2014, 9:46 a.m.)


Review request for Aurora, Joe Smith, Kevin Sweeney, and Bill Farner.


Changes
-------

uploaded rebased diff manually. rbt stopped working after i pulled.


Bugs: AURORA-579
    https://issues.apache.org/jira/browse/AURORA-579


Repository: aurora


Description
-------

Upgrading Mesos version from 0.18.0 to 0.19.0


Diffs (updated)
-----

  3rdparty/python/BUILD 641d610 
  build.gradle 2756e84 
  examples/scheduler/scheduler-local.sh 7df66f6 
  examples/vagrant/provision-dev-cluster.sh 5b2d544 

Diff: https://reviews.apache.org/r/23348/diff/


Testing
-------

./gradlew build


Thanks,

Dominic Hamon

Re: Review Request 23348: Upgrading Mesos version from 0.18.0 to 0.19.0

Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23348/#review49981
-----------------------------------------------------------


Hmm, the rebased patch fails to apply again:

% git rev-parse HEAD  
b0fef4b2004b416784ed9562f0bbcebc8947eeb2
~aurora git aurora/. master    
% ./rbt patch -c 23348
Patch is being applied from request 23348 with diff revision  3.
Failed to execute command: ['git', 'commit', '-m', u'Upgrading Mesos version from 0.18.0 to 0.19.0\n\nTesting Done:\n./gradlew build\n\nBugs closed: AURORA-579\n\nReviewed at https://reviews.apache.org/r/23348/', u'--author="Dominic Hamon <dh...@twopensource.com>"']
On branch master
Your branch is up-to-date with 'origin/master'.

nothing to commit, working directory clean

- Kevin Sweeney


On Aug. 7, 2014, 4:20 p.m., Dominic Hamon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23348/
> -----------------------------------------------------------
> 
> (Updated Aug. 7, 2014, 4:20 p.m.)
> 
> 
> Review request for Aurora, Joe Smith, Kevin Sweeney, and Bill Farner.
> 
> 
> Bugs: AURORA-579
>     https://issues.apache.org/jira/browse/AURORA-579
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Upgrading Mesos version from 0.18.0 to 0.19.0
> 
> 
> Diffs
> -----
> 
>   3rdparty/python/BUILD 122f71db0bc6f37c19ae0f3cb2fcade8321404e6 
>   build.gradle 6c758f690b87eede3ae3a7c54fabac20db543840 
>   examples/scheduler/scheduler-local.sh 9f77af7365c5f1953166cb50ce3903f0558cb79f 
>   examples/vagrant/provision-dev-cluster.sh 97bb877a029fc4c1f32811d0c53be2761fbffae8 
> 
> Diff: https://reviews.apache.org/r/23348/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>

Re: Review Request 23348: Upgrading Mesos version from 0.18.0 to 0.19.0

Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23348/
-----------------------------------------------------------

(Updated Aug. 7, 2014, 4:20 p.m.)


Review request for Aurora, Joe Smith, Kevin Sweeney, and Bill Farner.


Changes
-------

rebased


Bugs: AURORA-579
    https://issues.apache.org/jira/browse/AURORA-579


Repository: aurora


Description
-------

Upgrading Mesos version from 0.18.0 to 0.19.0


Diffs (updated)
-----

  3rdparty/python/BUILD 122f71db0bc6f37c19ae0f3cb2fcade8321404e6 
  build.gradle 6c758f690b87eede3ae3a7c54fabac20db543840 
  examples/scheduler/scheduler-local.sh 9f77af7365c5f1953166cb50ce3903f0558cb79f 
  examples/vagrant/provision-dev-cluster.sh 97bb877a029fc4c1f32811d0c53be2761fbffae8 

Diff: https://reviews.apache.org/r/23348/diff/


Testing
-------

./gradlew build


Thanks,

Dominic Hamon

Re: Review Request 23348: Upgrading Mesos version from 0.18.0 to 0.19.0

Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23348/
-----------------------------------------------------------

(Updated Aug. 7, 2014, 4:20 p.m.)


Review request for Aurora, Joe Smith, Kevin Sweeney, and Bill Farner.


Changes
-------

rebased


Bugs: AURORA-579
    https://issues.apache.org/jira/browse/AURORA-579


Repository: aurora


Description
-------

Upgrading Mesos version from 0.18.0 to 0.19.0


Diffs (updated)
-----

  3rdparty/python/BUILD 122f71db0bc6f37c19ae0f3cb2fcade8321404e6 
  build.gradle 6c758f690b87eede3ae3a7c54fabac20db543840 
  examples/scheduler/scheduler-local.sh 9f77af7365c5f1953166cb50ce3903f0558cb79f 
  examples/vagrant/provision-dev-cluster.sh 97bb877a029fc4c1f32811d0c53be2761fbffae8 

Diff: https://reviews.apache.org/r/23348/diff/


Testing
-------

./gradlew build


Thanks,

Dominic Hamon

Re: Review Request 23348: Upgrading Mesos version from 0.18.0 to 0.19.0

Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23348/
-----------------------------------------------------------

(Updated July 30, 2014, 1:25 p.m.)


Review request for Aurora, Joe Smith, Kevin Sweeney, and Bill Farner.


Changes
-------

rebased


Bugs: AURORA-579
    https://issues.apache.org/jira/browse/AURORA-579


Repository: aurora


Description
-------

Upgrading Mesos version from 0.18.0 to 0.19.0


Diffs (updated)
-----

  3rdparty/python/BUILD 122f71db0bc6f37c19ae0f3cb2fcade8321404e6 
  build.gradle 6c758f690b87eede3ae3a7c54fabac20db543840 
  examples/scheduler/scheduler-local.sh 9f77af7365c5f1953166cb50ce3903f0558cb79f 
  examples/vagrant/provision-dev-cluster.sh 97bb877a029fc4c1f32811d0c53be2761fbffae8 

Diff: https://reviews.apache.org/r/23348/diff/


Testing
-------

./gradlew build


Thanks,

Dominic Hamon

Re: Review Request 23348: Upgrading Mesos version from 0.18.0 to 0.19.0

Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23348/#review48994
-----------------------------------------------------------

Ship it!


Ship It!

- Bill Farner


On July 9, 2014, 7:50 p.m., Dominic Hamon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23348/
> -----------------------------------------------------------
> 
> (Updated July 9, 2014, 7:50 p.m.)
> 
> 
> Review request for Aurora, Joe Smith, Kevin Sweeney, and Bill Farner.
> 
> 
> Bugs: AURORA-579
>     https://issues.apache.org/jira/browse/AURORA-579
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Upgrading Mesos version from 0.18.0 to 0.19.0
> 
> 
> Diffs
> -----
> 
>   3rdparty/python/BUILD 122f71db0bc6f37c19ae0f3cb2fcade8321404e6 
>   build.gradle 6c758f690b87eede3ae3a7c54fabac20db543840 
>   examples/scheduler/scheduler-local.sh 9f77af7365c5f1953166cb50ce3903f0558cb79f 
>   examples/vagrant/provision-dev-cluster.sh 97bb877a029fc4c1f32811d0c53be2761fbffae8 
> 
> Diff: https://reviews.apache.org/r/23348/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>

Re: Review Request 23348: Upgrading Mesos version from 0.18.0 to 0.19.0

Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23348/
-----------------------------------------------------------

(Updated July 30, 2014, 1:25 p.m.)


Review request for Aurora, Joe Smith, Kevin Sweeney, and Bill Farner.


Changes
-------

rebased


Bugs: AURORA-579
    https://issues.apache.org/jira/browse/AURORA-579


Repository: aurora


Description
-------

Upgrading Mesos version from 0.18.0 to 0.19.0


Diffs (updated)
-----

  3rdparty/python/BUILD 122f71db0bc6f37c19ae0f3cb2fcade8321404e6 
  build.gradle 6c758f690b87eede3ae3a7c54fabac20db543840 
  examples/scheduler/scheduler-local.sh 9f77af7365c5f1953166cb50ce3903f0558cb79f 
  examples/vagrant/provision-dev-cluster.sh 97bb877a029fc4c1f32811d0c53be2761fbffae8 

Diff: https://reviews.apache.org/r/23348/diff/


Testing
-------

./gradlew build


Thanks,

Dominic Hamon

Re: Review Request 23348: Upgrading Mesos version from 0.18.0 to 0.19.0

Posted by Dominic Hamon <dh...@twopensource.com>.

> On July 30, 2014, 1:23 p.m., Kevin Sweeney wrote:
> > This patch fails to apply - Dominic, would you mind rebasing?

rebased. didn't see any rebasing issues though.


- Dominic


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23348/#review49156
-----------------------------------------------------------


On July 30, 2014, 1:25 p.m., Dominic Hamon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23348/
> -----------------------------------------------------------
> 
> (Updated July 30, 2014, 1:25 p.m.)
> 
> 
> Review request for Aurora, Joe Smith, Kevin Sweeney, and Bill Farner.
> 
> 
> Bugs: AURORA-579
>     https://issues.apache.org/jira/browse/AURORA-579
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Upgrading Mesos version from 0.18.0 to 0.19.0
> 
> 
> Diffs
> -----
> 
>   3rdparty/python/BUILD 122f71db0bc6f37c19ae0f3cb2fcade8321404e6 
>   build.gradle 6c758f690b87eede3ae3a7c54fabac20db543840 
>   examples/scheduler/scheduler-local.sh 9f77af7365c5f1953166cb50ce3903f0558cb79f 
>   examples/vagrant/provision-dev-cluster.sh 97bb877a029fc4c1f32811d0c53be2761fbffae8 
> 
> Diff: https://reviews.apache.org/r/23348/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>

Re: Review Request 23348: Upgrading Mesos version from 0.18.0 to 0.19.0

Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23348/#review49156
-----------------------------------------------------------


This patch fails to apply - Dominic, would you mind rebasing?

- Kevin Sweeney


On July 9, 2014, 12:50 p.m., Dominic Hamon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23348/
> -----------------------------------------------------------
> 
> (Updated July 9, 2014, 12:50 p.m.)
> 
> 
> Review request for Aurora, Joe Smith, Kevin Sweeney, and Bill Farner.
> 
> 
> Bugs: AURORA-579
>     https://issues.apache.org/jira/browse/AURORA-579
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Upgrading Mesos version from 0.18.0 to 0.19.0
> 
> 
> Diffs
> -----
> 
>   3rdparty/python/BUILD 122f71db0bc6f37c19ae0f3cb2fcade8321404e6 
>   build.gradle 6c758f690b87eede3ae3a7c54fabac20db543840 
>   examples/scheduler/scheduler-local.sh 9f77af7365c5f1953166cb50ce3903f0558cb79f 
>   examples/vagrant/provision-dev-cluster.sh 97bb877a029fc4c1f32811d0c53be2761fbffae8 
> 
> Diff: https://reviews.apache.org/r/23348/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>

Re: Review Request 23348: Upgrading Mesos version from 0.18.0 to 0.19.0

Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23348/
-----------------------------------------------------------

(Updated July 9, 2014, 7:50 p.m.)


Review request for Aurora, Joe Smith, Kevin Sweeney, and Bill Farner.


Bugs: AURORA-579
    https://issues.apache.org/jira/browse/AURORA-579


Repository: aurora


Description
-------

Upgrading Mesos version from 0.18.0 to 0.19.0


Diffs
-----

  3rdparty/python/BUILD 122f71db0bc6f37c19ae0f3cb2fcade8321404e6 
  build.gradle 6c758f690b87eede3ae3a7c54fabac20db543840 
  examples/scheduler/scheduler-local.sh 9f77af7365c5f1953166cb50ce3903f0558cb79f 
  examples/vagrant/provision-dev-cluster.sh 97bb877a029fc4c1f32811d0c53be2761fbffae8 

Diff: https://reviews.apache.org/r/23348/diff/


Testing
-------

./gradlew build


Thanks,

Dominic Hamon

Re: Review Request 23348: Upgrading Mesos version from 0.18.0 to 0.19.0

Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23348/
-----------------------------------------------------------

(Updated July 9, 2014, 7:50 p.m.)


Review request for Aurora, Joe Smith, Kevin Sweeney, and Bill Farner.


Bugs: AURORA-579
    https://issues.apache.org/jira/browse/AURORA-579


Repository: aurora


Description
-------

Upgrading Mesos version from 0.18.0 to 0.19.0


Diffs
-----

  3rdparty/python/BUILD 122f71db0bc6f37c19ae0f3cb2fcade8321404e6 
  build.gradle 6c758f690b87eede3ae3a7c54fabac20db543840 
  examples/scheduler/scheduler-local.sh 9f77af7365c5f1953166cb50ce3903f0558cb79f 
  examples/vagrant/provision-dev-cluster.sh 97bb877a029fc4c1f32811d0c53be2761fbffae8 

Diff: https://reviews.apache.org/r/23348/diff/


Testing
-------

./gradlew build


Thanks,

Dominic Hamon

Re: Review Request 23348: Upgrading Mesos version from 0.18.0 to 0.19.0

Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23348/
-----------------------------------------------------------

(Updated July 9, 2014, 12:40 p.m.)


Review request for Aurora, Joe Smith, Kevin Sweeney, and Bill Farner.


Changes
-------

updated group to 'aurora'


Repository: aurora


Description
-------

Upgrading Mesos version from 0.18.0 to 0.19.0


Diffs
-----

  3rdparty/python/BUILD 122f71db0bc6f37c19ae0f3cb2fcade8321404e6 
  build.gradle 6c758f690b87eede3ae3a7c54fabac20db543840 
  examples/scheduler/scheduler-local.sh 9f77af7365c5f1953166cb50ce3903f0558cb79f 
  examples/vagrant/provision-dev-cluster.sh 97bb877a029fc4c1f32811d0c53be2761fbffae8 

Diff: https://reviews.apache.org/r/23348/diff/


Testing
-------

./gradlew build


Thanks,

Dominic Hamon

Re: Review Request 23348: Upgrading Mesos version from 0.18.0 to 0.19.0

Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23348/
-----------------------------------------------------------

(Updated July 9, 2014, 12:40 p.m.)


Review request for Aurora, Joe Smith, Kevin Sweeney, and Bill Farner.


Changes
-------

updated group to 'aurora'


Repository: aurora


Description
-------

Upgrading Mesos version from 0.18.0 to 0.19.0


Diffs
-----

  3rdparty/python/BUILD 122f71db0bc6f37c19ae0f3cb2fcade8321404e6 
  build.gradle 6c758f690b87eede3ae3a7c54fabac20db543840 
  examples/scheduler/scheduler-local.sh 9f77af7365c5f1953166cb50ce3903f0558cb79f 
  examples/vagrant/provision-dev-cluster.sh 97bb877a029fc4c1f32811d0c53be2761fbffae8 

Diff: https://reviews.apache.org/r/23348/diff/


Testing
-------

./gradlew build


Thanks,

Dominic Hamon