You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by kkabell <gi...@git.apache.org> on 2015/02/25 16:48:59 UTC
[GitHub] cordova-plugin-media-capture pull request: iOS: Allow video qualit...
GitHub user kkabell opened a pull request:
https://github.com/apache/cordova-plugin-media-capture/pull/32
iOS: Allow video quality to be specified in CaptureVideoOptions
Implements a new property in CaptureVideoOptions which allows for specifying the quality of captured video as an integer in the range 0-100 with 100 being the highest possible quality.
The specified value is translated into one of the following `UIImagePickerControllerQualityType` constants ([see Apple docs](https://developer.apple.com/library/ios/documentation/UIKit/Reference/UIImagePickerController_Class/#//apple_ref/c/tdef/UIImagePickerControllerQualityType)):
0-32: `UIImagePickerControllerQualityTypeLow`
33-65: `UIImagePickerControllerQualityTypeMedium`
66-100: `UIImagePickerControllerQualityTypeHigh`
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kkabell/cordova-plugin-media-capture master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-media-capture/pull/32.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #32
----
commit 7766b50dba2e59656f6f6e157d4279069a456f8e
Author: Kalle Kabell <kk...@gmail.com>
Date: 2015-02-25T15:37:56Z
iOS: Allow video quality to be specified in CaptureVideoOptions
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-media-capture pull request #32: iOS: Allow video quality to b...
Posted by kkabell <gi...@git.apache.org>.
Github user kkabell closed the pull request at:
https://github.com/apache/cordova-plugin-media-capture/pull/32
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-media-capture pull request: iOS: Allow video qualit...
Posted by kkabell <gi...@git.apache.org>.
Github user kkabell commented on the pull request:
https://github.com/apache/cordova-plugin-media-capture/pull/32#issuecomment-77197665
@riaan53 The app that I'm developing is iOS-only for the time being, but I'm planning to release for Android as well within the coming month. I haven't started that project yet, but if this plugin does not automatically capture video in the highest possible quality, I will probably need to do something similar for Android.
Glad to hear that it's useful for you as well, by the way :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-media-capture pull request: iOS: Allow video qualit...
Posted by riaan53 <gi...@git.apache.org>.
Github user riaan53 commented on the pull request:
https://github.com/apache/cordova-plugin-media-capture/pull/32#issuecomment-76888530
@kkabell thank you this works great! :)
Are you/do you plan to do this for android as well?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org