You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "paolorechia (via GitHub)" <gi...@apache.org> on 2023/03/25 07:46:53 UTC
[GitHub] [arrow-ballista] paolorechia opened a new pull request, #718: Issue 717 use nvm in docker build
paolorechia opened a new pull request, #718:
URL: https://github.com/apache/arrow-ballista/pull/718
# Which issue does this PR close?
Closes #717.
# Rationale for this change
The current build for the `main` branch is broken, as reported in the issue #717. This change aims to make it working again.
# What changes are included in this PR?
- Changes to the builder Dockerfile to use the NVM to install the appropriate node version.
- Sets node version to v16.9.1
# Are there any user-facing changes?
No, but it may be useful to update the documentation to showcase that it's now possible to build from the `main` branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-ballista] paolorechia commented on pull request #718: Issue 717 use nvm in docker build
Posted by "paolorechia (via GitHub)" <gi...@apache.org>.
paolorechia commented on PR #718:
URL: https://github.com/apache/arrow-ballista/pull/718#issuecomment-1487960278
@andygrove Hi, I saw you recently triggered the docker build on the other PR. It won’t work until this issue is addressed first (pinning down a compatible node version).
If it helps to review/test I could instead address both issues on a single PR instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-ballista] jnaous commented on pull request #718: Issue 717 use nvm in docker build
Posted by "jnaous (via GitHub)" <gi...@apache.org>.
jnaous commented on PR #718:
URL: https://github.com/apache/arrow-ballista/pull/718#issuecomment-1492402930
Hi, @paolorechia! I also submitted a patch (#731) for this, but installing nodejs from source, using node version 18. Take a look and see which you prefer... I can close mine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-ballista] paolorechia commented on pull request #718: Issue 717 use nvm in docker build
Posted by "paolorechia (via GitHub)" <gi...@apache.org>.
paolorechia commented on PR #718:
URL: https://github.com/apache/arrow-ballista/pull/718#issuecomment-1483755444
Built docker images:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Issue 717 use nvm in docker build [arrow-ballista]
Posted by "paolorechia (via GitHub)" <gi...@apache.org>.
paolorechia commented on PR #718:
URL: https://github.com/apache/arrow-ballista/pull/718#issuecomment-1919965318
It's stale for a while.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-ballista] avantgardnerio commented on pull request #718: Issue 717 use nvm in docker build
Posted by "avantgardnerio (via GitHub)" <gi...@apache.org>.
avantgardnerio commented on PR #718:
URL: https://github.com/apache/arrow-ballista/pull/718#issuecomment-1492415926
> which you prefer
I'd advocate for whichever is easier for the developer to:
1. see in the CI script
2. reproduce in their local environment
IMO `nvm` would be closer to that as they might have to deal with multiple versions of node, and it's a one line command.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-ballista] paolorechia commented on pull request #718: Issue 717 use nvm in docker build
Posted by "paolorechia (via GitHub)" <gi...@apache.org>.
paolorechia commented on PR #718:
URL: https://github.com/apache/arrow-ballista/pull/718#issuecomment-1492430696
Hi, @jnaous
I don't have a strong preference here, I just wanted to fix the build so I could move forward with docker build workflow: https://github.com/apache/arrow-ballista/issues/162
One advantage I see with your PR is that you use Node 18 as opposed to Node 16 from my PR, as I ran into issues with the OpenSSL library.
It seems that you solved this issue with Node 18 it by adding `--openssl-legacy-provider` into the react build command, so it should also be easy to reuse your solution with my NVM PR.
Either way, both approaches work for me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Issue 717 use nvm in docker build [arrow-ballista]
Posted by "paolorechia (via GitHub)" <gi...@apache.org>.
paolorechia closed pull request #718: Issue 717 use nvm in docker build
URL: https://github.com/apache/arrow-ballista/pull/718
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org