You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2017/07/06 01:33:41 UTC
[kudu-CR] java: add a new test for multiple sessions on a single client
Hello Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/7361
to review the following change.
Change subject: java: add a new test for multiple sessions on a single client
......................................................................
java: add a new test for multiple sessions on a single client
I was hoping this would reproduce KUDU-2053, a client bug that seems to
be hitting Spark upsert use cases, but it didn't reproduce it.
Nonetheless, we don't seem to have any test coverage of multithreaded
use of a KuduClient with different KuduSession objects, so this test is
valuable.
Change-Id: Ife7f02b160d4635e8acb0155c98a1ef9c3dbab5e
---
M java/kudu-client/src/test/java/org/apache/kudu/client/ITClientStress.java
1 file changed, 56 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/61/7361/1
--
To view, visit http://gerrit.cloudera.org:8080/7361
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ife7f02b160d4635e8acb0155c98a1ef9c3dbab5e
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
[kudu-CR] java: add a new test for multiple sessions on a single client
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change.
Change subject: java: add a new test for multiple sessions on a single client
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/7361
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife7f02b160d4635e8acb0155c98a1ef9c3dbab5e
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] java: add a new test for multiple sessions on a single client
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has submitted this change and it was merged.
Change subject: java: add a new test for multiple sessions on a single client
......................................................................
java: add a new test for multiple sessions on a single client
I was hoping this would reproduce KUDU-2053, a client bug that seems to
be hitting Spark upsert use cases, but it didn't reproduce it.
Nonetheless, we don't seem to have any test coverage of multithreaded
use of a KuduClient with different KuduSession objects, so this test is
valuable.
Change-Id: Ife7f02b160d4635e8acb0155c98a1ef9c3dbab5e
Reviewed-on: http://gerrit.cloudera.org:8080/7361
Reviewed-by: Jean-Daniel Cryans <jd...@apache.org>
Tested-by: Jean-Daniel Cryans <jd...@apache.org>
---
M java/kudu-client/src/test/java/org/apache/kudu/client/ITClientStress.java
1 file changed, 56 insertions(+), 3 deletions(-)
Approvals:
Jean-Daniel Cryans: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/7361
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ife7f02b160d4635e8acb0155c98a1ef9c3dbab5e
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] java: add a new test for multiple sessions on a single client
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change.
Change subject: java: add a new test for multiple sessions on a single client
......................................................................
Patch Set 2:
Jenkins failure was unrelated.
--
To view, visit http://gerrit.cloudera.org:8080/7361
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife7f02b160d4635e8acb0155c98a1ef9c3dbab5e
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] java: add a new test for multiple sessions on a single client
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7361
to look at the new patch set (#2).
Change subject: java: add a new test for multiple sessions on a single client
......................................................................
java: add a new test for multiple sessions on a single client
I was hoping this would reproduce KUDU-2053, a client bug that seems to
be hitting Spark upsert use cases, but it didn't reproduce it.
Nonetheless, we don't seem to have any test coverage of multithreaded
use of a KuduClient with different KuduSession objects, so this test is
valuable.
Change-Id: Ife7f02b160d4635e8acb0155c98a1ef9c3dbab5e
---
M java/kudu-client/src/test/java/org/apache/kudu/client/ITClientStress.java
1 file changed, 56 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/61/7361/2
--
To view, visit http://gerrit.cloudera.org:8080/7361
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ife7f02b160d4635e8acb0155c98a1ef9c3dbab5e
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] java: add a new test for multiple sessions on a single client
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: java: add a new test for multiple sessions on a single client
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/7361/1/java/kudu-client/src/test/java/org/apache/kudu/client/ITClientStress.java
File java/kudu-client/src/test/java/org/apache/kudu/client/ITClientStress.java:
Line 149: OperationResponse apply = s.apply(u);
> FWIW apply() can also send exceptions.
that's OK - it'll still end up getting caught in the catch clause on line 64
PS1, Line 164: LOG.info("Upserted {} rows", numUpserted.get());
> nit: does it make sense to add verification on the expected number of upser
the test runs for a prescribed amount of time, rather than a prescribed number of upserts, so hard to assert on much here
--
To view, visit http://gerrit.cloudera.org:8080/7361
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife7f02b160d4635e8acb0155c98a1ef9c3dbab5e
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] java: add a new test for multiple sessions on a single client
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change.
Change subject: java: add a new test for multiple sessions on a single client
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7361
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife7f02b160d4635e8acb0155c98a1ef9c3dbab5e
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] java: add a new test for multiple sessions on a single client
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change.
Change subject: java: add a new test for multiple sessions on a single client
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7361/1/java/kudu-client/src/test/java/org/apache/kudu/client/ITClientStress.java
File java/kudu-client/src/test/java/org/apache/kudu/client/ITClientStress.java:
Line 149: OperationResponse apply = s.apply(u);
FWIW apply() can also send exceptions.
--
To view, visit http://gerrit.cloudera.org:8080/7361
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife7f02b160d4635e8acb0155c98a1ef9c3dbab5e
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] java: add a new test for multiple sessions on a single client
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: java: add a new test for multiple sessions on a single client
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7361/1/java/kudu-client/src/test/java/org/apache/kudu/client/ITClientStress.java
File java/kudu-client/src/test/java/org/apache/kudu/client/ITClientStress.java:
PS1, Line 164: LOG.info("Upserted {} rows", numUpserted.get());
nit: does it make sense to add verification on the expected number of upserts commenced?
--
To view, visit http://gerrit.cloudera.org:8080/7361
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife7f02b160d4635e8acb0155c98a1ef9c3dbab5e
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes