You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Scott O'Bryan (JIRA)" <de...@myfaces.apache.org> on 2012/07/19 18:24:35 UTC

[jira] [Created] (TRINIDAD-2291) Binary incompatibility with RequestContext from 2.0.1

Scott O'Bryan created TRINIDAD-2291:
---------------------------------------

             Summary: Binary incompatibility with RequestContext from 2.0.1
                 Key: TRINIDAD-2291
                 URL: https://issues.apache.org/jira/browse/TRINIDAD-2291
             Project: MyFaces Trinidad
          Issue Type: Bug
          Components: Infrastructure
    Affects Versions: 2.1.0-core
            Reporter: Scott O'Bryan
            Assignee: Scott O'Bryan
            Priority: Minor


The commit for TRINIDAD-2258 (txn 1330065) introduced a binary compatibility issue from 2.0.1.  Essentially 2 method were added to the RequestContext for chunked file uploading.  In order to catch new API's, I've been updating the clirr runner tests to ensure binary compatibility with 2.0.1.

For this class to be strictly binary compatible, you need to provide a default implementation for these new methods in the abstract class.  I understand that there are generally not many implementations of this class, but some mock object also needed to be changed because of this incompatibility and  given the nature of these methods, I do not thing a default implementation would be too difficult.  Can you please fix this and submit a patch so the clirr runner tests may be updated.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (TRINIDAD-2291) Binary incompatibility with RequestContext from 2.0.1

Posted by "Scott O'Bryan (JIRA)" <de...@myfaces.apache.org>.
     [ https://issues.apache.org/jira/browse/TRINIDAD-2291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Scott O'Bryan resolved TRINIDAD-2291.
-------------------------------------

       Resolution: Fixed
    Fix Version/s: 2.1.0-core
    
> Binary incompatibility with RequestContext from 2.0.1
> -----------------------------------------------------
>
>                 Key: TRINIDAD-2291
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-2291
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>          Components: Infrastructure
>    Affects Versions: 2.1.0-core
>            Reporter: Scott O'Bryan
>            Assignee: Scott O'Bryan
>            Priority: Minor
>             Fix For: 2.1.0-core
>
>         Attachments: TRINIDAD-2291.patch
>
>
> The commit for TRINIDAD-2258 (txn 1330065) introduced a binary compatibility issue from 2.0.1.  Essentially 2 method were added to the RequestContext for chunked file uploading.  In order to catch new API's, I've been updating the clirr runner tests to ensure binary compatibility with 2.0.1.
> For this class to be strictly binary compatible, you need to provide a default implementation for these new methods in the abstract class.  I understand that there are generally not many implementations of this class, but some mock object also needed to be changed because of this incompatibility and  given the nature of these methods, I do not thing a default implementation would be too difficult.  Can you please fix this and submit a patch so the clirr runner tests may be updated.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (TRINIDAD-2291) Binary incompatibility with RequestContext from 2.0.1

Posted by "Scott O'Bryan (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/TRINIDAD-2291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13418606#comment-13418606 ] 

Scott O'Bryan commented on TRINIDAD-2291:
-----------------------------------------

Checked into trunk (1363499)
                
> Binary incompatibility with RequestContext from 2.0.1
> -----------------------------------------------------
>
>                 Key: TRINIDAD-2291
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-2291
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>          Components: Infrastructure
>    Affects Versions: 2.1.0-core
>            Reporter: Scott O'Bryan
>            Assignee: Scott O'Bryan
>            Priority: Minor
>             Fix For: 2.1.0-core
>
>         Attachments: TRINIDAD-2291.patch
>
>
> The commit for TRINIDAD-2258 (txn 1330065) introduced a binary compatibility issue from 2.0.1.  Essentially 2 method were added to the RequestContext for chunked file uploading.  In order to catch new API's, I've been updating the clirr runner tests to ensure binary compatibility with 2.0.1.
> For this class to be strictly binary compatible, you need to provide a default implementation for these new methods in the abstract class.  I understand that there are generally not many implementations of this class, but some mock object also needed to be changed because of this incompatibility and  given the nature of these methods, I do not thing a default implementation would be too difficult.  Can you please fix this and submit a patch so the clirr runner tests may be updated.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (TRINIDAD-2291) Binary incompatibility with RequestContext from 2.0.1

Posted by "Kentaro Kinebuchi (JIRA)" <de...@myfaces.apache.org>.
     [ https://issues.apache.org/jira/browse/TRINIDAD-2291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kentaro Kinebuchi updated TRINIDAD-2291:
----------------------------------------

    Status: Patch Available  (was: Open)
    
> Binary incompatibility with RequestContext from 2.0.1
> -----------------------------------------------------
>
>                 Key: TRINIDAD-2291
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-2291
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>          Components: Infrastructure
>    Affects Versions: 2.1.0-core
>            Reporter: Scott O'Bryan
>            Assignee: Scott O'Bryan
>            Priority: Minor
>         Attachments: TRINIDAD-2291.patch
>
>
> The commit for TRINIDAD-2258 (txn 1330065) introduced a binary compatibility issue from 2.0.1.  Essentially 2 method were added to the RequestContext for chunked file uploading.  In order to catch new API's, I've been updating the clirr runner tests to ensure binary compatibility with 2.0.1.
> For this class to be strictly binary compatible, you need to provide a default implementation for these new methods in the abstract class.  I understand that there are generally not many implementations of this class, but some mock object also needed to be changed because of this incompatibility and  given the nature of these methods, I do not thing a default implementation would be too difficult.  Can you please fix this and submit a patch so the clirr runner tests may be updated.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira