[GitHub] [spark] HeartSaVioR edited a comment on pull request #28422: [SPARK-17604][SS] FileStreamSource: provide a new option to have retention on input files

[GitBox <gi...@apache.org>]

HeartSaVioR edited a comment on pull request #28422:
URL: https://github.com/apache/spark/pull/28422#issuecomment-640424887


   > Maybe the user group reference can be added as a comment and not as commit msg.
   
   I'll move it to the JIRA description - personally I'd be OK to leave the rationalization in commit message, but I agree it's redundant and make commit message be verbose.
   
   (EDIT: I already did that, skipping)
   
   >> I've manually tested with above two behaviors as well.
   
   > How do you mean that exactly?
   
   I meant both two behaviors are manually tested
   
   1. old files should not be included as input files if input retention is specified
   2. when compacting, outdated entries should be filtered out
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org