svn commit: r1590984 - /subversion/trunk/subversion/libsvn_ra_svn/marshal.c

[st...@apache.org]

Author: stefan2
Date: Tue Apr 29 13:57:41 2014
New Revision: 1590984

URL: http://svn.apache.org/r1590984
Log:
Make the ra_svn detect connection failures (such as a terminated client)
more quickly by actually passing detected errors down the stack.

This also fixes the associated error leak(s).

* subversion/libsvn_ra_svn/marshal.c
  (svn_ra_svn__write_string,
   svn_ra_svn__write_cstring): Don't swallow the svn_ra_svn__write_ncstring
                               return values.

Modified:
    subversion/trunk/subversion/libsvn_ra_svn/marshal.c

Modified: subversion/trunk/subversion/libsvn_ra_svn/marshal.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_svn/marshal.c?rev=1590984&r1=1590983&r2=1590984&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_ra_svn/marshal.c (original)
+++ subversion/trunk/subversion/libsvn_ra_svn/marshal.c Tue Apr 29 13:57:41 2014
@@ -533,7 +533,7 @@ svn_ra_svn__write_string(svn_ra_svn_conn
                          apr_pool_t *pool,
                          const svn_string_t *str)
 {
-  svn_ra_svn__write_ncstring(conn, pool, str->data, str->len);
+  SVN_ERR(svn_ra_svn__write_ncstring(conn, pool, str->data, str->len));
   return SVN_NO_ERROR;
 }
 
@@ -542,7 +542,7 @@ svn_ra_svn__write_cstring(svn_ra_svn_con
                           apr_pool_t *pool,
                           const char *s)
 {
-  svn_ra_svn__write_ncstring(conn, pool, s, strlen(s));
+  SVN_ERR(svn_ra_svn__write_ncstring(conn, pool, s, strlen(s)));
   return SVN_NO_ERROR;
 }