You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tomee.apache.org by rm...@apache.org on 2012/10/11 17:29:05 UTC

svn commit: r1397108 - /openejb/trunk/openejb/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/MethodInfoUtil.java

Author: rmannibucau
Date: Thu Oct 11 15:29:04 2012
New Revision: 1397108

URL: http://svn.apache.org/viewvc?rev=1397108&view=rev
Log:
OPENEJB-1919 array type comparison not working on some JVM

Modified:
    openejb/trunk/openejb/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/MethodInfoUtil.java

Modified: openejb/trunk/openejb/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/MethodInfoUtil.java
URL: http://svn.apache.org/viewvc/openejb/trunk/openejb/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/MethodInfoUtil.java?rev=1397108&r1=1397107&r2=1397108&view=diff
==============================================================================
--- openejb/trunk/openejb/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/MethodInfoUtil.java (original)
+++ openejb/trunk/openejb/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/MethodInfoUtil.java Thu Oct 11 15:29:04 2012
@@ -528,7 +528,7 @@ public class MethodInfoUtil {
         for (int i = 0; i < parameterTypes.length; i++) {
             Class<?> parameterType = parameterTypes[i];
             String methodParam = methodParams.get(i);
-            if (!methodParam.equals(getName(parameterType))) {
+            if (!methodParam.equals(getName(parameterType)) && !methodParam.equals(parameterType.getName())) {
                 return false;
             }
         }
@@ -538,7 +538,7 @@ public class MethodInfoUtil {
 
     private static String getName(Class<?> type) {
         if (type.isArray()) {
-            return getName(type.getComponentType()) + "[]";
+            return getName(type.getComponentType()) + "[]"; // depend on JVM? type.getName() seems to work on Oracle one
         } else {
             return type.getName();
         }