[DISCUSS] KIP-756: Move StreamsResetter tool outside of core

[Jorge Esteban Quilcate Otoya <qu...@gmail.com>]

Hi everyone,

Hope you are all well and safe.

I'd like to propose the following KIP:
https://cwiki.apache.org/confluence/display/KAFKA/KIP-756%3A+Move+StreamsResetter+tool+outside+of+core

The goal is to move `StreamsResetter` tool outside of `core` module, and
allow Kafka Streams users to access it from their applications. More info
here: https://issues.apache.org/jira/browse/KAFKA-4327

Looking forward to your feedback.

Cheers,
Jorge.

Re: [DISCUSS] KIP-756: Move StreamsResetter tool outside of core

["Matthias J. Sax" <mj...@apache.org>]

Thanks for the KIP.

The KIP seems to post quite some implementation details, why? We should
focus on the public API only to make it easier to read.

The new class also does not contain a `main()` method that we need to
run the resetter as command line tool.

nit: can we use `applicationId` instead of `groupId` ?

Should `Properties` be optional for `StreamsResetter`?

Should the constructors of `StreamsResetterOptions` be private (similar
to `ResetOffsetsOptions` ?

Why is `DATETIME_FORMAT` public?

Should we follow a builder pattern for `StreamsResetterOptions` to force
consumer removal and for dry run?


-Matthias

On 6/8/21 12:30 PM, Jorge Esteban Quilcate Otoya wrote:
> Hi everyone,
> 
> Hope you are all well and safe.
> 
> I'd like to propose the following KIP:
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-756%3A+Move+StreamsResetter+tool+outside+of+core
> 
> The goal is to move `StreamsResetter` tool outside of `core` module, and
> allow Kafka Streams users to access it from their applications. More info
> here: https://issues.apache.org/jira/browse/KAFKA-4327
> 
> Looking forward to your feedback.
> 
> Cheers,
> Jorge.
>