[jira] [Assigned] (AVRO-3617) [C++] Integer overflow risks with Validator::count_ and Validator::counters_

["Christophe Le Saec (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/AVRO-3617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Christophe Le Saec reassigned AVRO-3617:
----------------------------------------

    Assignee: Christophe Le Saec

> [C++] Integer overflow risks with Validator::count_ and Validator::counters_
> ----------------------------------------------------------------------------
>
>                 Key: AVRO-3617
>                 URL: https://issues.apache.org/jira/browse/AVRO-3617
>             Project: Apache Avro
>          Issue Type: Bug
>          Components: c++
>            Reporter: Kalle Niemitalo
>            Assignee: Christophe Le Saec
>            Priority: Minor
>              Labels: pull-request-available
>          Time Spent: 2h 20m
>  Remaining Estimate: 0h
>
> In Validator, there seems to be some inconsistency with {{std::vector<size_t> counters_}} and {{int64_t count_}}:
> - Validator::countingSetup converts int64_t to size_t: {{counters_.push_back(static_cast<size_t>(count_));}}
> - Validator::countingAdvance converts size_t to int: {{int count = --counters_.back();}}
> - Validator::unionAdvance converts size_t to int64_t: {{if (count_ < static_cast<int64_t>(node->leaves()))}}
> - Validator::unionAdvance converts int64_t to int and that to size_t: {{setupOperation(node->leafAt(static_cast<int>(count_)));}}
> I did not verify whether these integers can actually grow so high that overflow is possible. Nevertheless, it would be safest to use integer types consistently.
> (Originally posted as [https://github.com/apache/avro/pull/1836#issuecomment-1225303643].)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)