You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2016/01/23 00:21:14 UTC

Review Request 42672: Explicitly checked for the absence of allocation.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42672/
-----------------------------------------------------------

Review request for mesos and Ben Mahler.


Repository: mesos


Description
-------

Ensure the future for allocation is pending when there should be no
allocations. Reduce the number of allocations triggered in the test.


Diffs
-----

  src/tests/hierarchical_allocator_tests.cpp b1cb955b7eb1213c7ba4a9c5181545bb49154f06 

Diff: https://reviews.apache.org/r/42672/diff/


Testing
-------

On Mac OS 10.10.4:

`make check`

`GTEST_FILTER="HierarchicalAllocatorTest.*" ./bin/mesos-tests.sh --gtest_repeat=100 --gtest_break_on_failure --gtest_shuffle`


Thanks,

Alexander Rukletsov

Re: Review Request 42672: Explicitly checked for the absence of allocation.

Posted by Ben Mahler <be...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42672/#review118420
-----------------------------------------------------------


Ship it!




Ship It!

- Ben Mahler


On Jan. 28, 2016, 1:22 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42672/
> -----------------------------------------------------------
> 
> (Updated Jan. 28, 2016, 1:22 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Ensure the future for allocation is pending when there should be no
> allocations. Reduce the number of allocations triggered in the test.
> 
> 
> Diffs
> -----
> 
>   src/tests/hierarchical_allocator_tests.cpp f18e6eb10572b0f5b8bbff338384d9406f6ad62b 
> 
> Diff: https://reviews.apache.org/r/42672/diff/
> 
> 
> Testing
> -------
> 
> On Mac OS 10.10.4:
> 
> `make check`
> 
> `GTEST_FILTER="HierarchicalAllocatorTest.*" ./bin/mesos-tests.sh --gtest_repeat=100 --gtest_break_on_failure --gtest_shuffle`
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 42672: Explicitly checked for the absence of allocation.

Posted by Alexander Rukletsov <ru...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42672/
-----------------------------------------------------------

(Updated Jan. 28, 2016, 1:22 p.m.)


Review request for mesos and Ben Mahler.


Changes
-------

Reabsed.


Repository: mesos


Description
-------

Ensure the future for allocation is pending when there should be no
allocations. Reduce the number of allocations triggered in the test.


Diffs (updated)
-----

  src/tests/hierarchical_allocator_tests.cpp f18e6eb10572b0f5b8bbff338384d9406f6ad62b 

Diff: https://reviews.apache.org/r/42672/diff/


Testing
-------

On Mac OS 10.10.4:

`make check`

`GTEST_FILTER="HierarchicalAllocatorTest.*" ./bin/mesos-tests.sh --gtest_repeat=100 --gtest_break_on_failure --gtest_shuffle`


Thanks,

Alexander Rukletsov

Re: Review Request 42672: Explicitly checked for the absence of allocation.

Posted by Alexander Rukletsov <ru...@gmail.com>.


> On Jan. 23, 2016, 6:31 a.m., Guangya Liu wrote:
> > src/tests/hierarchical_allocator_tests.cpp, line 1494
> > <https://reviews.apache.org/r/42672/diff/1/?file=1218656#file1218656line1494>
> >
> >     remove the blank line?

Which line do you mean?


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42672/#review115975
-----------------------------------------------------------


On Jan. 22, 2016, 11:21 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42672/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2016, 11:21 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Ensure the future for allocation is pending when there should be no
> allocations. Reduce the number of allocations triggered in the test.
> 
> 
> Diffs
> -----
> 
>   src/tests/hierarchical_allocator_tests.cpp b1cb955b7eb1213c7ba4a9c5181545bb49154f06 
> 
> Diff: https://reviews.apache.org/r/42672/diff/
> 
> 
> Testing
> -------
> 
> On Mac OS 10.10.4:
> 
> `make check`
> 
> `GTEST_FILTER="HierarchicalAllocatorTest.*" ./bin/mesos-tests.sh --gtest_repeat=100 --gtest_break_on_failure --gtest_shuffle`
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 42672: Explicitly checked for the absence of allocation.

Posted by Guangya Liu <gy...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42672/#review115975
-----------------------------------------------------------




src/tests/hierarchical_allocator_tests.cpp (line 1480)
<https://reviews.apache.org/r/42672/#comment177019>

    remove the blank line?


- Guangya Liu


On 一月 22, 2016, 11:21 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42672/
> -----------------------------------------------------------
> 
> (Updated 一月 22, 2016, 11:21 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Ensure the future for allocation is pending when there should be no
> allocations. Reduce the number of allocations triggered in the test.
> 
> 
> Diffs
> -----
> 
>   src/tests/hierarchical_allocator_tests.cpp b1cb955b7eb1213c7ba4a9c5181545bb49154f06 
> 
> Diff: https://reviews.apache.org/r/42672/diff/
> 
> 
> Testing
> -------
> 
> On Mac OS 10.10.4:
> 
> `make check`
> 
> `GTEST_FILTER="HierarchicalAllocatorTest.*" ./bin/mesos-tests.sh --gtest_repeat=100 --gtest_break_on_failure --gtest_shuffle`
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 42672: Explicitly checked for the absence of allocation.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42672/#review115980
-----------------------------------------------------------



Patch looks great!

Reviews applied: [42633, 42636, 42657, 42658, 41950, 42672]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 22, 2016, 11:21 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42672/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2016, 11:21 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Ensure the future for allocation is pending when there should be no
> allocations. Reduce the number of allocations triggered in the test.
> 
> 
> Diffs
> -----
> 
>   src/tests/hierarchical_allocator_tests.cpp b1cb955b7eb1213c7ba4a9c5181545bb49154f06 
> 
> Diff: https://reviews.apache.org/r/42672/diff/
> 
> 
> Testing
> -------
> 
> On Mac OS 10.10.4:
> 
> `make check`
> 
> `GTEST_FILTER="HierarchicalAllocatorTest.*" ./bin/mesos-tests.sh --gtest_repeat=100 --gtest_break_on_failure --gtest_shuffle`
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>