[GitHub] [hudi] alexeykudinkin commented on a diff in pull request #7619: [MINOR] Optimizing schema validation in Metadata table

["alexeykudinkin (via GitHub)" <gi...@apache.org>]

alexeykudinkin commented on code in PR #7619:
URL: https://github.com/apache/hudi/pull/7619#discussion_r1087420704


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/HoodieTable.java:
##########
@@ -814,18 +820,22 @@ private void validateSchema() throws HoodieUpsertException, HoodieInsertExceptio
   }
 
   public void validateUpsertSchema() throws HoodieUpsertException {
-    try {
-      validateSchema();
-    } catch (HoodieException e) {
-      throw new HoodieUpsertException("Failed upsert schema compatibility check", e);
+    if (!isMetadataTable) {

Review Comment:
   nit: Inverting conditional makes it easier to read
   
   ```
   if (isMeta) {
     return
   }
   
   // Otherwise proceed
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org